From: Pavel Begunkov <asml.silence@gmail.com>
To: Olivier Langlois <olivier@trillion01.com>,
Jens Axboe <axboe@kernel.dk>,
io-uring@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] io_uring: Fix race condition when sqp thread goes to sleep
Date: Tue, 22 Jun 2021 19:55:51 +0100 [thread overview]
Message-ID: <d9d9527c-6d2e-b840-15dd-057618de7864@gmail.com> (raw)
In-Reply-To: <b056b26aec5abad8e4e06aae84bd9a5bfe5f43da.camel@trillion01.com>
On 6/22/21 7:53 PM, Olivier Langlois wrote:
> On Tue, 2021-06-22 at 11:45 -0700, Olivier Langlois wrote:
>> If an asynchronous completion happens before the task is preparing
>> itself to wait and set its state to TASK_INTERRUPTABLE, the
>> completion
>> will not wake up the sqp thread.
>>
> I have just noticed that I made a typo in the description. I will send
> a v2 of that patch.
>
> Sorry about that. I was too excited to share my discovery...
git format-patch --cover-letter --thread=shallow ...
would be even better, but the fix looks right
--
Pavel Begunkov
next prev parent reply other threads:[~2021-06-22 18:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 18:45 [PATCH 0/2] Minor SQPOLL thread fix and improvement Olivier Langlois, Olivier Langlois
2021-06-22 18:45 ` [PATCH 1/2] io_uring: Fix race condition when sqp thread goes to sleep Olivier Langlois
2021-06-22 18:53 ` Olivier Langlois
2021-06-22 18:55 ` Pavel Begunkov [this message]
2021-06-22 19:07 ` Olivier Langlois
[not found] ` <60d23218.1c69fb81.79e86.f345SMTPIN_ADDED_MISSING@mx.google.com>
2021-06-22 20:45 ` [PATCH 1/2 v2] " Pavel Begunkov
2021-06-22 22:37 ` Olivier Langlois
2021-06-22 22:42 ` Olivier Langlois
2021-06-22 23:03 ` Pavel Begunkov
2021-06-23 13:52 ` Olivier Langlois
2021-06-23 15:58 ` Pavel Begunkov
2021-06-22 18:45 ` [PATCH 2/2] io_uring: Create define to modify a SQPOLL parameter Olivier Langlois
2021-06-22 20:58 ` Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9d9527c-6d2e-b840-15dd-057618de7864@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olivier@trillion01.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.