From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Burakov, Anatoly" Subject: Re: [PATCH v2] mem: store memory mode flags in shared config Date: Thu, 4 Oct 2018 10:17:01 +0100 Message-ID: References: <98f283ce5bcf8973c5c08d13f4fbfe375ded6ebf.1535368896.git.anatoly.burakov@intel.com> <102589449.7KdqRJ0jb8@xps> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, John McNamara , Marko Kovacevic To: Thomas Monjalon Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id DEA2D1B108 for ; Thu, 4 Oct 2018 11:17:06 +0200 (CEST) In-Reply-To: <102589449.7KdqRJ0jb8@xps> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 03-Oct-18 11:05 PM, Thomas Monjalon wrote: > 20/09/2018 17:41, Anatoly Burakov: >> Currently, command-line switches for legacy mem mode or single-file >> segments mode are only stored in internal config. This leads to a >> situation where these flags have to always match between primary >> and secondary, which is bad for usability. >> >> Fix this by storing these flags in the shared config as well, so >> that secondary process can know if the primary was launched in >> single-file segments or legacy mem mode. >> >> This bumps the EAL ABI, however there's an EAL deprecation notice >> already in place[1] for a different feature, so that's OK. >> >> [1] http://patches.dpdk.org/patch/43502/ >> >> Signed-off-by: Anatoly Burakov >> --- >> >> Notes: >> v2: >> - Added documentation on ABI break >> >> doc/guides/rel_notes/rel_description.rst | 5 +++++ > > Removed change in this file (dup of release note). > >> doc/guides/rel_notes/release_18_11.rst | 6 +++++- >> .../common/include/rte_eal_memconfig.h | 4 ++++ >> lib/librte_eal/linuxapp/eal/Makefile | 2 +- >> lib/librte_eal/linuxapp/eal/eal.c | 20 +++++++++++++++++++ >> lib/librte_eal/meson.build | 2 +- >> 6 files changed, 36 insertions(+), 3 deletions(-) > > Applied (without extra note), thanks. > This will probably break external mem patches due to conflict in release notes. Should i respin? -- Thanks, Anatoly