From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE1C5C4338F for ; Tue, 17 Aug 2021 07:46:41 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4B3D460F41 for ; Tue, 17 Aug 2021 07:46:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4B3D460F41 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8591E82BEC; Tue, 17 Aug 2021 09:46:37 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1629186397; bh=A1ITph1TfDroYq65sdAMVjqUIDtW2y78PCZmLzIInnQ=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=p7f5XPaiikOFbD9K5f/Ji+8fAOemPujjHI0Rwd960HB3kwFIc7yRG/YfW+oTYUF3P 2kaQ6/lTQ1qtydjq6JShrnpm8v47xa2tpGk6Fn5OiCpSf3/OEDiYUEOYpwAivNcxtK aV7mFGCY1li9oYcJMVBJb2IVxRobRmVNjzEty8y2BgVx/YAvoxmtiw+8Lem+i4G7i0 9RcUmcIPlkOibYfchYNZrbVLLNoLv68yzaWb/AIWsQnJPQzKJLUA7rVqIEwBqNNnBP m8IVCgvvp0518i5bsvXAWdBw95LnyIJApDq7VTxAVp2UObapgu4SpS9ixCWAAudoFF 0g5LYZARYxx6g== Received: by phobos.denx.de (Postfix, from userid 109) id 0FEBA8297D; Tue, 17 Aug 2021 09:46:33 +0200 (CEST) Received: from mout-u-204.mailbox.org (mout-u-204.mailbox.org [IPv6:2001:67c:2050:1::465:204]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0AE7F81BC8 for ; Tue, 17 Aug 2021 09:46:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:105:465:1:2:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-204.mailbox.org (Postfix) with ESMTPS id 4GpjlS5W0dzQjx3; Tue, 17 Aug 2021 09:46:28 +0200 (CEST) Received: from smtp2.mailbox.org ([80.241.60.241]) by spamfilter04.heinlein-hosting.de (spamfilter04.heinlein-hosting.de [80.241.56.122]) (amavisd-new, port 10030) with ESMTP id yQNY_Hzu3MPl; Tue, 17 Aug 2021 09:46:26 +0200 (CEST) Subject: Re: [PATCH u-boot-mvebu v2 2/4] arm: mvebu: turris_omnia: don't guard by CONFIG_SPL_BUILD macro To: =?UTF-8?Q?Marek_Beh=c3=ban?= Cc: u-boot@lists.denx.de, pali@kernel.org References: <20210816131940.24206-1-marek.behun@nic.cz> <20210816131940.24206-3-marek.behun@nic.cz> From: Stefan Roese Message-ID: Date: Tue, 17 Aug 2021 09:46:25 +0200 MIME-Version: 1.0 In-Reply-To: <20210816131940.24206-3-marek.behun@nic.cz> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-DE Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: EF33B183A X-Rspamd-UID: 3b7669 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 16.08.21 15:19, Marek Behún wrote: > We do not need to guard code in board_init() and board_late_init() > functions with the CONFIG_SPL_BUILD macro, since these functions are not > called in SPL. > > Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan > --- > board/CZ.NIC/turris_omnia/turris_omnia.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/board/CZ.NIC/turris_omnia/turris_omnia.c b/board/CZ.NIC/turris_omnia/turris_omnia.c > index a7e5f56eed..a84a409f43 100644 > --- a/board/CZ.NIC/turris_omnia/turris_omnia.c > +++ b/board/CZ.NIC/turris_omnia/turris_omnia.c > @@ -129,7 +129,6 @@ static int omnia_mcu_read(u8 cmd, void *buf, int len) > return dm_i2c_read(chip, cmd, buf, len); > } > > -#ifndef CONFIG_SPL_BUILD > static int omnia_mcu_write(u8 cmd, const void *buf, int len) > { > struct udevice *chip; > @@ -158,7 +157,6 @@ static bool disable_mcu_watchdog(void) > > return true; > } > -#endif > > static bool omnia_detect_sata(void) > { > @@ -325,7 +323,6 @@ struct mv_ddr_topology_map *mv_ddr_topology_map_get(void) > return &board_topology_map_1g; > } > > -#ifndef CONFIG_SPL_BUILD > static int set_regdomain(void) > { > struct omnia_eeprom oep; > @@ -394,7 +391,6 @@ static void handle_reset_button(void) > } > } > } > -#endif > > int board_early_init_f(void) > { > @@ -428,19 +424,15 @@ int board_init(void) > /* address of boot parameters */ > gd->bd->bi_boot_params = mvebu_sdram_bar(0) + 0x100; > > -#ifndef CONFIG_SPL_BUILD > disable_mcu_watchdog(); > -#endif > > return 0; > } > > int board_late_init(void) > { > -#ifndef CONFIG_SPL_BUILD > set_regdomain(); > handle_reset_button(); > -#endif > pci_init(); > > return 0; > Viele Grüße, Stefan -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de