From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85C71C433EF for ; Wed, 16 Feb 2022 07:35:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230139AbiBPHfV (ORCPT ); Wed, 16 Feb 2022 02:35:21 -0500 Received: from gmail-smtp-in.l.google.com ([23.128.96.19]:36472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230030AbiBPHfU (ORCPT ); Wed, 16 Feb 2022 02:35:20 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 481DE17185C; Tue, 15 Feb 2022 23:35:08 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3D0651F37D; Wed, 16 Feb 2022 06:39:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1644993565; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7GGMtEIGANtAaJZgWgs4fHi8bEqaZzSeIEHxY3YZQSM=; b=m54ylZrQ963wIR6zi/BQOguiJ0LS7VKESk6EZVzEEtdNitM7NhSeOR6d8YfWns9fyd+rKO JQf8TMGuCoyo6S5CNhgOtJi4Pr7kJ2boPw9pJnDQjgv+PrGMTZgLqzMGym7//FPLFmH3hz GMdFeegXjZsFRhDkJm5JwTpI0ta8AIE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1644993565; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7GGMtEIGANtAaJZgWgs4fHi8bEqaZzSeIEHxY3YZQSM=; b=i5cHX04eaVceesCbkAEE3R3DVeOG/2Qc1y6CzyyOpK21iDbNYaNV813kGh1GjuqRkR6YDM AcIAcFu6O9glNJBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0673213A1A; Wed, 16 Feb 2022 06:39:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id hQkqAB2cDGLUIwAAMHmgww (envelope-from ); Wed, 16 Feb 2022 06:39:24 +0000 Message-ID: Date: Wed, 16 Feb 2022 07:39:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [RFC PATCH] nvme: prevent hang on surprise removal of NVMe disk Content-Language: en-US To: Christoph Hellwig , =?UTF-8?Q?Markus_Bl=c3=b6chl?= Cc: Keith Busch , Jens Axboe , Sagi Grimberg , linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Roese References: <20220214095107.3t5en5a3tosaeoo6@ipetronik.com> <20220215191731.GB25076@lst.de> From: Hannes Reinecke In-Reply-To: <20220215191731.GB25076@lst.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 2/15/22 20:17, Christoph Hellwig wrote: > On Mon, Feb 14, 2022 at 10:51:07AM +0100, Markus Blöchl wrote: >> After the surprise removal of a mounted NVMe disk the pciehp task >> reliably hangs forever with a trace similar to this one: > > Do you have a specific reproducer? At least with doing a > > echo 1 > /sys/.../remove > > while running fsx on a file system I can't actually reproduce it. You should be able to reproduce it doing a PCI hotplug from qemu. Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer