From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F77AC3F2C6 for ; Tue, 3 Mar 2020 14:08:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D6F9A2073D for ; Tue, 3 Mar 2020 14:08:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729507AbgCCOI5 (ORCPT ); Tue, 3 Mar 2020 09:08:57 -0500 Received: from s3.sipsolutions.net ([144.76.43.62]:55824 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729494AbgCCOI4 (ORCPT ); Tue, 3 Mar 2020 09:08:56 -0500 Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.93) (envelope-from ) id 1j98E9-00CswX-W6; Tue, 03 Mar 2020 15:08:54 +0100 Message-ID: Subject: Re: Any reason AID is not in the NL80211_STA_INFO enumeration? From: Johannes Berg To: Ben Greear , "linux-wireless@vger.kernel.org" Date: Tue, 03 Mar 2020 15:08:51 +0100 In-Reply-To: <29006a9e-4de2-1733-1a8a-a5aae686fd42@candelatech.com> References: <5E4B39B2.8050905@candelatech.com> <3fcaaf0ba9ed726c863f9f1e7c5d61c08ca40795.camel@sipsolutions.net> <29006a9e-4de2-1733-1a8a-a5aae686fd42@candelatech.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 (3.34.2-1.fc31) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Fri, 2020-02-28 at 07:26 -0800, Ben Greear wrote: > > On 02/28/2020 02:06 AM, Johannes Berg wrote: > > On Mon, 2020-02-17 at 17:11 -0800, Ben Greear wrote: > > > To sniff /AX stations, it is helpful to know their AID. So, any problems > > > with adding it to 'iw station dump' output? > > > > No, no problem at all. I guess it was just never added because it > > originally comes from userspace (hostapd), and so didn't really need to > > be sent back. But yeah, we have trivial infrastructure to send it back, > > so sure, why not. > > Ok, thanks for the response. > > From looking at debugfs for a station device, there is the netdev AID: > > cat /debug/ieee80211/wiphy0/netdev\:wlan0/aid > 1 > > And there is a peer AID: > > cat /debug/ieee80211/wiphy0/netdev\:wlan0/stations/04\:f0\:21\:c2\:fd\:b0/aid > 0 > > For sniffing AX, I'd need to use '1' here as far as I can tell. Maybe for station > devices the peer is always zero? And for AP devices, the peer IDs are what is useful > and the netdev AID is not? Yeah. The first is u.mgd.aid (i.e. the netdev data), and the latter is the STA AID. It makes sense the latter is not assigned in the client-side case. Arguably, only the *latter* should be in nl80211 per STA, since in the client-side case it's *our* AID, not the APs. johannes