All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Garry <john.garry@huawei.com>
To: <jejb@linux.ibm.com>, <martin.petersen@oracle.com>
Cc: <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<hch@lst.de>, <ming.lei@redhat.com>, <bvanassche@acm.org>
Subject: Re: [PATCH] scsi: core: Refine how we set tag_set NUMA node
Date: Tue, 22 Mar 2022 15:53:47 +0000	[thread overview]
Message-ID: <da17474f-205c-1b08-f12c-52cd87a8379a@huawei.com> (raw)
In-Reply-To: <1647939438-187933-1-git-send-email-john.garry@huawei.com>

On 22/03/2022 08:57, John Garry wrote:
>   	/*
>   	 * Increase usage count temporarily here so that calling
>   	 * scsi_autopm_put_host() will trigger runtime idle if there is
> diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
> index 0a70aa763a96..7faa83b89fa4 100644
> --- a/drivers/scsi/scsi_lib.c
> +++ b/drivers/scsi/scsi_lib.c
> @@ -1982,7 +1982,11 @@ int scsi_mq_setup_tags(struct Scsi_Host *shost)
>   	tag_set->nr_maps = shost->nr_maps ? : 1;
>   	tag_set->queue_depth = shost->can_queue;
>   	tag_set->cmd_size = cmd_size;
> +	#ifdef CONFIG_NUMA
> +	tag_set->numa_node = shost->dma_dev->numa_node;
> +	#else
>   	tag_set->numa_node = NUMA_NO_NODE;
> +	#endif

note to self: use dev_to_node()

>   	tag_set->flags = BLK_MQ_F_SHOULD_MERGE;
>   	tag_set->flags |=


      reply	other threads:[~2022-03-22 15:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-22  8:57 [PATCH] scsi: core: Refine how we set tag_set NUMA node John Garry
2022-03-22 15:53 ` John Garry [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=da17474f-205c-1b08-f12c-52cd87a8379a@huawei.com \
    --to=john.garry@huawei.com \
    --cc=bvanassche@acm.org \
    --cc=hch@lst.de \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=ming.lei@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.