From: Adrian Hunter <adrian.hunter@intel.com>
To: Kiwoong Kim <kwmad.kim@samsung.com>
Cc: alim.akhtar@samsung.com, asutoshd@codeaurora.org,
avri.altman@wdc.com, bvanassche@acm.org, cang@codeaurora.org,
huobean@gmail.com, jejb@linux.ibm.com,
linux-scsi@vger.kernel.org, liwei213@huawei.com,
manivannan.sadhasivam@linaro.org, martin.petersen@oracle.com
Subject: Re: [PATCH V5 1/3] scsi: ufs: Fix error handler clear ua deadlock
Date: Thu, 30 Sep 2021 15:43:54 +0300 [thread overview]
Message-ID: <da246d0c-0c9f-4271-3351-fa8c01c26ff7@intel.com> (raw)
In-Reply-To: <1632891691-17109-1-git-send-email-kwmad.kim@samsung.com>
On 29/09/2021 08:01, Kiwoong Kim wrote:
> (I post this again because this isn't attached to the mail thread)
>
> UFSHCI specifies Data Byte Count (DBC) like this:
> A '0' based value that indicates the length, in bytes, of the data
> block. A maximum of length of 256KB may exist for any entry. Bits 1:0 of this
> field shall be 11b to indicate Dword granularity.
> A value of '3' indicates 4 bytes, '7' indicates 8 bytes, etc.
>
> That means the size value should be aligned with 4. And as I know it's 18.
> Yes, its buffer is enough but if a host doesn't access memory with four-byte
> alignment, it could cause problems.
Fixed in V6
next prev parent reply other threads:[~2021-09-30 12:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 9:38 [PATCH V5 0/3] scsi: ufs: Let devices remain runtime suspended during system suspend Adrian Hunter
2021-09-22 9:38 ` [PATCH V5 1/3] scsi: ufs: Fix error handler clear ua deadlock Adrian Hunter
[not found] ` <CGME20210928071133epcas2p28e00e20bbebbb5c1920933204f91743b@epcas2p2.samsung.com>
2021-09-28 6:55 ` Kiwoong Kim
2021-09-30 12:44 ` Adrian Hunter
[not found] ` <CGME20210929051745epcas2p1024eb171d57dca361d2d3d522683770d@epcas2p1.samsung.com>
2021-09-29 5:01 ` Kiwoong Kim
2021-09-30 12:43 ` Adrian Hunter [this message]
2021-09-22 9:38 ` [PATCH V5 2/3] scsi: ufs: Fix runtime PM dependencies getting broken Adrian Hunter
2021-09-22 9:38 ` [PATCH V5 3/3] scsi: ufs: Let devices remain runtime suspended during system suspend Adrian Hunter
2021-09-22 16:15 ` Asutosh Das (asd)
[not found] <CGME20210928064756epcas2p3975b89e0cecd0ca1807b354bafadccd3@epcas2p3.samsung.com>
2021-09-28 6:47 ` [PATCH V5 1/3] scsi: ufs: Fix error handler clear ua deadlock Kiwoong Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da246d0c-0c9f-4271-3351-fa8c01c26ff7@intel.com \
--to=adrian.hunter@intel.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=huobean@gmail.com \
--cc=jejb@linux.ibm.com \
--cc=kwmad.kim@samsung.com \
--cc=linux-scsi@vger.kernel.org \
--cc=liwei213@huawei.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.