From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B25ADC433ED for ; Mon, 10 May 2021 17:02:25 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 66FDA613CA for ; Mon, 10 May 2021 17:02:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 66FDA613CA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.125381.236009 (Exim 4.92) (envelope-from ) id 1lg9IO-0007gU-DE; Mon, 10 May 2021 17:02:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 125381.236009; Mon, 10 May 2021 17:02:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lg9IO-0007gN-9u; Mon, 10 May 2021 17:02:16 +0000 Received: by outflank-mailman (input) for mailman id 125381; Mon, 10 May 2021 17:02:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lg9IM-0007gH-HU for xen-devel@lists.xenproject.org; Mon, 10 May 2021 17:02:14 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lg9IL-0001fK-BG; Mon, 10 May 2021 17:02:13 +0000 Received: from [54.239.6.185] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lg9IL-0006TC-5A; Mon, 10 May 2021 17:02:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=5pPQci01U6lj1DP+RAW/PtTaJRGE5cGiknh2ABOcd5U=; b=jvPAeqIPrOps6YsG6XdDXWYBI+ 0PEYxOw4yjS7iDTdY61wyblaweHJ+N/XkFHCpxTGT7Ed8bp1OSaG/4nO+fLCKbS51FyKELxySVINE PGlNuE/NPwFG766FGC7zG61Eb2YobxWq0lWe0ijue0TAjekgEiSWk8TsJAX4wSKEmWYc=; Subject: Re: [PATCH v3 02/10] arm/domain: Get rid of READ/WRITE_SYSREG32 To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Volodymyr Babchuk , bertrand.marquis@arm.com, wei.chen@arm.com References: <20210505074308.11016-1-michal.orzel@arm.com> <20210505074308.11016-3-michal.orzel@arm.com> <795c63a5-76fc-0de4-d3be-ac3b9d90fa58@arm.com> From: Julien Grall Message-ID: Date: Mon, 10 May 2021 18:02:11 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <795c63a5-76fc-0de4-d3be-ac3b9d90fa58@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 06/05/2021 07:13, Michal Orzel wrote: > Hi Julien, Hi Michal, > On 05.05.2021 20:03, Julien Grall wrote: >> Hi Michal, >> >> On 05/05/2021 08:43, Michal Orzel wrote: >>> AArch64 registers are 64bit whereas AArch32 registers >>> are 32bit or 64bit. MSR/MRS are expecting 64bit values thus >>> we should get rid of helpers READ/WRITE_SYSREG32 >>> in favour of using READ/WRITE_SYSREG. >>> We should also use register_t type when reading sysregs >>> which can correspond to uint64_t or uint32_t. >>> Even though many AArch64 registers have upper 32bit reserved >>> it does not mean that they can't be widen in the future. >>> >>> Modify type of register cntkctl to register_t. >>> >>> Modify accesses to thumbee registers to use READ/WRITE_SYSREG. >>> Thumbee registers are only usable by a 32bit domain and in fact >>> should be only accessed on ARMv7 as they were retrospectively dropped >>> on ARMv8. >> >> Sorry for not replying on v2. How about: >> >> " >> Thumbee registers are only usable by a 32-bit domain and therefore we can just store the bottom 32-bit (IOW there is no type change). In fact, this could technically be restricted to Armv7 HW (the support was dropped retrospectively in Armv8) but leave it as-is for now. >> " >> >> If you are happy with it, I will do it on commit. >> > I am happy with it. Please ack and change it on commit. Thanks. Reviewed-by: Julien Grall Cheers, -- Julien Grall