From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751185AbdE2MI0 (ORCPT ); Mon, 29 May 2017 08:08:26 -0400 Received: from mx2.suse.de ([195.135.220.15]:46941 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750989AbdE2MIZ (ORCPT ); Mon, 29 May 2017 08:08:25 -0400 Subject: Re: [PATCH 3/3] mm, memory_hotplug: move movable_node to the hotplug proper To: Michal Hocko , Andrew Morton Cc: linux-mm@kvack.org, Mel Gorman , Andrea Arcangeli , Jerome Glisse , Reza Arbab , Yasuaki Ishimatsu , qiuxishi@huawei.com, Kani Toshimitsu , slaoub@gmail.com, Joonsoo Kim , Andi Kleen , David Rientjes , Daniel Kiper , Igor Mammedov , Vitaly Kuznetsov , LKML , Michal Hocko References: <20170529114141.536-1-mhocko@kernel.org> <20170529114141.536-4-mhocko@kernel.org> From: Vlastimil Babka Message-ID: Date: Mon, 29 May 2017 14:08:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170529114141.536-4-mhocko@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/29/2017 01:41 PM, Michal Hocko wrote: > From: Michal Hocko > > movable_node_is_enabled is defined in memblock proper while it > is initialized from the memory hotplug proper. This is quite messy > and it makes a dependency between the two so move movable_node along > with the helper functions to memory_hotplug. > > To make it more entertaining the kernel parameter is ignored unless > CONFIG_HAVE_MEMBLOCK_NODE_MAP=y because we do not have the node > information for each memblock otherwise. So let's warn when the option > is disabled. > > Acked-by: Vlastimil Babka > Signed-off-by: Michal Hocko Acked-by: Vlastimil Babka From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f70.google.com (mail-wm0-f70.google.com [74.125.82.70]) by kanga.kvack.org (Postfix) with ESMTP id 76C156B02B4 for ; Mon, 29 May 2017 08:08:25 -0400 (EDT) Received: by mail-wm0-f70.google.com with SMTP id 139so13089340wmf.5 for ; Mon, 29 May 2017 05:08:25 -0700 (PDT) Received: from mx1.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id u19si9875101edi.214.2017.05.29.05.08.24 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 29 May 2017 05:08:24 -0700 (PDT) Subject: Re: [PATCH 3/3] mm, memory_hotplug: move movable_node to the hotplug proper References: <20170529114141.536-1-mhocko@kernel.org> <20170529114141.536-4-mhocko@kernel.org> From: Vlastimil Babka Message-ID: Date: Mon, 29 May 2017 14:08:19 +0200 MIME-Version: 1.0 In-Reply-To: <20170529114141.536-4-mhocko@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko , Andrew Morton Cc: linux-mm@kvack.org, Mel Gorman , Andrea Arcangeli , Jerome Glisse , Reza Arbab , Yasuaki Ishimatsu , qiuxishi@huawei.com, Kani Toshimitsu , slaoub@gmail.com, Joonsoo Kim , Andi Kleen , David Rientjes , Daniel Kiper , Igor Mammedov , Vitaly Kuznetsov , LKML , Michal Hocko On 05/29/2017 01:41 PM, Michal Hocko wrote: > From: Michal Hocko > > movable_node_is_enabled is defined in memblock proper while it > is initialized from the memory hotplug proper. This is quite messy > and it makes a dependency between the two so move movable_node along > with the helper functions to memory_hotplug. > > To make it more entertaining the kernel parameter is ignored unless > CONFIG_HAVE_MEMBLOCK_NODE_MAP=y because we do not have the node > information for each memblock otherwise. So let's warn when the option > is disabled. > > Acked-by: Vlastimil Babka > Signed-off-by: Michal Hocko Acked-by: Vlastimil Babka -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org