From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751468AbdLAIWZ (ORCPT ); Fri, 1 Dec 2017 03:22:25 -0500 Received: from fllnx209.ext.ti.com ([198.47.19.16]:11599 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750988AbdLAIWX (ORCPT ); Fri, 1 Dec 2017 03:22:23 -0500 Subject: Re: [PATCH v3 1/4] omapdrm: panel: fix compatible vendor string for td028ttec1 To: Rob Herring , "H. Nikolaus Schaller" CC: Thierry Reding , David Airlie , Mark Rutland , =?UTF-8?Q?Beno=c3=aet_Cousson?= , Tony Lindgren , Russell King , Bartlomiej Zolnierkiewicz , Laurent Pinchart , Julia Lawall , Sean Paul , , , , , , , , References: <6ae8f4b7d794c536650cc99025e5b026089cea30.1511884135.git.hns@goldelico.com> <20171201015730.nvw6sblxn566dhhb@rob-hp-laptop> From: Tomi Valkeinen Message-ID: Date: Fri, 1 Dec 2017 10:18:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171201015730.nvw6sblxn566dhhb@rob-hp-laptop> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/12/17 03:57, Rob Herring wrote: >> diff --git a/drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c b/drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c >> index 0a38a0e8c925..a0dfa14f4fab 100644 >> --- a/drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c >> +++ b/drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c >> @@ -452,6 +452,8 @@ static int td028ttec1_panel_remove(struct spi_device *spi) >> } >> >> static const struct of_device_id td028ttec1_of_match[] = { >> + { .compatible = "omapdss,tpo,td028ttec1", }, > > Why the omapdss part? This driver is omapdrm specific. But I don't want the dts file to have omapdrm specific compatible strings, so that the dts files do not have to be changed when in the future we move to common DRM panel drivers So: - In the .dts, we have compatible = "tpo,td028ttec1" - At early boot time, we append "omapdss," to compatible strings for panels connected to the DSS node. - The omapdrm specific drivers match to "omapdss,tpo,td028ttec1" Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH v3 1/4] omapdrm: panel: fix compatible vendor string for td028ttec1 Date: Fri, 1 Dec 2017 10:18:18 +0200 Message-ID: References: <6ae8f4b7d794c536650cc99025e5b026089cea30.1511884135.git.hns@goldelico.com> <20171201015730.nvw6sblxn566dhhb@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20171201015730.nvw6sblxn566dhhb@rob-hp-laptop> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Rob Herring , "H. Nikolaus Schaller" Cc: Mark Rutland , devicetree@vger.kernel.org, Julia Lawall , letux-kernel@openphoenux.org, Bartlomiej Zolnierkiewicz , David Airlie , Russell King , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Tony Lindgren , linux-fbdev@vger.kernel.org, Thierry Reding , Sean Paul , Laurent Pinchart , =?UTF-8?Q?Beno=c3=aet_Cousson?= , kernel@pyra-handheld.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On 01/12/17 03:57, Rob Herring wrote: >> diff --git a/drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c b/drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c >> index 0a38a0e8c925..a0dfa14f4fab 100644 >> --- a/drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c >> +++ b/drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c >> @@ -452,6 +452,8 @@ static int td028ttec1_panel_remove(struct spi_device *spi) >> } >> >> static const struct of_device_id td028ttec1_of_match[] = { >> + { .compatible = "omapdss,tpo,td028ttec1", }, > > Why the omapdss part? This driver is omapdrm specific. But I don't want the dts file to have omapdrm specific compatible strings, so that the dts files do not have to be changed when in the future we move to common DRM panel drivers So: - In the .dts, we have compatible = "tpo,td028ttec1" - At early boot time, we append "omapdss," to compatible strings for panels connected to the DSS node. - The omapdrm specific drivers match to "omapdss,tpo,td028ttec1" Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Date: Fri, 01 Dec 2017 08:18:18 +0000 Subject: Re: [PATCH v3 1/4] omapdrm: panel: fix compatible vendor string for td028ttec1 Message-Id: List-Id: References: <6ae8f4b7d794c536650cc99025e5b026089cea30.1511884135.git.hns@goldelico.com> <20171201015730.nvw6sblxn566dhhb@rob-hp-laptop> In-Reply-To: <20171201015730.nvw6sblxn566dhhb@rob-hp-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Rob Herring , "H. Nikolaus Schaller" Cc: Mark Rutland , devicetree@vger.kernel.org, Julia Lawall , letux-kernel@openphoenux.org, Bartlomiej Zolnierkiewicz , David Airlie , Russell King , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Tony Lindgren , linux-fbdev@vger.kernel.org, Thierry Reding , Sean Paul , Laurent Pinchart , =?UTF-8?Q?Beno=c3=aet_Cousson?= , kernel@pyra-handheld.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org On 01/12/17 03:57, Rob Herring wrote: >> diff --git a/drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c b/drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c >> index 0a38a0e8c925..a0dfa14f4fab 100644 >> --- a/drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c >> +++ b/drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c >> @@ -452,6 +452,8 @@ static int td028ttec1_panel_remove(struct spi_device *spi) >> } >> >> static const struct of_device_id td028ttec1_of_match[] = { >> + { .compatible = "omapdss,tpo,td028ttec1", }, > > Why the omapdss part? This driver is omapdrm specific. But I don't want the dts file to have omapdrm specific compatible strings, so that the dts files do not have to be changed when in the future we move to common DRM panel drivers So: - In the .dts, we have compatible = "tpo,td028ttec1" - At early boot time, we append "omapdss," to compatible strings for panels connected to the DSS node. - The omapdrm specific drivers match to "omapdss,tpo,td028ttec1" Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki From mboxrd@z Thu Jan 1 00:00:00 1970 From: tomi.valkeinen@ti.com (Tomi Valkeinen) Date: Fri, 1 Dec 2017 10:18:18 +0200 Subject: [PATCH v3 1/4] omapdrm: panel: fix compatible vendor string for td028ttec1 In-Reply-To: <20171201015730.nvw6sblxn566dhhb@rob-hp-laptop> References: <6ae8f4b7d794c536650cc99025e5b026089cea30.1511884135.git.hns@goldelico.com> <20171201015730.nvw6sblxn566dhhb@rob-hp-laptop> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 01/12/17 03:57, Rob Herring wrote: >> diff --git a/drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c b/drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c >> index 0a38a0e8c925..a0dfa14f4fab 100644 >> --- a/drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c >> +++ b/drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c >> @@ -452,6 +452,8 @@ static int td028ttec1_panel_remove(struct spi_device *spi) >> } >> >> static const struct of_device_id td028ttec1_of_match[] = { >> + { .compatible = "omapdss,tpo,td028ttec1", }, > > Why the omapdss part? This driver is omapdrm specific. But I don't want the dts file to have omapdrm specific compatible strings, so that the dts files do not have to be changed when in the future we move to common DRM panel drivers So: - In the .dts, we have compatible = "tpo,td028ttec1" - At early boot time, we append "omapdss," to compatible strings for panels connected to the DSS node. - The omapdrm specific drivers match to "omapdss,tpo,td028ttec1" Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki