From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE0E5C433EF for ; Thu, 2 Jun 2022 14:53:27 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3011140691; Thu, 2 Jun 2022 16:53:27 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 006344021E for ; Thu, 2 Jun 2022 16:53:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654181606; x=1685717606; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=ZEKgkAw8YbT+C69EvpDrVlmkv+b7Wk9qhAmeXG1Bjas=; b=k7dMLvhiLaEfu9u5jqLhGKElOFTABkFCHgqCs3nU9T/O9e5tpgl3G5sc 51JxAa5W77TDF4ljkJfXduFeoiAtynVReJlziyTASp+ZfEiyyJSuBuGHa TblE5gnHcN/HZ4IPFFNjglSo1vCb0Wf0RI9LWexS5tKq955IIgrF7yx4x wI57HFXRhVy3i92Z/SEP+WbC4zzelJOsiQNv5Xcaj4xR5SC4YO/A8eSOM mFm8F8rPPfONpA/FnayVY5L3jeSsH5zZf325Ra+zAzpmalVoSrrc2d445 9HVtZ8xm3ArF3lrbxK6mCL0Ma2SZcv/DH6xHiguggeluTLJ++yLZz/NMb Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10365"; a="339015523" X-IronPort-AV: E=Sophos;i="5.91,271,1647327600"; d="scan'208";a="339015523" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jun 2022 07:53:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,271,1647327600"; d="scan'208";a="530602643" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga003.jf.intel.com with ESMTP; 02 Jun 2022 07:53:25 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 2 Jun 2022 07:53:24 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 2 Jun 2022 07:53:24 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 2 Jun 2022 07:53:24 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.175) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 2 Jun 2022 07:53:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XKREorGBfZGoOFEyDGPocxVLxyJ3+78bvZmsrzjsNi7+2XKol4qhsqh/EYBTJvnyXsOWn3R6GjbkhG6sjFNjTXapRGC7dVH+uUipFFU3jjPlh4X1f6LofnGu39lS6LtpMMcWmWV143LseUYlnEMdhQFHyACEhbnTjXXlAIR0hjlXVcCZPXTZdf3REL72ux/SYgcg+uBdyoNbjSlzVmAwG0hRznki4t4wWahK6zP38zbkPcU6N1BeSYQx2BzT5ntTh+K32slZF7+KfUZot4K0b644kSwyRMPwKt+Eam8h187scYRrmU6Iaq8KRYS0FCd0F1GRSReE3l7vOFZfcErtEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tngOxwdYlapPxzc1ghFvQG38Q6evKdfuESU8doxrhGU=; b=W3rU6Ec7LtG02BpvdMUTxFKIcW3bQbUGiekVxjNHN6X1XkQugAi1OfCdQmiEdGKjUGMH8Xp70SWo2mXRvQyZIkAW0HrjlGzsx5rKgt0ZwufytiChZiy8gb42bG/2TJ7Kc/ycrJsfc0jYfOkrH7lKsJaADCSA38xvU00yN6B5cLRMPbVr7KWBa+cEfYhpl6sF7C3888k9mupcqGIc+m1cxVrH7gHYziKiDyIRy6D2ReWHemkGjRuVcjELbKzgcR4E72kFAurxyeGjedP6lxiBB5fzh3NhQS4iEW2mqFiSeldBtg6SSqV6KN2RELvEhaQYnAfdUBJ5nBDTcPf6oDXDYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by DM6PR11MB3388.namprd11.prod.outlook.com (2603:10b6:5:5f::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.16; Thu, 2 Jun 2022 14:53:20 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::382e:55b8:41a6:6eff]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::382e:55b8:41a6:6eff%6]) with mapi id 15.20.5314.012; Thu, 2 Jun 2022 14:53:20 +0000 Message-ID: Date: Thu, 2 Jun 2022 15:53:15 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v5 2/4] lib/power: add get and set API for pause duration To: "Burakov, Anatoly" , CC: Ray Kinsella , David Hunt References: <20220408140847.1319312-1-kevin.laatz@intel.com> <20220531095936.1965727-1-kevin.laatz@intel.com> <20220531095936.1965727-3-kevin.laatz@intel.com> <09b1a2bc-1593-063b-9b7f-ee1019214365@intel.com> From: Kevin Laatz In-Reply-To: <09b1a2bc-1593-063b-9b7f-ee1019214365@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P123CA0090.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:138::23) To MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4be4708e-777f-4578-a267-08da44a7a2a1 X-MS-TrafficTypeDiagnostic: DM6PR11MB3388:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: s1oyjoCL6Dm2VyzllxF6d82RhesXN5lhPKkf6rxg3aWbm/DUa1MV70ECKqWMDWAr8Opzt7XTRTy/Q1T8wgthsYGqI8Y7QGASQdcq09mV/NQC7BXlwX7+fCN4+MyRj2+9LwgAAneHGQtbpFemQWf0RylV+qH3/GqX2C8PlXIKw910ZpP3eMYdIJrTwIlgSx3OJggnSCi2ejc6ilbg1aG8ney/3uq5Q7TWaeDctDhiboIulg0k3Z+hpMu7aRb9XdgfXMiDtriWB2ATdDmVfH0eeNF9UMbmNm6CYeimXf6I9n+bSKJfFYwvc3owhagOhkJEeIQ5pVWr2HtnX66bA45pEsrZU725NITbC4VqwFtM+amVwaVHGHKxuQ+qcaNF/HAVM+8+dlRvxtqpv+U+Qcn4TNEOVNi5AWNMNjUSjLgImsXotq7oYVebE1egJMqIWDkKj/2YxA+kW3mBHcBcP4c/qA7Lefkrr2KOjoNCMYLKFBb8hgoAPxiECcS23gOq04M0wTeGmN00O6sx6OJDyxK82b1xGVpe8tyL7u2MDc0N3e0UVOEPYtiHfMU5eN9xIBvOOG7eQ5LqgzcgAbqvZ6T3/OJCxV6wV9ZXMmZsc5UQxN9lSaDvZ0Dac30nZuhAHgFjTgSjhwxkr6qD4X6xzGktuLl6ZaEw9Zxyd6f7jmwG8MVnK8p4po1DN1z/NK33P55oZNLI85XVzouHTiXz8IXA16MN7Sp1SLuiVdTJxJ1HYuE= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW4PR11MB5872.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(38100700002)(316002)(31686004)(508600001)(8676002)(6486002)(36756003)(107886003)(2616005)(86362001)(186003)(54906003)(8936002)(31696002)(26005)(4326008)(83380400001)(5660300002)(6506007)(66556008)(6666004)(53546011)(66476007)(6512007)(44832011)(66946007)(2906002)(82960400001)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U3FLMW4yb0VLTEk0YXhkaUtqYURQdHVpK3JZbWc3eS92TmFsMXVzSllFZU14?= =?utf-8?B?aEVPMEd5cnMrelRFNWZ4MkI5OHVsVTB2dG0wQk4wd0dDZlk5aFg0NzdnNTJ0?= =?utf-8?B?bTBHL1ZkcWJ0cFhkbU1meU1hVVpxaGNFYjlsSitVVVdHOU9DUEh4SHM5L3k0?= =?utf-8?B?eFpYQWJ6Nkx4d0xCSXBaeWF2UDIyczhuNHl4alI5UkhpM0dLd2NnWHJFeEQz?= =?utf-8?B?QXhDa3hPQ091SnBQUkpQUHBhM1k2emFoM082UWdjdmhCY285OUxkVzZoejB5?= =?utf-8?B?SHpoaTJiZElVQUs3STc0MTNUanBBS2hybDVqQittbkNGbjV0NHcwRTdNSU9P?= =?utf-8?B?a1lIR0t3UVRsMlBqOVlBVUVPQ2wxVDd2SHljTDhHUWtvVFBvQlFXdnExV25L?= =?utf-8?B?UFdlVjUyKzVLdG1qMW5iWnN0WjN1RDJGcjk1R0F3WjF0OGpJTEEyS24wMnky?= =?utf-8?B?YkxGL21Kc3Z1TlVaMkVEdStuc2dMY3FGWHNuVzNDclNaUk5mcWZRNWNpcDdL?= =?utf-8?B?c0xCSkMyQ3Y5dU1tY3FmWmVLVEJGN3czWTJMN1VNb2VtTzRudW5JcXJWTzNj?= =?utf-8?B?UkkvWERuWXZ0Qms0T25RV1VPOGZWNTJGMEVqOUUxYTFFY1JkcjJVU28rR0cy?= =?utf-8?B?UWt3ZmZwTkh2dllTMzl0TlorbVcvand5U1Budi9Nbk0xZ1ZSQ3lERVdDSzBp?= =?utf-8?B?Q3ZVajFnUlNHME1zUlVnOWxqZkk3OWMxUTljVXBldWt6OWxoY0xMVEJFTm1C?= =?utf-8?B?YWdpbU02UmRUWHdQQnNKYlZCbnJ2a1p3WU1FOGtpNkRZYmtvT1hvRVl1Z3RO?= =?utf-8?B?UTVSRVo5ZnZoQTBYWXZMbzRlZFhrOVBYM0hqaGNvdU9EZWYvam03TlVkWElF?= =?utf-8?B?bVRaUEVzZ3JveUtlMmlCRFdVVnI1VlZ0NDEyQkZLbnVudmRYTjdCdUlicVJR?= =?utf-8?B?UFVXc1V4bkVQS2o3WFc2T0hwY3hEdVo4cTBTcnpxeWxBM2lPMU5ZSmNIK2NM?= =?utf-8?B?WERQbEc5QXJSSzdRNXNkNHQvRWIrNnNKVGVNTDFjNmxKZ2RqUHBpbTZBSzI1?= =?utf-8?B?QXpWZjdoWm1mTlNROXI3NTFxcS9DWXVYbE5yd2xHeC80YnpTYXlkZHhCclpu?= =?utf-8?B?ZFk5REVFUXh4ZWZtVFlJT01zUjVTT09weFRQbFJaNGNFR1czOVJ5SVhieDFk?= =?utf-8?B?V0VCK3B3Q1U5VXI2NTBVT0Zkb2xjd3Q1dEVWWExubE54QnN5MktHT3RQanhp?= =?utf-8?B?MDVodWxCdGZNRURPNGxEV0xhdjFKU0RSZllRSmZxTWZXemZXc3hOMEt6RGtD?= =?utf-8?B?cFFXaC9BdXRYb2h0RExLV29FVGxxazRkaFF2V3hDYkI4Qk1vR3kvcEJuc1Bv?= =?utf-8?B?WGs5NTF3M2Y2WldRcnR6NktrdnIwRy9WditpbHJBSkU0Rkk3UU1Fay93MVF2?= =?utf-8?B?aGlmZVN1cDlqdzQxc016Nm5pRitLcU1rQVFRZjIzUDlDNmxLSUN6NDZ5OFg5?= =?utf-8?B?YUQxOXZNMDNJaHQ1anJDY3BEQ3hNczl3bWdva25aTWR4RUFLOVVUS1RtOGFX?= =?utf-8?B?YVdNWXNVeENpYW9BV1hxd3FxR1F5L2NpNWFISEdsdnFDckxGR25JbXVKb2hN?= =?utf-8?B?Yi9Nb0FEUkJKU1k0OEdKaExGYWNsZ1EvQjVFQjNxbTYwM2VycURDRER2Q0ox?= =?utf-8?B?Tmw1TnlBakh5bWFKNktBeWJWM0pJQ2hQa1QxZTI5emd6cEN1QUpCaS9nL0o5?= =?utf-8?B?SFN6V0tWa0l4cTZ3ODArbVhjaVpRME1PZU94TUhBSlFDSW54Yy8wMGIyVGZL?= =?utf-8?B?N0hYV0tHbXpvZmxIT3o2UDBoR0syZFZnZTVRM2tyQ09Bcm1ybDE1bVBkRytN?= =?utf-8?B?OVEwUG9CcnRGZFBqWEhPYnB4WjQvTmVTdm5kS3Zlb2Y3M215THNTdmttTUJZ?= =?utf-8?B?Rjk4N1NZWmhyQlhWRFlRMVJHUDdEb01uS1QvWllhUEpDZkZ6TzFmSmQ4WGI2?= =?utf-8?B?VkxXMnpaS1Fabzdhd1F1R2NVSHNra2NiRlhuc3NPK0dSMjc3ZUVHZFl3aUc4?= =?utf-8?B?QStWN0tFN1VoQVo0cmhlc21oQk9nLzRyUWNtL0JVVmFLWlJKb1Urc0xJbEZs?= =?utf-8?B?cTdiMi9xaFJZQSszMTNSOEpseWZYbEpZM0x6WlY5OCs3OFdoWFQ5d3ladGtV?= =?utf-8?B?elhsOXBnUlJhcCtDR0tkWEw5dFdBYmdQQ292c2xQeTVUaE00NWhiRkxMV2Ra?= =?utf-8?B?M2pnRlhRdlRzb1p2Z3lTSzgwVzVCTjdnNlZHb2lRbHg5Rk9RdjJyREhtZmZD?= =?utf-8?B?azJPOGpxNm5CbG5CcVBBRnpBck5OSzBxMWM3Y3lTWitvdklGTTM3Uzdoazl5?= =?utf-8?Q?6zQqRGWuIgAj3uQw=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4be4708e-777f-4578-a267-08da44a7a2a1 X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jun 2022 14:53:20.7429 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ij5qKYusRG7eyqN9mcdFECmsDcqegwQXqspYw4r+JCRNlt4yOsg7JtULLfYWWnCCFq5ZeDjvUxXbXtbUzl7VDg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3388 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 02/06/2022 15:01, Burakov, Anatoly wrote: > On 31-May-22 10:59 AM, Kevin Laatz wrote: >> Add new get/set API for configuring 'pause_duration' which used to >> adjust >> the pause mode callback duration. >> >> Signed-off-by: Kevin Laatz >> Acked-by: Ray Kinsella >> Acked-by: Anatoly Burakov >> Tested-by: David Hunt >> >> --- >> v5: add doc entry for new API >> v3: changed printf to RTE_LOG >> --- >>   doc/guides/prog_guide/power_man.rst |  6 ++++++ >>   lib/power/rte_power_pmd_mgmt.c      | 25 +++++++++++++++++++++-- >>   lib/power/rte_power_pmd_mgmt.h      | 31 +++++++++++++++++++++++++++++ >>   lib/power/version.map               |  2 ++ >>   4 files changed, 62 insertions(+), 2 deletions(-) >> >> diff --git a/doc/guides/prog_guide/power_man.rst >> b/doc/guides/prog_guide/power_man.rst >> index 5d345f6eb9..f22513b324 100644 >> --- a/doc/guides/prog_guide/power_man.rst >> +++ b/doc/guides/prog_guide/power_man.rst >> @@ -258,6 +258,12 @@ API Overview for Ethernet PMD Power Management >>   * **Set Emptypoll Max**: Set the number of empty polls to wait >> before entering >>     sleep state. >>   +* **Get Pause Duration**: Get the configured duration (ms) to be >> used in the >> +  Pause callback. >> + >> +* **Set Pause Duration**: Set the duration of the pause (ms) used in >> the Pause >> +  mode callback. >> + > > Is it not microseconds rather than milliseconds? Yes, you're right - fix coming. Thanks /Kevin