From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E38AB68 for ; Sun, 31 Oct 2021 19:27:42 +0000 (UTC) Received: by mail-lj1-f181.google.com with SMTP id 188so26047433ljj.4 for ; Sun, 31 Oct 2021 12:27:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language :from:to:cc:references:in-reply-to:content-transfer-encoding; bh=V5/S9C66G0DHMWVujgT6AW2yL+Z8DSmr42TXOBZj6ZQ=; b=MyFkvskn4vvk4JibQW6Cjx0hLJfgjh/VZQkhxbXCj15B6SbCVM7Py0eDRG88HIYGRW I0AzWBqabAOFKmPgApTWYQYm7gP5fKowkZ1DGxRyw6Mib0MAB04oi77HDVMW79dtRPTq /Ai05P1rXjrLfjMPETFG8+D+sdowFZY8akZx/43xX6/gpxPILBZvjDVQuWTQSjAHLOEp xk0TaZrFEHKbMMEzq7yJ75h5e8OkxrRDVKgJiEsQU+Mj8DULLPVOX8cglRyp6IQJ6KiL zeDbOxo0Aya4ULrdU9LMdGq1tYtGY4kxDfCmryznZrEO2pL8FzEqrIGswms3UmlJ9Fjd Tmnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:references:in-reply-to :content-transfer-encoding; bh=V5/S9C66G0DHMWVujgT6AW2yL+Z8DSmr42TXOBZj6ZQ=; b=HqR3Ss9VQh2Tv7aHFduje0AgjPTiVkU8FCoEq4yqDlJc7rPD1XosqiU/eFVeKSGJE+ 6/f00utPSfCi32O5cV8u3tF4ggNlwrOAjprQmQtixS4AtlaDv2dMj1YKpeREUqygA5DI ja1wb+H8ZDQfGq2G6Gc6VkqDRD6clfYXqBUY7nHCU1a0sqs72mm4jHkbjFl2L+ICvN3S nZYeo/4nrMlU9l117XYKvcnTqKLbswoz4Z6Llot2MlZD7LfLydffclm+LadJti6TbNGK /aTo5FHn0krpxtsMO6rQgOyeG9uz1cnK1PNVetWW0SiUkfh0OFncmChP0B+AaG7Jn0Hd MB8w== X-Gm-Message-State: AOAM531bL2LcPrLS/Jct4wgBHp+zeRywl+D2WG8l0QR2Bz2+yki984QJ 083tuQAkbZLpDL1p8a2dtzc= X-Google-Smtp-Source: ABdhPJx8kLiOA1sPzX39skSfEGqMOIuSjglYfy7pcXL6yG7oPDCR9bhTxt1FbxFUVwJ+KFzLzBQikg== X-Received: by 2002:a05:651c:1549:: with SMTP id y9mr27220821ljp.327.1635708461105; Sun, 31 Oct 2021 12:27:41 -0700 (PDT) Received: from [192.168.1.11] ([94.103.235.8]) by smtp.gmail.com with ESMTPSA id x14sm552614lfr.110.2021.10.31.12.27.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 31 Oct 2021 12:27:40 -0700 (PDT) Message-ID: Date: Sun, 31 Oct 2021 22:27:40 +0300 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH] staging: r8188eu: os_dep: remove the goto statement Content-Language: en-US From: Pavel Skripkin To: Saurav Girepunje , Larry.Finger@lwfinger.net, phil@philpotter.co.uk, gregkh@linuxfoundation.org, straube.linux@gmail.com, martin@kaiser.cx, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: saurav.girepunje@hotmail.com References: <4c566e71-2426-b776-17a2-38f5f0b6f2b6@gmail.com> In-Reply-To: <4c566e71-2426-b776-17a2-38f5f0b6f2b6@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/31/21 22:24, Pavel Skripkin wrote: >> I think rtw_init_default_value should return void. It's return value is not useful. > > > Sure, but you need to firstly remove > `ret8 = rtw_init_default_value(padapter);` and then make it return bool ^^^^ I mean void, of course :) With regards, Pavel Skripkin