From: Martin Wilck <Martin.Wilck@suse.com>
To: "bmarzins@redhat.com" <bmarzins@redhat.com>
Cc: "dm-devel@redhat.com" <dm-devel@redhat.com>
Subject: Re: [PATCH 1/2] multipath.conf: add "enable_foreign" parameter
Date: Mon, 19 Aug 2019 20:32:37 +0000 [thread overview]
Message-ID: <da712bc269003e39dd35e8d7799992ff1d650c6a.camel@suse.com> (raw)
In-Reply-To: <20190816201218.GF25414@octiron.msp.redhat.com>
On Fri, 2019-08-16 at 15:12 -0500, Benjamin Marzinski wrote:
> On Thu, Aug 15, 2019 at 02:46:54PM +0000, Martin Wilck wrote:
> > From: Martin Wilck <mwilck@suse.com>
> >
> > This new configuration parameter can be used to selectively
> > enable foreign libraries. The value is a regular expression,
> > against which foreign library names such as "nvme" are matched.
> > By setting this to a value that matches no foreign library
> > (e.g. "^$" or "NONE"), foreign code is completely disabled.
> > By default, all available foreign libraries are loaded.
> >
>
> This will stop the foreign libraries from even claiming devices.
> Won't
> this mean that pathinfo() will now treat these devices as
> multipathable
> paths, since is_claimed_by_foreign() will return false?
IMO this won't happen, because we ignore the native multipath path
devices anyway as they're "hidden", and we ignore native NVMe multipath
maps because they have "nvme-subsystem" subsystem rather than "nvme"
(commit b18ed66). But I'll double-check again.
Martin
next prev parent reply other threads:[~2019-08-19 20:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 14:46 [PATCH 0/2] multipath-tools: Add option to disable NVMe ("foreign") support Martin Wilck
2019-08-15 14:46 ` [PATCH 1/2] multipath.conf: add "enable_foreign" parameter Martin Wilck
2019-08-16 20:12 ` Benjamin Marzinski
2019-08-19 20:32 ` Martin Wilck [this message]
2019-08-20 16:24 ` Martin Wilck
2019-08-20 19:24 ` Benjamin Marzinski
2019-08-15 14:46 ` [PATCH 2/2] multipath.conf.5: document foreign library support Martin Wilck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da712bc269003e39dd35e8d7799992ff1d650c6a.camel@suse.com \
--to=martin.wilck@suse.com \
--cc=bmarzins@redhat.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.