From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76845C433EF for ; Fri, 13 May 2022 09:07:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378862AbiEMJHP (ORCPT ); Fri, 13 May 2022 05:07:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53122 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378787AbiEMJHI (ORCPT ); Fri, 13 May 2022 05:07:08 -0400 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9ECB1B36CF for ; Fri, 13 May 2022 02:07:07 -0700 (PDT) Received: by mail-wr1-x42f.google.com with SMTP id u3so10567592wrg.3 for ; Fri, 13 May 2022 02:07:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=tQhMv5wgd6P5e5ZPKnJXTqhF5TWWKVPkk+00hnqjRXs=; b=l8ZqzODxTeK4g2pTFG9ZfVYndijHwk3ii/cTxtexptHo590e35fS20iJwufNZdEh92 2jnMvPNFHcft1cWJ2CbcRhtpHmMAmc8dJINengKkOOb5LUd5kbGum+qa3F+Uqhq9WxGl Y+4vNppopCVyTh/NMA/pHCUtSirsXcuUpHKpHmqmDSiZwaJhIZS9BkwROWE1xhfpXly0 vSZYHS/eCsuDxwTwx4exGV1Fcw0wIFsgGORQL+NhF0F+GT4P72xlIFvgV2ehYcMbmDo+ /yl0yWZV9wzV5KCbXL8PYSXGFZ+bnosYCEC8iFJe3AHNNRz4j1c+vziQGTi+0eTaY+OS xqFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=tQhMv5wgd6P5e5ZPKnJXTqhF5TWWKVPkk+00hnqjRXs=; b=EazZT4sfcTjjRujUuhHTXKAWja2bZB/uzFTA1i82s8faVjEII3RoE3/zdxpQStl48k zaN3VnKFrGQ7GIGZml7qGHrVWS3hZSyXJsY/kRqx6XLXntHEtzEXyH5jY9JxFhvXIuSI ts6NtntIZdL4aP67QyIGq4Bkebc5MP4WOuk+0LxFrkxG+Z7zxjaLGo8kEwh17+qDmHV8 vt2CH9aBCUfhCX/D+DYOJNreb+aAKZvWvAnJ18bUIL+MDcVQkVt9kHN2Vj7Jn6zauEzM Ya+/IN/2TVv5BhOYRFRNK5sTJBgv/yKwo6SrLfeiyp/tLeWIG6q/5JqwIvYw3zhFvsWD 4BXA== X-Gm-Message-State: AOAM530J6xDjrWadvmVtI3gD3C8KdI7/djLww+M8mqZzNGWyEwaLxMLM 5b3auA2fhU3nAmXz+6ktsCqAhA== X-Google-Smtp-Source: ABdhPJy98bvsVxNsD1pSSLGnY3/tw/4jQw9PX2RSQLFiZDfcJuBduq4HwVBFKrcSH9BcOE5sNaEWQA== X-Received: by 2002:a5d:4090:0:b0:20c:8b91:3b17 with SMTP id o16-20020a5d4090000000b0020c8b913b17mr2991905wrp.348.1652432826026; Fri, 13 May 2022 02:07:06 -0700 (PDT) Received: from [192.168.0.169] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id s23-20020adfa297000000b0020c5253d8f4sm1662710wra.64.2022.05.13.02.07.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 May 2022 02:07:05 -0700 (PDT) Message-ID: Date: Fri, 13 May 2022 11:07:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 3/3] dt-bindings: usb: add documentation for aspeed udc Content-Language: en-US To: Neal Liu , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Joel Stanley , Andrew Jeffery , Felipe Balbi , Sumit Semwal , =?UTF-8?Q?Christian_K=c3=b6nig?= , Geert Uytterhoeven , Li Yang Cc: linux-aspeed@lists.ozlabs.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, BMC-SW@aspeedtech.com References: <20220513065728.857722-1-neal_liu@aspeedtech.com> <20220513065728.857722-4-neal_liu@aspeedtech.com> From: Krzysztof Kozlowski In-Reply-To: <20220513065728.857722-4-neal_liu@aspeedtech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/05/2022 08:57, Neal Liu wrote: > Add device tree binding documentation for the Aspeed USB2.0 Device > Controller. > > Signed-off-by: Neal Liu > --- > .../devicetree/bindings/usb/aspeed,udc.yaml | 52 +++++++++++++++++++ > 1 file changed, 52 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/aspeed,udc.yaml Please name the file as first compatible, so "aspeed,ast2600-udc.yaml" > > diff --git a/Documentation/devicetree/bindings/usb/aspeed,udc.yaml b/Documentation/devicetree/bindings/usb/aspeed,udc.yaml > new file mode 100644 > index 000000000000..d1d2f77d1c54 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/aspeed,udc.yaml > @@ -0,0 +1,52 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (c) 2020 Facebook Inc. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/usb/aspeed,udc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ASPEED USB 2.0 Device Controller > + > +maintainers: > + - Neal Liu > + > +description: |+ > + The ASPEED USB 2.0 Device Controller implements 1 control endpoint and > + 4 generic endpoints for AST260x. > + > + Supports independent DMA channel for each generic endpoint. > + Supports 32/256 stages descriptor mode for all generic endpoints. > + > +properties: > + compatible: > + enum: > + - aspeed,ast2600-udc > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 No child properties? No ports or any other devices? No usb-hcd.yaml? > + > +required: > + - compatible > + - reg > + - clocks > + - interrupts > + > +additionalProperties: false > + > +examples: > + - | > + #include > + udc: udc@1e6a2000 { Node name: usb > + compatible = "aspeed,ast2600-udc"; > + reg = <0x1e6a2000 0x300>; > + interrupts = <9>; > + clocks = <&syscon ASPEED_CLK_GATE_USBPORT2CLK>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_usb2bd_default>; > + }; Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4889DC433EF for ; Fri, 13 May 2022 09:07:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 85D1B10F261; Fri, 13 May 2022 09:07:08 +0000 (UTC) Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by gabe.freedesktop.org (Postfix) with ESMTPS id A43D010F261 for ; Fri, 13 May 2022 09:07:07 +0000 (UTC) Received: by mail-wr1-x432.google.com with SMTP id f2so3522964wrc.0 for ; Fri, 13 May 2022 02:07:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=tQhMv5wgd6P5e5ZPKnJXTqhF5TWWKVPkk+00hnqjRXs=; b=l8ZqzODxTeK4g2pTFG9ZfVYndijHwk3ii/cTxtexptHo590e35fS20iJwufNZdEh92 2jnMvPNFHcft1cWJ2CbcRhtpHmMAmc8dJINengKkOOb5LUd5kbGum+qa3F+Uqhq9WxGl Y+4vNppopCVyTh/NMA/pHCUtSirsXcuUpHKpHmqmDSiZwaJhIZS9BkwROWE1xhfpXly0 vSZYHS/eCsuDxwTwx4exGV1Fcw0wIFsgGORQL+NhF0F+GT4P72xlIFvgV2ehYcMbmDo+ /yl0yWZV9wzV5KCbXL8PYSXGFZ+bnosYCEC8iFJe3AHNNRz4j1c+vziQGTi+0eTaY+OS xqFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=tQhMv5wgd6P5e5ZPKnJXTqhF5TWWKVPkk+00hnqjRXs=; b=60Q75ECN2tzX59Rpk79JuU5+gHoR/BvvocOz1/EtCHvydZOcWBQvkbqJDFrEO67t0m J0xBmq5AeTQLqD0fexpxfTsQcjbTmEIIkdGg5j0luh/BIvFnqWqowwox8T11sdChqD+l DKEwftMaRR1tGqsCsXF9Wn0nTIf+zoGfVsLGA/WLqlnnaTef+fiM/Br3ChvsXSoU68Qn q4PeqxQg4vJJ0qgwi900nau6uv+A7vCIDKSbvG0COpa3V1ZNWzU+cCdUjM9WusnnoGwo KYIuVmLX9GnCfJjaOAYhIz2H3iW3QVtcoTX/JmBWoV1eyjtxUmzl5H3bKEjmIzwoECGQ 6adQ== X-Gm-Message-State: AOAM5314/E17Z5wxJOsLfbqpVfulClbNZ+vMoxmNiRq/wCKG49LTvvET 69TScXiAzdjNxwffYeGDm5h9cQ== X-Google-Smtp-Source: ABdhPJy98bvsVxNsD1pSSLGnY3/tw/4jQw9PX2RSQLFiZDfcJuBduq4HwVBFKrcSH9BcOE5sNaEWQA== X-Received: by 2002:a5d:4090:0:b0:20c:8b91:3b17 with SMTP id o16-20020a5d4090000000b0020c8b913b17mr2991905wrp.348.1652432826026; Fri, 13 May 2022 02:07:06 -0700 (PDT) Received: from [192.168.0.169] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id s23-20020adfa297000000b0020c5253d8f4sm1662710wra.64.2022.05.13.02.07.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 May 2022 02:07:05 -0700 (PDT) Message-ID: Date: Fri, 13 May 2022 11:07:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 3/3] dt-bindings: usb: add documentation for aspeed udc Content-Language: en-US To: Neal Liu , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Joel Stanley , Andrew Jeffery , Felipe Balbi , Sumit Semwal , =?UTF-8?Q?Christian_K=c3=b6nig?= , Geert Uytterhoeven , Li Yang References: <20220513065728.857722-1-neal_liu@aspeedtech.com> <20220513065728.857722-4-neal_liu@aspeedtech.com> From: Krzysztof Kozlowski In-Reply-To: <20220513065728.857722-4-neal_liu@aspeedtech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-aspeed@lists.ozlabs.org, BMC-SW@aspeedtech.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 13/05/2022 08:57, Neal Liu wrote: > Add device tree binding documentation for the Aspeed USB2.0 Device > Controller. > > Signed-off-by: Neal Liu > --- > .../devicetree/bindings/usb/aspeed,udc.yaml | 52 +++++++++++++++++++ > 1 file changed, 52 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/aspeed,udc.yaml Please name the file as first compatible, so "aspeed,ast2600-udc.yaml" > > diff --git a/Documentation/devicetree/bindings/usb/aspeed,udc.yaml b/Documentation/devicetree/bindings/usb/aspeed,udc.yaml > new file mode 100644 > index 000000000000..d1d2f77d1c54 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/aspeed,udc.yaml > @@ -0,0 +1,52 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (c) 2020 Facebook Inc. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/usb/aspeed,udc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ASPEED USB 2.0 Device Controller > + > +maintainers: > + - Neal Liu > + > +description: |+ > + The ASPEED USB 2.0 Device Controller implements 1 control endpoint and > + 4 generic endpoints for AST260x. > + > + Supports independent DMA channel for each generic endpoint. > + Supports 32/256 stages descriptor mode for all generic endpoints. > + > +properties: > + compatible: > + enum: > + - aspeed,ast2600-udc > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 No child properties? No ports or any other devices? No usb-hcd.yaml? > + > +required: > + - compatible > + - reg > + - clocks > + - interrupts > + > +additionalProperties: false > + > +examples: > + - | > + #include > + udc: udc@1e6a2000 { Node name: usb > + compatible = "aspeed,ast2600-udc"; > + reg = <0x1e6a2000 0x300>; > + interrupts = <9>; > + clocks = <&syscon ASPEED_CLK_GATE_USBPORT2CLK>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_usb2bd_default>; > + }; Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C9F8C433F5 for ; Fri, 13 May 2022 09:08:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=V/KFTzJhCHWNGne7ancRDhdWGl2mRcjGLRLHXR3G2jY=; b=UrESa9Htnd5X4F GXa0YNYXtm3sj9S15VzemsYDWC3LGbwFFgecvxV9kBAvsA4qXxIKk1L/S13gH8FDBnX6MY509sSVd b2UEqRTvqal7bM1+WZtl/Hl2NurZR6iXNqXTflx8W5tAcOCIPQMoNy/rnF2pKbzElHTFmJkHluWYH 8yCdbpWdPRlV3Pm4vGfdJLYAPjiJZTSd2QYvONAKDDB3vIxEwcAwgEKvsJw9FBKzBwQUtralKsRiP rdt0D39QSMUy3Pv7qjcyO4ZLPkRPUe3igTyakR7LIFFT1xSnBABh4+c7TwE5zdeDc/YoGzp9vvvS8 VegO2EyRdfgmq4GKnu2Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1npRGR-00FEel-2h; Fri, 13 May 2022 09:07:11 +0000 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1npRGN-00FEeD-MI for linux-arm-kernel@lists.infradead.org; Fri, 13 May 2022 09:07:09 +0000 Received: by mail-wr1-x433.google.com with SMTP id j25so9521531wrc.9 for ; Fri, 13 May 2022 02:07:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=tQhMv5wgd6P5e5ZPKnJXTqhF5TWWKVPkk+00hnqjRXs=; b=l8ZqzODxTeK4g2pTFG9ZfVYndijHwk3ii/cTxtexptHo590e35fS20iJwufNZdEh92 2jnMvPNFHcft1cWJ2CbcRhtpHmMAmc8dJINengKkOOb5LUd5kbGum+qa3F+Uqhq9WxGl Y+4vNppopCVyTh/NMA/pHCUtSirsXcuUpHKpHmqmDSiZwaJhIZS9BkwROWE1xhfpXly0 vSZYHS/eCsuDxwTwx4exGV1Fcw0wIFsgGORQL+NhF0F+GT4P72xlIFvgV2ehYcMbmDo+ /yl0yWZV9wzV5KCbXL8PYSXGFZ+bnosYCEC8iFJe3AHNNRz4j1c+vziQGTi+0eTaY+OS xqFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=tQhMv5wgd6P5e5ZPKnJXTqhF5TWWKVPkk+00hnqjRXs=; b=WkjN6/7hYHLr1uX6JkMWRbC4FdLU98w8/RI0B31JD5/pJvusINt6HnTPs+jfwP18Ng r5Wb6UQHQNwInpAgyWKDjnH0Cv7O6GjD/8TUO4CYnyNxhULLLaYA3Vy4HwFL/bo+erFY MXi8eMqkgupFzcee35iNXw0Ww3MNsNu+ySq/Em8dzvnO+A9HbPOUhwtHKm/cSyGRJHjK UYcLZYEcRwF4d+sTuBdKcZ4BLozzR5esvXVSHbvyE7tEZl49IeA92MnYTzezRXlQ7jhU x/hnfsVJPZqZ5mdOQGvomnDU3qPxarorRTDgK7MjjvY8I385S4vzDixRaBGGqchf7QT9 mB6w== X-Gm-Message-State: AOAM533OFRmdp+1jqQrbpEbxBXn+rEaOMpPGK/sLaSaNR/+0NPntlHto x89TKnKLsQfRM7rp3rVHpcWV7A== X-Google-Smtp-Source: ABdhPJy98bvsVxNsD1pSSLGnY3/tw/4jQw9PX2RSQLFiZDfcJuBduq4HwVBFKrcSH9BcOE5sNaEWQA== X-Received: by 2002:a5d:4090:0:b0:20c:8b91:3b17 with SMTP id o16-20020a5d4090000000b0020c8b913b17mr2991905wrp.348.1652432826026; Fri, 13 May 2022 02:07:06 -0700 (PDT) Received: from [192.168.0.169] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id s23-20020adfa297000000b0020c5253d8f4sm1662710wra.64.2022.05.13.02.07.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 May 2022 02:07:05 -0700 (PDT) Message-ID: Date: Fri, 13 May 2022 11:07:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 3/3] dt-bindings: usb: add documentation for aspeed udc Content-Language: en-US To: Neal Liu , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Joel Stanley , Andrew Jeffery , Felipe Balbi , Sumit Semwal , =?UTF-8?Q?Christian_K=c3=b6nig?= , Geert Uytterhoeven , Li Yang Cc: linux-aspeed@lists.ozlabs.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, BMC-SW@aspeedtech.com References: <20220513065728.857722-1-neal_liu@aspeedtech.com> <20220513065728.857722-4-neal_liu@aspeedtech.com> From: Krzysztof Kozlowski In-Reply-To: <20220513065728.857722-4-neal_liu@aspeedtech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220513_020707_780736_2031FB8A X-CRM114-Status: GOOD ( 17.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 13/05/2022 08:57, Neal Liu wrote: > Add device tree binding documentation for the Aspeed USB2.0 Device > Controller. > > Signed-off-by: Neal Liu > --- > .../devicetree/bindings/usb/aspeed,udc.yaml | 52 +++++++++++++++++++ > 1 file changed, 52 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/aspeed,udc.yaml Please name the file as first compatible, so "aspeed,ast2600-udc.yaml" > > diff --git a/Documentation/devicetree/bindings/usb/aspeed,udc.yaml b/Documentation/devicetree/bindings/usb/aspeed,udc.yaml > new file mode 100644 > index 000000000000..d1d2f77d1c54 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/aspeed,udc.yaml > @@ -0,0 +1,52 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (c) 2020 Facebook Inc. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/usb/aspeed,udc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ASPEED USB 2.0 Device Controller > + > +maintainers: > + - Neal Liu > + > +description: |+ > + The ASPEED USB 2.0 Device Controller implements 1 control endpoint and > + 4 generic endpoints for AST260x. > + > + Supports independent DMA channel for each generic endpoint. > + Supports 32/256 stages descriptor mode for all generic endpoints. > + > +properties: > + compatible: > + enum: > + - aspeed,ast2600-udc > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 No child properties? No ports or any other devices? No usb-hcd.yaml? > + > +required: > + - compatible > + - reg > + - clocks > + - interrupts > + > +additionalProperties: false > + > +examples: > + - | > + #include > + udc: udc@1e6a2000 { Node name: usb > + compatible = "aspeed,ast2600-udc"; > + reg = <0x1e6a2000 0x300>; > + interrupts = <9>; > + clocks = <&syscon ASPEED_CLK_GATE_USBPORT2CLK>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_usb2bd_default>; > + }; Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel