From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7766BC43381 for ; Tue, 26 Feb 2019 02:15:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2599A217F4 for ; Tue, 26 Feb 2019 02:15:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=cumulusnetworks.com header.i=@cumulusnetworks.com header.b="eOQSD2dL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726082AbfBZCPa (ORCPT ); Mon, 25 Feb 2019 21:15:30 -0500 Received: from mail-pl1-f178.google.com ([209.85.214.178]:37586 "EHLO mail-pl1-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725929AbfBZCPa (ORCPT ); Mon, 25 Feb 2019 21:15:30 -0500 Received: by mail-pl1-f178.google.com with SMTP id q3so5435059pll.4 for ; Mon, 25 Feb 2019 18:15:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cumulusnetworks.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=sdyeCBLRsryFUt0SuMTEX5rXi1DBMtmcsJDCydfC4t4=; b=eOQSD2dLlsMCjIbi9Et87NL1r9wiBgHG8I3ADrOH/WZp5bdMt8HjS5zbDXUQywk85I 1xuk7P9KU4ptVH7mtex3C0YKDvvMzUhx5vwDzonUXAKmsZUZRhwT3q3g72lwABPbRv13 YPzSnOeLtJyieYl7Z/7sm44HUbqEXo5Ub7R5c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=sdyeCBLRsryFUt0SuMTEX5rXi1DBMtmcsJDCydfC4t4=; b=uZap/JbuGLtYMHFBkZTC5CiRF3ctganxlhaJIIyleHvaKrKybWOW5pol043UkEIeQg S9jBrO/qm6a9WP963Ex7DQRNn5iDUQTwNiVeztQWO3j6bmVhtkDooFbamei67yc26Cji OirlNPigKun0SaPlff2oRIne0aWgOElbsWFQ6+0+pl2XQHWWmyERS5pRVQvrr45qwk6d JUS+JLMRoq7Ki1pWqe2yyWqdcMMLdTJ5ZK5srfmJ+4zRMHO+lsHV0jikpl2cR/0phzbb 7BMRZ07hidQyr3N9Tc4Z2zOFbLsM4EN1ro1UQn1+PUrh5SzagFO4nBVlUgKwolVyOSvi ZzcQ== X-Gm-Message-State: AHQUAubQs80Z5aG42WsNN67rIq/vRcJ0L2H1gtR852AoCyetMb5rRLvO ysB/IIJrIL/wr0yr29DGOYe1Cg== X-Google-Smtp-Source: AHgI3IYStNZn5aXiHKJjzpXyJtXlCIe+RumAQNkKeSJ8bqLix+i23exaFvnKBT95aR4R0IwVX6h7iA== X-Received: by 2002:a17:902:6a83:: with SMTP id n3mr23621177plk.313.1551147329726; Mon, 25 Feb 2019 18:15:29 -0800 (PST) Received: from ?IPv6:2601:282:800:fd80:e962:5547:1520:25d4? ([2601:282:800:fd80:e962:5547:1520:25d4]) by smtp.googlemail.com with ESMTPSA id x2sm16421147pfx.78.2019.02.25.18.15.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Feb 2019 18:15:28 -0800 (PST) Subject: Re: [PATCH net] sit: use ipv6_mod_enabled to check if ipv6 is disabled To: Hangbin Liu Cc: Eric Dumazet , netdev@vger.kernel.org, Stefano Brivio , "David S . Miller" References: <20190225041243.9753-1-liuhangbin@gmail.com> <7c0f5c9c-d918-de27-643d-416509576be4@gmail.com> <20190225081759.GP10051@dhcp-12-139.nay.redhat.com> <1dd57d9d-fed2-67b8-ac28-7ef3681eeed2@gmail.com> <20190226015533.GR10051@dhcp-12-139.nay.redhat.com> From: David Ahern Message-ID: Date: Mon, 25 Feb 2019 19:15:26 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190226015533.GR10051@dhcp-12-139.nay.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/25/19 6:55 PM, Hangbin Liu wrote: > Just as I said, this issue only occurs when IPv6 is disabled at boot time > as there is no IPv6 route entry. Disable ipv6 on specific interface should > not be affected(IPv6 route/fib has inited). So I think use ipv6_mod_enabled() > would be more suitable in this scenario. Did I miss something? >From a readability perspective the code path depends on whether ipv6 is enabled on the device. I think it is better to leave that as it is.