From: George Dunlap <george.dunlap@citrix.com>
To: Alexandru Stefan ISAILA <aisaila@bitdefender.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"Jan Beulich" <jbeulich@suse.com>
Cc: "Kevin Tian" <kevin.tian@intel.com>, "Wei Liu" <wl@xen.org>,
"George Dunlap" <george.dunlap@eu.citrix.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Jun Nakajima" <jun.nakajima@intel.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH V6 3/4] x86/mm: Pull out the p2m specifics from p2m_init_altp2m_ept
Date: Mon, 6 Jan 2020 14:18:47 +0000 [thread overview]
Message-ID: <da7a69c7-b7f8-7836-cfa6-c06cb4db3a70@citrix.com> (raw)
In-Reply-To: <578c32be-a45a-d58e-7f88-03db2ff109a8@bitdefender.com>
On 1/6/20 11:55 AM, Alexandru Stefan ISAILA wrote:
> On 24.12.2019 12:15, George Dunlap wrote:
>> On 12/24/19 10:08 AM, Alexandru Stefan ISAILA wrote:
>>>
>>>
>>> On 24.12.2019 10:01, George Dunlap wrote:
>>>> On 12/23/19 2:04 PM, Alexandru Stefan ISAILA wrote:
>>>>
>>>> Why?
>>>>
>>>
>>> This was a request from Jan.
>>
>> Yes, I saw the Requested-by. It still needs an explanation.
>>
>
> This is what Jan said in V2:
>
> "All of this is not EPT-specific. Before adding more infrastructure to
> cover for this (here: another function parameter), how about moving
> these parts into vendor-independent code?"
>
> If there is a need for further explanation maybe Jan can help here.
You don't have to make every clean-up patch that reviewers ask for; but
if you do post a clean-up patch, it's your responsibility to make sure
it's got a suitable description. The audience is not only the reviewer
who asked for the patch, but also normal developers 5 years from now
(perhaps yourself) who are trying to figure out why the change was made.
-George
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2020-01-06 14:19 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-23 14:04 [Xen-devel] [PATCH V6 1/4] x86/mm: Add array_index_nospec to guest provided index values Alexandru Stefan ISAILA
2019-12-23 14:04 ` [Xen-devel] [PATCH V6 2/4] x86/altp2m: Add hypercall to set a range of sve bits Alexandru Stefan ISAILA
2019-12-23 16:31 ` Tamas K Lengyel
2020-01-06 9:21 ` Alexandru Stefan ISAILA
2019-12-24 8:30 ` George Dunlap
2019-12-24 8:48 ` Alexandru Stefan ISAILA
2019-12-24 8:58 ` George Dunlap
2019-12-24 9:04 ` Alexandru Stefan ISAILA
2019-12-24 9:25 ` George Dunlap
2019-12-27 8:01 ` Jan Beulich
2019-12-23 14:04 ` [Xen-devel] [PATCH V6 3/4] x86/mm: Pull out the p2m specifics from p2m_init_altp2m_ept Alexandru Stefan ISAILA
2019-12-24 8:01 ` George Dunlap
2019-12-24 10:08 ` Alexandru Stefan ISAILA
2019-12-24 10:15 ` George Dunlap
2020-01-06 11:55 ` Alexandru Stefan ISAILA
2020-01-06 12:42 ` Jan Beulich
2020-01-06 14:15 ` George Dunlap
2020-01-06 14:18 ` George Dunlap [this message]
2019-12-23 14:04 ` [Xen-devel] [PATCH V6 4/4] x86/mm: Make use of the default access param from xc_altp2m_create_view Alexandru Stefan ISAILA
2019-12-24 8:48 ` George Dunlap
2019-12-24 10:19 ` Alexandru Stefan ISAILA
2019-12-23 16:38 ` [Xen-devel] [PATCH V6 1/4] x86/mm: Add array_index_nospec to guest provided index values Tamas K Lengyel
2019-12-23 18:08 ` George Dunlap
2019-12-27 7:52 ` Jan Beulich
2019-12-27 7:59 ` Jan Beulich
2019-12-27 10:52 ` George Dunlap
2019-12-27 12:17 ` Jan Beulich
2019-12-27 8:01 ` Jan Beulich
2020-01-07 13:25 ` Alexandru Stefan ISAILA
2020-01-07 13:55 ` Jan Beulich
2020-01-07 14:31 ` Alexandru Stefan ISAILA
2020-01-07 15:06 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da7a69c7-b7f8-7836-cfa6-c06cb4db3a70@citrix.com \
--to=george.dunlap@citrix.com \
--cc=aisaila@bitdefender.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=jun.nakajima@intel.com \
--cc=kevin.tian@intel.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.