From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH] ethdev: rename folder to library name Date: Tue, 3 Apr 2018 14:29:03 +0100 Message-ID: References: <20180403092859.71589-1-ferruh.yigit@intel.com> <4D4592F2-7C34-489E-BBAD-A3E8422FD468@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: Thomas Monjalon , "Mcnamara, John" , "Kovacevic, Marko" , "dev@dpdk.org" , "Richardson, Bruce" To: "Wiles, Keith" Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 4F8A425A1 for ; Tue, 3 Apr 2018 15:29:10 +0200 (CEST) In-Reply-To: <4D4592F2-7C34-489E-BBAD-A3E8422FD468@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/3/2018 2:17 PM, Wiles, Keith wrote: > > >> On Apr 3, 2018, at 4:28 AM, Ferruh Yigit wrote: >> >> Library folder name and output library name are same except a few flaws >> including librte_ether. >> >> This library is network device abstraction layer, the name "ethdev" fits >> better than "ether", and library & header files already named as ethdev. >> >> Also there is a rte_ether.h in the net library which can cause confusion. >> >> Signed-off-by: Ferruh Yigit >> --- >> Not sure if the we are ready for this change J >> >> This is one the issues that the hassle of the change doesn't worth the >> benefit and you may prefer to live with the flaw. >> >> Also a concern is this breaks the git history. > > I believe as long as you used ‘git mv’ the git history should not be broken, correct? I think this will help in some conflict resolving or git blame, but if you check the history directly with path, it won't show the past: "git log --oneline lib/librte_ethdev/": Will start from this commit