All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Michael Tokarev <mjt@tls.msk.ru>,
	qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
	Peter Maydell <peter.maydell@linaro.org>,
	qemu-arm@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 06/11] hw/arm: removed unnecessary include
Date: Fri, 9 Jun 2017 18:28:56 -0300	[thread overview]
Message-ID: <da9abd44-1f8b-2c1c-e63a-3ca706c95865@amsat.org> (raw)
In-Reply-To: <79598bed-714f-7c3b-a806-3bf1a4968fd2@msgid.tls.msk.ru>

On 05/23/2017 11:58 AM, Michael Tokarev wrote:
> 09.05.2017 02:39, Philippe Mathieu-Daudé wrote:
>> "exec/memory.h" already includes it.
>
> I think this sort of include cleanups isn't really necessary.

Some are useful ;)

> For a regular include file, it's better to include it if the
> .c file in question uses definitions from there, no matter if
> other .h files include that header already or not.

Ok. This one was incorrect anyway :( thank for the review!

>
> Thanks,
>
> /mjt
>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>>  include/hw/arm/arm.h | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/include/hw/arm/arm.h b/include/hw/arm/arm.h
>> index a3f79d3379..b9c11d3fb8 100644
>> --- a/include/hw/arm/arm.h
>> +++ b/include/hw/arm/arm.h
>> @@ -14,7 +14,6 @@
>>  #include "exec/memory.h"
>>  #include "target/arm/cpu-qom.h"
>>  #include "hw/irq.h"
>> -#include "qemu/notify.h"
>>
>>  typedef enum {
>>      ARM_ENDIANNESS_UNKNOWN = 0,
>>
>

  reply	other threads:[~2017-06-09 21:29 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-08 23:39 [Qemu-devel] [PATCH 00/11] various easy cleanups Philippe Mathieu-Daudé
2017-05-08 23:39 ` [Qemu-devel] [PATCH 01/11] hw/net: removed obsolete comments Philippe Mathieu-Daudé
2017-05-09  7:27   ` Alex Bennée
2017-05-08 23:39 ` [Qemu-devel] [RFC PATCH 02/11] hw/pci: define msi_nonbroken in pci-stub Philippe Mathieu-Daudé
2017-05-09  5:19   ` Thomas Huth
2017-05-09 16:49     ` Philippe Mathieu-Daudé
2017-05-09 18:24       ` Thomas Huth
2017-05-08 23:39 ` [Qemu-devel] [PATCH 03/11] hw/misc: add missing includes Philippe Mathieu-Daudé
2017-05-08 23:56   ` Eric Blake
2017-05-09  0:56     ` Philippe Mathieu-Daudé
2017-05-09 17:20       ` Philippe Mathieu-Daudé
2017-05-09 17:24         ` Eric Blake
2017-09-05  9:35     ` Philippe Mathieu-Daudé
2017-09-05  9:39       ` Peter Maydell
2017-05-08 23:39 ` [Qemu-devel] [PATCH 04/11] ide/ahci: " Philippe Mathieu-Daudé
2017-05-08 23:58   ` Eric Blake
2017-05-09 13:49     ` John Snow
2017-06-09 15:05       ` [Qemu-devel] [RFC PATCH 0/2] " Philippe Mathieu-Daudé
2017-06-09 15:05       ` [Qemu-devel] [RFC PATCH 1/2] arm/highbank: use defined type name instead of hard-coded string Philippe Mathieu-Daudé
2017-06-23 22:18         ` John Snow
2017-06-26  4:32           ` Philippe Mathieu-Daudé
2017-06-09 15:06       ` [Qemu-devel] [RFC PATCH 2/2] ide/ahci: add missing includes Philippe Mathieu-Daudé
2017-05-08 23:39 ` [Qemu-devel] [PATCH 05/11] hw/mips: add missing include Philippe Mathieu-Daudé
2017-05-08 23:55   ` Aurelien Jarno
2017-05-23 15:00   ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2017-05-08 23:39 ` [Qemu-devel] [PATCH 06/11] hw/arm: removed unnecessary include Philippe Mathieu-Daudé
2017-05-23 14:58   ` Michael Tokarev
2017-06-09 21:28     ` Philippe Mathieu-Daudé [this message]
2017-05-08 23:39 ` [Qemu-devel] [PATCH 08/11] hw/sparc: use ARRAY_SIZE() macro Philippe Mathieu-Daudé
2017-05-09  7:25   ` Alex Bennée
2017-05-23 14:56   ` Michael Tokarev
2017-05-08 23:39 ` [Qemu-devel] [PATCH 09/11] target/sparc: fix DEBUG_MMU DPRINTF() arguments Philippe Mathieu-Daudé
2017-05-09  0:00   ` Eric Blake
2017-05-09  0:54     ` Philippe Mathieu-Daudé
2017-05-08 23:39 ` [Qemu-devel] [PATCH 10/11] register: display register prefix (name) since it is available Philippe Mathieu-Daudé
2017-05-09  0:05   ` Alistair Francis
2017-05-23 14:56   ` Michael Tokarev
2017-05-08 23:39 ` [Qemu-devel] [PATCH 11/11] MAINTAINERS: self-appoint me as reviewer of the Register API Philippe Mathieu-Daudé
2017-05-23 15:03 ` [Qemu-devel] [PATCH 00/11] various easy cleanups Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=da9abd44-1f8b-2c1c-e63a-3ca706c95865@amsat.org \
    --to=f4bug@amsat.org \
    --cc=mjt@tls.msk.ru \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.