From: Anoob Soman <anoob.soman@citrix.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Cc: jgross@suse.com
Subject: Re: [PATCH] xen-evtchn: Bind dyn evtchn:qemu-dm interrupt to next online VCPU
Date: Mon, 5 Jun 2017 17:14:34 +0100 [thread overview]
Message-ID: <da9d7835-7473-87fc-9766-016a743af5ef__42382.3804980659$1496679338$gmane$org@citrix.com> (raw)
In-Reply-To: <f6ae8dd3-0a17-bb62-596f-3512f0ab102b@oracle.com>
On 05/06/17 16:32, Boris Ostrovsky wrote:
> I believe we do need to take affinity into consideration even if the
> chance that it is non-default is small.
Agreed.
> I am not opposed to having bind_last_selected_cpu percpu, I just wanted
> to understand the reason better. Additional locking would be a downside
> with a global so if you feel that percpu is worth it then I won't object.
If affinity == cpu_online_mask, then percpu will give a better spread.
atomic set/get can be used, if we want to use a global variable, but I
think it will be more random than percpu.
>
>> Yes, you are correct. .irq_set_affinity pretty much does the same thing.
>>
>> The code will now looks like this.
>> raw_spin_lock_irqsave(lock, flags);
>> percpu read
>> select_cpu
>> percpu write
>> xen_rebind_evtchn_to_cpu(evtchn, selected_cpu)
>> raw_spin_unlock_irqsave(lock, flags);
> (BTW, I just noticed --- you don't need to initialize desc)
Sorry, I didn't get it. Which desc doesn't need init ?
-Anoob
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-06-05 16:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-02 14:49 [PATCH] xen-evtchn: Bind dyn evtchn:qemu-dm interrupt to next online VCPU Anoob Soman
2017-06-02 15:10 ` Juergen Gross
2017-06-02 15:10 ` Juergen Gross
2017-06-05 9:54 ` Anoob Soman
2017-06-05 9:54 ` Anoob Soman
2017-06-02 16:24 ` Boris Ostrovsky
2017-06-02 16:24 ` Boris Ostrovsky
2017-06-05 10:14 ` Anoob Soman
2017-06-05 14:10 ` Boris Ostrovsky
2017-06-05 14:49 ` [Xen-devel] " Anoob Soman
2017-06-05 15:32 ` Boris Ostrovsky
2017-06-05 16:14 ` Anoob Soman
2017-06-05 16:46 ` Boris Ostrovsky
2017-06-05 17:13 ` Anoob Soman
2017-06-05 17:13 ` Anoob Soman
2017-06-05 16:46 ` Boris Ostrovsky
2017-06-05 16:14 ` Anoob Soman [this message]
2017-06-05 15:32 ` Boris Ostrovsky
2017-06-05 14:49 ` Anoob Soman
2017-06-05 14:10 ` Boris Ostrovsky
2017-06-05 10:14 ` Anoob Soman
2017-06-02 14:49 Anoob Soman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='da9d7835-7473-87fc-9766-016a743af5ef__42382.3804980659$1496679338$gmane$org@citrix.com' \
--to=anoob.soman@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.