All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafał Miłecki" <zajec5@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Rob Herring" <robh+dt@kernel.org>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Álvaro Fernández Rojas" <noltari@gmail.com>,
	"Jonas Gorski" <jonas.gorski@gmail.com>,
	"Randy Dunlap" <rdunlap@infradead.org>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	devicetree <devicetree@vger.kernel.org>,
	bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
	"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH V2 2/2] pinctrl: bcm: add driver for BCM4908 pinmux
Date: Wed, 22 Dec 2021 13:30:47 +0100	[thread overview]
Message-ID: <daa0eaf5-952f-df7a-b8a7-08f7d34a8d58@gmail.com> (raw)
In-Reply-To: <CAHp75VcdXR=vZ3=UX+GKbA1hMvQ=4rKJyPkg+BQskepL9SCSyw@mail.gmail.com>

On 22.12.2021 13:13, Andy Shevchenko wrote:
> On Wed, Dec 22, 2021 at 1:11 PM Rafał Miłecki <zajec5@gmail.com> wrote:
>> From: Rafał Miłecki <rafal@milecki.pl>
>>
>> BCM4908 has its own pins layout so it needs a custom binding and a Linux
>> driver.
> 
> ...
> 
>> V2: Formatting fixes
>>      Kconfig fix
>>      Cleanup of #include-s
>>      Use devm_kasprintf_strarray()
> 
> Thanks, but it seems there are unsettled down points as per v1.
> Can you comment on them there?

Those remaining comments are a matter of personal taste & details of
personal coding style. We don't have defined rules for such details.

If developer submitted code that matches *defined* rules and is fine to
read I don't see why we should enforce someone's coding style. We may
easily get into pointless and time wasting argues between multiple
developers.

Empty line after one-line comment isn't against rules and checkpatch.pl
doesn't complain about it.

I've never heard of rule of sorting #include-s from the most generic to
the most particular one. I don't even know how to meter that. Actually
coding-style.rst suggests #include-s should be sorted but without
specifying how. My first guess is alphabetical order.

If you think some extra coding style should be enforced for Linux code
please kindly update coding-style.rst and checkpatch.pl so that:

1. We have clear rules
2. We keep code consistent across subsystems
3. It can be automatically verified
4. There are not more argues about what's the preferred format

As I pointed out we have over 1000 examples of empty line above
module_platform_driver() so clearly what you describe as common sense
isn't clear for all developers.

  reply	other threads:[~2021-12-22 12:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-22 11:11 [PATCH V2 1/2] dt-bindings: pinctrl: Add binding for BCM4908 pinctrl Rafał Miłecki
2021-12-22 11:11 ` [PATCH V2 2/2] pinctrl: bcm: add driver for BCM4908 pinmux Rafał Miłecki
2021-12-22 12:13   ` Andy Shevchenko
2021-12-22 12:30     ` Rafał Miłecki [this message]
2021-12-22 12:43       ` Andy Shevchenko
2021-12-22 12:21   ` Andy Shevchenko
2022-01-05 12:24   ` kernel test robot
2022-01-05 12:34     ` Rafał Miłecki
2022-01-05 13:05   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=daa0eaf5-952f-df7a-b8a7-08f7d34a8d58@gmail.com \
    --to=zajec5@gmail.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=jonas.gorski@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=noltari@gmail.com \
    --cc=rafal@milecki.pl \
    --cc=rdunlap@infradead.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.