From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart Van Assche Subject: Re: PATCH 0/4] multipath-tools: Ceph rbd support v2 Date: Wed, 10 Aug 2016 08:42:04 -0700 Message-ID: References: <1470657710-28081-1-git-send-email-mchristi@redhat.com> <57AA2060.20708@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Christophe Varoqui , Mike Christie Cc: device-mapper development List-Id: dm-devel.ids On 08/10/2016 12:55 AM, Christophe Varoqui wrote: > Distributors will surely want to build all checkers to have the docs and > hwtable in sync with the shipped checkers, and cover the widest range of > setups. > > I'd rather drop this patch or, if it proves to be a problem, merge a > variant with the rbd checker build by default and not-buildable by > explicit define. Hello Mike and Christophe, How about detecting at compile time whether the rbd header files are available? That approach avoids that we have to introduce a configure script and also avoids that the user has to enable rbd support explicitly. In e.g. the fio makefile there are several tests to check which libraries are available and can be used during the fio build. Bart.