From: Eric Blake <eblake@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>,
"Vladimir Sementsov-Ogievskiy" <vsementsov@virtuozzo.com>
Cc: den@openvz.org, kraxel@redhat.com, qemu-devel@nongnu.org,
armbru@redhat.com
Subject: Re: [PATCH 0/2] keepalive default
Date: Thu, 9 Jul 2020 10:34:29 -0500 [thread overview]
Message-ID: <daa7864d-8979-1987-caf7-cca3cb9849ca@redhat.com> (raw)
In-Reply-To: <20200709083510.GF3753300@redhat.com>
On 7/9/20 3:35 AM, Daniel P. Berrangé wrote:
> On Wed, Jul 08, 2020 at 10:15:37PM +0300, Vladimir Sementsov-Ogievskiy wrote:
>> Hi all!
>>
>> We understood, that keepalive is almost superfluous with default 2 hours
>> in /proc/tcp_keepalive_time. Forcing user to setup keepalive for the
>> whole system doesn't seem right, better setup it per-socket.
>
> Adding the ability to explicitly configure the keepalive settings makes
> sense for QEMU. Completely ignoring system defaults when no explicit
> settings are given though is not valid IMHO.
We already have the ability to add per-socket keepalive (see commit
aec21d3175, in 4.2). I guess what you are trying to further do is
determine whether the default value for that field, when not explicitly
specified by the user, can have saner semantics (default off for chardev
sockets, default on for nbd clients where retry was enabled). But since
you already have to explicitly opt-in to nbd retry, what's so hard about
opting in to keepalive at the same time, other than more typing? Given
that the easiest way to do this is via a machine-coded generation of the
command line or QMP command, it doesn't seem that hard to just keep
things as they are with explicit opt-in to per-socket keepalive.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2020-07-09 15:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 19:15 [PATCH 0/2] keepalive default Vladimir Sementsov-Ogievskiy
2020-07-08 19:15 ` [PATCH 1/2] sockets: keep-alive settings Vladimir Sementsov-Ogievskiy
2020-07-09 8:33 ` Daniel P. Berrangé
2020-07-08 19:15 ` [PATCH 2/2] util/qemu-sockets: make keep-alive enabled by default Vladimir Sementsov-Ogievskiy
2020-07-09 8:29 ` Daniel P. Berrangé
2020-07-09 8:49 ` Vladimir Sementsov-Ogievskiy
2020-07-09 11:52 ` Daniel P. Berrangé
2020-07-09 8:54 ` Denis V. Lunev
2020-07-09 11:40 ` Markus Armbruster
2020-07-08 19:41 ` [PATCH 0/2] keepalive default no-reply
2020-07-09 8:35 ` Daniel P. Berrangé
2020-07-09 15:34 ` Eric Blake [this message]
2020-07-09 17:14 ` Vladimir Sementsov-Ogievskiy
2020-07-10 19:25 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=daa7864d-8979-1987-caf7-cca3cb9849ca@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=den@openvz.org \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.