From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1168393AbcKAKAD (ORCPT ); Tue, 1 Nov 2016 06:00:03 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:36716 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1168237AbcKAKAB (ORCPT ); Tue, 1 Nov 2016 06:00:01 -0400 Subject: Re: [PATCH v8 3/3] ARM: davinci: da8xx: register USB PHY clocks in the DT file To: David Lechner , Rob Herring , Mark Rutland , Kevin Hilman References: <1477946841-16126-1-git-send-email-david@lechnology.com> <1477946841-16126-4-git-send-email-david@lechnology.com> CC: Axel Haslam , Bartosz Golaszewski , , , From: Sekhar Nori Message-ID: Date: Tue, 1 Nov 2016 15:28:39 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1477946841-16126-4-git-send-email-david@lechnology.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 01 November 2016 02:17 AM, David Lechner wrote: > From: Axel Haslam > > The usb20_phy clock needs to be registered for the driver to be able > to get and enable a clock. Currently the usb phy clocks are registered > form board files, which will not be called during a device tree based > boot. > > To be able to probe correctly usb form a device tree boot, register > the usb phy clocks form the DT specific init. > > Unfourtunatly, davinci does not have proper clock support on device tree > yet, so by registering the clock form de DT specific file we are > forced to hardcode the parent clock, and cannot select refclkin as > parent for any of the phy clocks of the da850 family. > > As none of the current da850 based boards currently in mainline use > refclkin as source. I guess we can live with this limitation until clocks > are correctly represented through CCF/device tree. > > Signed-off-by: Axel Haslam > [Added error checking] > Signed-off-by: David Lechner Applied to v4.10/soc with some typo fixes. s/form/from s/Unfourtunatly/Unfortunately s/de/the Thanks, Sekhar From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sekhar Nori Subject: Re: [PATCH v8 3/3] ARM: davinci: da8xx: register USB PHY clocks in the DT file Date: Tue, 1 Nov 2016 15:28:39 +0530 Message-ID: References: <1477946841-16126-1-git-send-email-david@lechnology.com> <1477946841-16126-4-git-send-email-david@lechnology.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1477946841-16126-4-git-send-email-david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: David Lechner , Rob Herring , Mark Rutland , Kevin Hilman Cc: Axel Haslam , Bartosz Golaszewski , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Tuesday 01 November 2016 02:17 AM, David Lechner wrote: > From: Axel Haslam > > The usb20_phy clock needs to be registered for the driver to be able > to get and enable a clock. Currently the usb phy clocks are registered > form board files, which will not be called during a device tree based > boot. > > To be able to probe correctly usb form a device tree boot, register > the usb phy clocks form the DT specific init. > > Unfourtunatly, davinci does not have proper clock support on device tree > yet, so by registering the clock form de DT specific file we are > forced to hardcode the parent clock, and cannot select refclkin as > parent for any of the phy clocks of the da850 family. > > As none of the current da850 based boards currently in mainline use > refclkin as source. I guess we can live with this limitation until clocks > are correctly represented through CCF/device tree. > > Signed-off-by: Axel Haslam > [Added error checking] > Signed-off-by: David Lechner Applied to v4.10/soc with some typo fixes. s/form/from s/Unfourtunatly/Unfortunately s/de/the Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: nsekhar@ti.com (Sekhar Nori) Date: Tue, 1 Nov 2016 15:28:39 +0530 Subject: [PATCH v8 3/3] ARM: davinci: da8xx: register USB PHY clocks in the DT file In-Reply-To: <1477946841-16126-4-git-send-email-david@lechnology.com> References: <1477946841-16126-1-git-send-email-david@lechnology.com> <1477946841-16126-4-git-send-email-david@lechnology.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tuesday 01 November 2016 02:17 AM, David Lechner wrote: > From: Axel Haslam > > The usb20_phy clock needs to be registered for the driver to be able > to get and enable a clock. Currently the usb phy clocks are registered > form board files, which will not be called during a device tree based > boot. > > To be able to probe correctly usb form a device tree boot, register > the usb phy clocks form the DT specific init. > > Unfourtunatly, davinci does not have proper clock support on device tree > yet, so by registering the clock form de DT specific file we are > forced to hardcode the parent clock, and cannot select refclkin as > parent for any of the phy clocks of the da850 family. > > As none of the current da850 based boards currently in mainline use > refclkin as source. I guess we can live with this limitation until clocks > are correctly represented through CCF/device tree. > > Signed-off-by: Axel Haslam > [Added error checking] > Signed-off-by: David Lechner Applied to v4.10/soc with some typo fixes. s/form/from s/Unfourtunatly/Unfortunately s/de/the Thanks, Sekhar