From: Dave Hansen <dave.hansen@intel.com>
To: Sidharth Telang <sidtelang@google.com>, marcorr@google.com
Cc: acdunlap@google.com, ak@linux.intel.com, alpergun@google.com,
ben-linux@fluff.org, bp@alien8.de, dave.hansen@linux.intel.com,
hpa@zytor.com, jacobhxu@google.com,
kirill.shutemov@linux.intel.com, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, mingo@redhat.com, nathan@kernel.org,
ndesaulniers@google.com, pgonda@google.com,
sathyanarayanan.kuppuswamy@linux.intel.com, seanjc@google.com,
tglx@linutronix.de, thomas.lendacky@amd.com, trix@redhat.com,
x86@kernel.org
Subject: Re: [PATCH v2 RESEND] x86/asm: Force native_apic_mem_read to use mov
Date: Fri, 17 Nov 2023 11:23:47 -0800 [thread overview]
Message-ID: <daba8825-9c81-4a82-9a7b-a6ea3e2c5537@intel.com> (raw)
In-Reply-To: <20231117181458.2260258-1-sidtelang@google.com>
On 11/17/23 10:14, Sidharth Telang wrote:
>> Is this blocked on an item? There seems to be consensus that this
>> patch fixes a bug and is taking the right high-level approach (i.e.,
>> change the guest code to avoid triggering a sequence that isn't
>> supported under CVM exception-based emulation). Without something like
>> this, we weren't able to build the kernel w/ CLANG when it is
>> configured to run under SEV-ES.
>
>> We sent out two versions of the patch. One that does the mov directly
>> [1] and a second that calls readl [2]. Is one of these two patches
>> acceptable? Or do we need to follow up on something?
>>
>> [1] https://lore.kernel.org/lkml/0D6A1E49-F21B-42AA-BBBF-13BFC308BB1E@zytor.com/T/
>> [2] https://lore.kernel.org/all/20220812183501.3555820-1-acdunlap@google.com/
>
> Signal-boosting this thread: is this blocked on any item?
Yes, it's blocked on you sending a well-described patch.
You sent out two patches which both received a lot of discussion and
induced a lot of confusion. Can you please take all the knowledge from
this thread and send a third patch that has a proper changelog
incorporating all that knowledge?
Which approach should that patch have? Whatever one is as close to what
native_apic_mem_write() does as possible.
next prev parent reply other threads:[~2023-11-17 19:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 18:00 [PATCH] x86/asm: Force native_apic_mem_read to use mov Adam Dunlap
2022-08-11 19:27 ` Sean Christopherson
2022-08-11 19:57 ` H. Peter Anvin
2022-08-11 20:03 ` Sean Christopherson
2022-08-12 4:40 ` H. Peter Anvin
2022-08-12 18:32 ` Adam Dunlap
2022-08-12 18:35 ` [PATCH v2] " Adam Dunlap
2022-09-08 17:04 ` [PATCH v2 RESEND] " Adam Dunlap
2022-09-14 11:13 ` Peter Gonda
2022-09-14 11:59 ` Marc Orr
2022-09-14 11:59 ` Marc Orr
2022-09-15 7:51 ` Tom Lendacky
2022-09-14 12:03 ` Dave Hansen
2022-09-14 16:22 ` Sean Christopherson
2022-09-15 8:09 ` Peter Gonda
[not found] ` <CAMBK9=YB=8EQymDUda300qPFAL1=7dzC61c0pshrWEC5ibrUfQ@mail.gmail.com>
2022-10-03 23:07 ` Adam Dunlap
[not found] ` <B7175642-351D-44A0-B7AD-E69C6B64FC18@zytor.com>
2022-10-05 13:28 ` Tom Lendacky
2022-11-17 21:23 ` Marc Orr
2023-11-17 18:14 ` Sidharth Telang
2023-11-17 19:23 ` Dave Hansen [this message]
2022-08-11 19:53 ` [PATCH] " H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=daba8825-9c81-4a82-9a7b-a6ea3e2c5537@intel.com \
--to=dave.hansen@intel.com \
--cc=acdunlap@google.com \
--cc=ak@linux.intel.com \
--cc=alpergun@google.com \
--cc=ben-linux@fluff.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jacobhxu@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=marcorr@google.com \
--cc=mingo@redhat.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=pgonda@google.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=seanjc@google.com \
--cc=sidtelang@google.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=trix@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.