From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A18FC6FD1D for ; Thu, 23 Mar 2023 14:31:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231524AbjCWOb5 (ORCPT ); Thu, 23 Mar 2023 10:31:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231475AbjCWObz (ORCPT ); Thu, 23 Mar 2023 10:31:55 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B85472A14C; Thu, 23 Mar 2023 07:31:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5270462766; Thu, 23 Mar 2023 14:31:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E407AC433EF; Thu, 23 Mar 2023 14:31:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679581898; bh=Sv3YybIQKDgWMcn1KW6KjvbVZBTE9wL1diTv47fKkqs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=gFywPhWzMoKqSKt+w9EW24FI9Ut3lF7kvBz/A9Q7RSqioTBgu8qyebBsk9D5c7lCw 8mYHdZ32zH6q13p7SUs9vQkPM3J1iRx9GWhaRIBq+FEIJJq/I5mwBTrecnPvggwGDH /juttkIXqnaCkT9yvwQtGtD10qz3k6cfXxggcnM/yiBd9SbEy8IF87yWBHh/j8Tft8 ZCink1m69aeWohxXaDL1ByWTb+ri8aY5Su/odbyVs1FQqc+RDOgUTqYsvk0BgQs/k3 d0h2Tf3fdIZzFnxK+146+01Vg3/Le3YZRtllkEWH5CVTwVxZILEj6I+jrikAiQz9Ye lA3M32DfTDhWQ== Message-ID: Date: Thu, 23 Mar 2023 22:31:36 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [f2fs-dev] [PATCH 2/3] f2fs: factor out discard_cmd usage from general rb_tree use Content-Language: en-US To: Jaegeuk Kim , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Cc: stable@vger.kernel.org References: <20230313201216.924234-1-jaegeuk@kernel.org> <20230313201216.924234-3-jaegeuk@kernel.org> From: Chao Yu In-Reply-To: <20230313201216.924234-3-jaegeuk@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/3/14 4:12, Jaegeuk Kim wrote: > This is a second part to remove the mixed use of rb_tree in discard_cmd from > extent_cache. > > This should also fix arm32 memory alignment issue caused by shared rb_entry. > > [struct discard_cmd] [struct rb_entry] > [0] struct rb_node rb_node; [0] struct rb_node rb_node; > union { union { > struct { struct { > [16] block_t lstart; [12] unsigned int ofs; > block_t len; unsigned int len; > }; > unsigned long long key; > } __packed; > > Cc: > Fixes: 004b68621897 ("f2fs: use rb-tree to track pending discard commands") > Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu Thanks, From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (unknown [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 36243C6FD1C for ; Thu, 23 Mar 2023 14:31:52 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1pfLyn-00074m-1D; Thu, 23 Mar 2023 14:31:51 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pfLyl-00074f-8h for linux-f2fs-devel@lists.sourceforge.net; Thu, 23 Mar 2023 14:31:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=lMMvq5TIJk5uvnf3xO4BsB9NNYLBhtiWzGbTSaGH21g=; b=MSPo/Tg+HU3wgv69FN0giwEcHp hrbtldwAY7ZCAggTMbCfuhIF63N6vrjPwpjl01kckQChmZXqYoA1NFj64BVHiGQAUf+WflAi73LPm 06/tjMPNgMXx6ZvhTjm1UfwVeitsHc9YzLUsM9BIFKV6anes0wc0k9gzWV+/bVihxwuE=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=lMMvq5TIJk5uvnf3xO4BsB9NNYLBhtiWzGbTSaGH21g=; b=MnH3VzPoxl2Bjpnf0bx27RPrCP whb2jB0HMMhNV+654zx7p8UfeJMDL68FbPASTycZEEQhf3ri10BK1WJdEK4RQObwNtGOzXlBoPIVv oIJtAekdnN5Lt3BZ+MKz0X4yN4s1XVGC5xwvb9XAN30l45wsh8kclgsUci8G/6DLLjZQ=; Received: from dfw.source.kernel.org ([139.178.84.217]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1pfLym-000Hy4-N8 for linux-f2fs-devel@lists.sourceforge.net; Thu, 23 Mar 2023 14:31:49 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4F344626D1 for ; Thu, 23 Mar 2023 14:31:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E407AC433EF; Thu, 23 Mar 2023 14:31:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679581898; bh=Sv3YybIQKDgWMcn1KW6KjvbVZBTE9wL1diTv47fKkqs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=gFywPhWzMoKqSKt+w9EW24FI9Ut3lF7kvBz/A9Q7RSqioTBgu8qyebBsk9D5c7lCw 8mYHdZ32zH6q13p7SUs9vQkPM3J1iRx9GWhaRIBq+FEIJJq/I5mwBTrecnPvggwGDH /juttkIXqnaCkT9yvwQtGtD10qz3k6cfXxggcnM/yiBd9SbEy8IF87yWBHh/j8Tft8 ZCink1m69aeWohxXaDL1ByWTb+ri8aY5Su/odbyVs1FQqc+RDOgUTqYsvk0BgQs/k3 d0h2Tf3fdIZzFnxK+146+01Vg3/Le3YZRtllkEWH5CVTwVxZILEj6I+jrikAiQz9Ye lA3M32DfTDhWQ== Message-ID: Date: Thu, 23 Mar 2023 22:31:36 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US To: Jaegeuk Kim , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <20230313201216.924234-1-jaegeuk@kernel.org> <20230313201216.924234-3-jaegeuk@kernel.org> From: Chao Yu In-Reply-To: <20230313201216.924234-3-jaegeuk@kernel.org> X-Headers-End: 1pfLym-000Hy4-N8 Subject: Re: [f2fs-dev] [PATCH 2/3] f2fs: factor out discard_cmd usage from general rb_tree use X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stable@vger.kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2023/3/14 4:12, Jaegeuk Kim wrote: > This is a second part to remove the mixed use of rb_tree in discard_cmd from > extent_cache. > > This should also fix arm32 memory alignment issue caused by shared rb_entry. > > [struct discard_cmd] [struct rb_entry] > [0] struct rb_node rb_node; [0] struct rb_node rb_node; > union { union { > struct { struct { > [16] block_t lstart; [12] unsigned int ofs; > block_t len; unsigned int len; > }; > unsigned long long key; > } __packed; > > Cc: > Fixes: 004b68621897 ("f2fs: use rb-tree to track pending discard commands") > Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu Thanks, _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel