All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/8] fdt: parse "reserved-memory" for memory reservation
Date: Thu, 29 Nov 2018 21:40:39 +0100	[thread overview]
Message-ID: <dabf6082-8a7d-74bc-f420-4bf40b7c361c@gmail.com> (raw)
In-Reply-To: <CAAh8qszFhZ28-Mtc6QsE0SXVWSmB+6oQE0Bwcc9bpthAsZP8AQ@mail.gmail.com>

On 27.11.2018 06:40, Simon Goldschmidt wrote:
> On Tue, Nov 27, 2018 at 2:02 AM Simon Glass <sjg@chromium.org> wrote:
>> Hi Simon,
>>
>> On Sat, 17 Nov 2018 at 02:18, Simon Goldschmidt
>> <simon.k.r.goldschmidt@gmail.com> wrote:
>>> boot_fdt_add_mem_rsv_regions() adds reserved memory sections to an lmb
>>> struct. Currently, it only parses regions described by /memreserve/
>>> entries.
>>>
>>> Extend this to the more commonly used scheme of the "reserved-memory"
>>> node.
>>>
>>> Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
>>> ---
>>>
>>> Changes in v2:
>>> - this patch is new in v2
>>>
>>>   common/image-fdt.c | 52 +++++++++++++++++++++++++++++++++++++++-------
>>>   1 file changed, 44 insertions(+), 8 deletions(-)
>> Reviewed-by: Simon Glass <sjg@chromium.org>
>>
>> But it would be nice to convert this to livetree.
> OK, let me try that ;-)

So I tried to convert to livetree but since the function 
'boot_fdt_add_mem_rsv_regions' is used on devicetrees loaded to boot 
Linux, I can't really change it (the 'of' functions use gd->fdt_addr' as 
fallback, which is wrong in that case).

Converting to livetree for the new usecases ('load' and 'tftp' commands) 
would be possible, but would result in code duplication.

What do you think?

Regards,
Simon

  reply	other threads:[~2018-11-29 20:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20181117091818.15393-1-simon.k.r.goldschmidt@gmail.com>
2018-11-17  9:18 ` [U-Boot] [PATCH v2 1/8] lib: lmb: reserving overlapping regions should fail Simon Goldschmidt
2018-11-17  9:18 ` [U-Boot] [PATCH v2 2/8] fdt: parse "reserved-memory" for memory reservation Simon Goldschmidt
2018-11-27  1:02   ` Simon Glass
2018-11-27  5:40     ` Simon Goldschmidt
2018-11-29 20:40       ` Simon Goldschmidt [this message]
2018-12-11  1:07         ` Simon Glass
2018-11-17  9:18 ` [U-Boot] [PATCH v2 3/8] lib: lmb: extend lmb for checks at load time Simon Goldschmidt
2018-11-17  9:18 ` [U-Boot] [PATCH v2 5/8] bootm: use new common function lmb_init_and_reserve Simon Goldschmidt
2018-11-27  1:02   ` Simon Glass
2018-11-17  9:18 ` [U-Boot] [PATCH v2 6/8] lmb: remove unused extern declaration Simon Goldschmidt
2018-11-17  9:18 ` [U-Boot] [PATCH v2 8/8] tftp: prevent overwriting reserved memory Simon Goldschmidt
     [not found] <20181117093430.15827-1-simon.k.r.goldschmidt@gmail.com>
2018-11-17  9:34 ` [U-Boot] [PATCH v2 2/8] fdt: parse "reserved-memory" for memory reservation Simon Goldschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dabf6082-8a7d-74bc-f420-4bf40b7c361c@gmail.com \
    --to=simon.k.r.goldschmidt@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.