From: sagi@grimberg.me (Sagi Grimberg)
Subject: [PATCH] nvme-pci: add module parameter for io queue depth
Date: Mon, 10 Jul 2017 08:54:57 +0300 [thread overview]
Message-ID: <dabfe11a-d133-4de9-4be5-b1b8e0c63e87@grimberg.me> (raw)
In-Reply-To: <20170707152948.GB14788@localhost.localdomain>
>> +static int io_queue_depth = 1024;
>> +module_param(io_queue_depth, int, 0644);
>> +MODULE_PARM_DESC(io_queue_depth, "set io queue depth");
>> +
>> static struct workqueue_struct *nvme_workq;
>>
>> struct nvme_dev;
>> @@ -1730,7 +1733,7 @@ static int nvme_pci_enable(struct nvme_dev *dev)
>>
>> cap = lo_hi_readq(dev->bar + NVME_REG_CAP);
>>
>> - dev->q_depth = min_t(int, NVME_CAP_MQES(cap) + 1, NVME_Q_DEPTH);
>> + dev->q_depth = min_t(int, NVME_CAP_MQES(cap) + 1, io_queue_depth);
>
> We need to be a little more careful about this field if users can write
> whatever they want. It's gotta be >= 2 or else trouble will occur.
Agreed, please resend the patch. Perhaps a good way is to use
module_param_cb() to verify the input value is >= 2?
next prev parent reply other threads:[~2017-07-10 5:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-07 9:05 [PATCH] nvme-pci: add module parameter for io queue depth weiping zhang
2017-07-07 13:50 ` Christoph Hellwig
2017-07-07 14:56 ` Jens Axboe
2017-07-07 14:56 ` Jens Axboe
2017-07-07 15:29 ` Keith Busch
2017-07-07 16:53 ` weiping zhang
2017-07-10 5:54 ` Sagi Grimberg [this message]
2017-07-10 8:02 ` weiping zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dabfe11a-d133-4de9-4be5-b1b8e0c63e87@grimberg.me \
--to=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.