From: Michael Walle <michael@walle.cc>
To: Sungbo Eo <mans0n@gorani.run>
Cc: linux-mtd@lists.infradead.org,
Tudor Ambarus <tudor.ambarus@microchip.com>,
Pratyush Yadav <p.yadav@ti.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH] mtd: spi-nor: esmt: Use correct name of f25l32qa
Date: Fri, 16 Jul 2021 18:11:51 +0200 [thread overview]
Message-ID: <dad2160dba9070f1516519bdd00207ac@walle.cc> (raw)
In-Reply-To: <20210620085639.143694-1-mans0n@gorani.run>
Am 2021-06-20 10:56, schrieb Sungbo Eo:
> The flash ID of F25L32QA is 0x8c4016, whereas that of F25L32QA(2S) is
> 0x8c4116. F25L32QA(2S) is the newer version of F25L32QA and its BPn
> bits
> are non-volatile, unlike its older version.
>
> References:
> https://www.esmt.com.tw/upload/pdf/ESMT/datasheets/F25L32QA.pdf
> References:
> https://www.esmt.com.tw/upload/pdf/ESMT/datasheets/F25L32QA_1(2S).pdf
"Datasheet:" please
> Signed-off-by: Sungbo Eo <mans0n@gorani.run>
> ---
> At first I was going to send a new support patch of F25L16PA(2S),
> but before that, I wanted to make sure if "(2s)" suffix is okay or
> unnecessary.
> ---
> drivers/mtd/spi-nor/esmt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/spi-nor/esmt.c b/drivers/mtd/spi-nor/esmt.c
> index cfc9218c1053..51b3ff764ef6 100644
> --- a/drivers/mtd/spi-nor/esmt.c
> +++ b/drivers/mtd/spi-nor/esmt.c
> @@ -12,8 +12,8 @@ static const struct flash_info esmt_parts[] = {
> /* ESMT */
> { "f25l32pa", INFO(0x8c2016, 0, 64 * 1024, 64,
> SECT_4K | SPI_NOR_HAS_LOCK | SPI_NOR_SWP_IS_VOLATILE) },
> - { "f25l32qa", INFO(0x8c4116, 0, 64 * 1024, 64,
> - SECT_4K | SPI_NOR_HAS_LOCK) },
> + { "f25l32qa(2s)", INFO(0x8c4116, 0, 64 * 1024, 64,
> + SECT_4K | SPI_NOR_HAS_LOCK) },
> { "f25l64qa", INFO(0x8c4117, 0, 64 * 1024, 128,
> SECT_4K | SPI_NOR_HAS_LOCK) },
> };
Tudor has decide on that name - or the use of parentheses. I don't have
a
strong opinion on it.
FWIW,
Reviewed-by: Michael Walle <michael@walle.cc>
-michael
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2021-07-16 16:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-20 8:56 [PATCH] mtd: spi-nor: esmt: Use correct name of f25l32qa Sungbo Eo
2021-07-16 16:11 ` Michael Walle [this message]
2021-07-19 15:19 ` Sungbo Eo
2021-07-21 7:32 ` Michael Walle
2021-07-23 14:10 ` Sungbo Eo
2021-07-19 15:20 ` [PATCH v2] " Sungbo Eo
2021-07-23 14:12 ` [PATCH v3] " Sungbo Eo
2022-07-19 10:11 ` Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dad2160dba9070f1516519bdd00207ac@walle.cc \
--to=michael@walle.cc \
--cc=linux-mtd@lists.infradead.org \
--cc=mans0n@gorani.run \
--cc=miquel.raynal@bootlin.com \
--cc=p.yadav@ti.com \
--cc=richard@nod.at \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.