From: Reinette Chatre <reinette.chatre@intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: tglx@linutronix.de, fenghua.yu@intel.com, tony.luck@intel.com,
mingo@redhat.com, acme@kernel.org, gavin.hindman@intel.com,
jithu.joseph@intel.com, dave.hansen@intel.com, hpa@zytor.com,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 5/6] x86/intel_rdt: Use perf infrastructure for measurements
Date: Mon, 17 Sep 2018 09:54:14 -0700 [thread overview]
Message-ID: <daeb5e60-de3e-4f08-0e06-25ab83bbe2fe@intel.com> (raw)
In-Reply-To: <20180917085848.GQ24124@hirez.programming.kicks-ass.net>
Hi Peter,
On 9/17/2018 1:58 AM, Peter Zijlstra wrote:
> On Tue, Sep 11, 2018 at 10:14:36AM -0700, Reinette Chatre wrote:
>> +static int measure_l2_residency(void *_plr)
>> +{
>
>> + measure_residency_fn(&perf_miss_attr, &perf_hit_attr, plr, &counts);
>
>> +}
>> +
>> +static int measure_l3_residency(void *_plr)
>> +{
>
>> + measure_residency_fn(&perf_miss_attr, &perf_hit_attr, plr, &counts);
>
> Not sure it's important, but both sites loose the error return.
>
measure_l2_residency() as well as measure_l3_residency() are thread
functions so this error does not propagate directly to the caller.
Even so, by not exiting the thread here if measure_residency_fn() fails
the tracepoints will be written with zeroes. If we exited here the
tracepoints will not be written and the trace buffer will be empty when
the user searches for the measurement data. Do you perhaps have an
inclination to which a user would prefer?
Reinette
next prev parent reply other threads:[~2018-09-17 16:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 17:14 [PATCH V3 0/6] perf/core and x86/intel_rdt: Fix lack of coordination with perf Reinette Chatre
2018-09-11 17:14 ` [PATCH V3 1/6] perf/core: Add sanity check to deal with pinned event failure Reinette Chatre
2018-09-11 17:14 ` [PATCH V3 2/6] perf/core: Add helper to obtain performance counter index Reinette Chatre
2018-09-17 8:23 ` Peter Zijlstra
2018-09-17 16:37 ` Reinette Chatre
2018-09-17 23:07 ` Peter Zijlstra
2018-09-18 17:54 ` Reinette Chatre
2018-09-19 9:17 ` Peter Zijlstra
2018-09-11 17:14 ` [PATCH V3 3/6] x86/intel_rdt: Remove local register variables Reinette Chatre
2018-09-11 17:14 ` [PATCH V3 4/6] x86/intel_rdt: Create required perf event attributes Reinette Chatre
2018-09-12 5:49 ` kbuild test robot
2018-09-12 7:20 ` kbuild test robot
2018-09-12 19:54 ` [PATCH V4 " Reinette Chatre
2018-09-11 17:14 ` [PATCH V3 5/6] x86/intel_rdt: Use perf infrastructure for measurements Reinette Chatre
2018-09-17 8:58 ` Peter Zijlstra
2018-09-17 16:54 ` Reinette Chatre [this message]
2018-09-11 17:14 ` [PATCH V3 6/6] x86/intel_rdt: Re-enable pseudo-lock measurements Reinette Chatre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=daeb5e60-de3e-4f08-0e06-25ab83bbe2fe@intel.com \
--to=reinette.chatre@intel.com \
--cc=acme@kernel.org \
--cc=dave.hansen@intel.com \
--cc=fenghua.yu@intel.com \
--cc=gavin.hindman@intel.com \
--cc=hpa@zytor.com \
--cc=jithu.joseph@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.