From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [PATCH v13 4/9] x86: add multiboot2 protocol support for EFI platforms Date: Wed, 25 Jan 2017 16:20:30 -0600 Message-ID: References: <1485382293-13800-1-git-send-email-daniel.kiper@oracle.com> <1485382293-13800-5-git-send-email-daniel.kiper@oracle.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1355881157381436327==" Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cWVvj-0004Vn-9o for xen-devel@lists.xenproject.org; Wed, 25 Jan 2017 22:20:39 +0000 Received: by mail-it0-f66.google.com with SMTP id 203so3485969ith.2 for ; Wed, 25 Jan 2017 14:20:37 -0800 (PST) In-Reply-To: <1485382293-13800-5-git-send-email-daniel.kiper@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Daniel Kiper , xen-devel@lists.xenproject.org Cc: jgross@suse.com, sstabellini@kernel.org, andrew.cooper3@citrix.com, pgnet.dev@gmail.com, ning.sun@intel.com, julien.grall@arm.com, jbeulich@suse.com, qiaowei.ren@intel.com, gang.wei@intel.com, fu.wei@linaro.org List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============1355881157381436327== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Xl7QWeoNtbX8sEdhJ9VSQi61dpIEs4jIP" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Xl7QWeoNtbX8sEdhJ9VSQi61dpIEs4jIP Content-Type: multipart/mixed; boundary="mhpQO8dpgO0EWNfgudxr1esKMAsBI7s4p"; protected-headers="v1" From: Doug Goldstein To: Daniel Kiper , xen-devel@lists.xenproject.org Cc: andrew.cooper3@citrix.com, fu.wei@linaro.org, gang.wei@intel.com, jbeulich@suse.com, jgross@suse.com, julien.grall@arm.com, konrad.wilk@oracle.com, ning.sun@intel.com, pgnet.dev@gmail.com, qiaowei.ren@intel.com, sstabellini@kernel.org Message-ID: Subject: Re: [PATCH v13 4/9] x86: add multiboot2 protocol support for EFI platforms References: <1485382293-13800-1-git-send-email-daniel.kiper@oracle.com> <1485382293-13800-5-git-send-email-daniel.kiper@oracle.com> In-Reply-To: <1485382293-13800-5-git-send-email-daniel.kiper@oracle.com> --mhpQO8dpgO0EWNfgudxr1esKMAsBI7s4p Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 1/25/17 4:11 PM, Daniel Kiper wrote: > This way Xen can be loaded on EFI platforms using GRUB2 and > other boot loaders which support multiboot2 protocol. >=20 > Signed-off-by: Daniel Kiper > --- > v13 - suggestions/fixes: > - move vga_text_buffer and efi_platform to .init.data section > (suggested by Jan Beulich), > - reduce number of error branches in EFI code in xen/arch/x86/boot/= head.S > (suggested by Jan Beulich), > - rename run_bs label to .Lrun_bs > (suggested by Jan Beulich), > - align the stack as UEFI spec requires > (suggested by Jan Beulich), > - change trampoline region memory layout > (suggested by Jan Beulich), > - revert changes in efi_arch_pre_exit_boot() > (suggested by Jan Beulich), > - relocate_trampoline() must set trampoline_phys for all bootloader= s; > otherwise fallback allocator is always used if Xen was loaded wit= h > Multiboot2 protocol, > - change err type in efi_multiboot2() to "static const CHAR16 __ini= tconst" > (suggested by Jan Beulich), > - change asm "g" constraint to "rm" in efi_multiboot2() > (suggested by Jan Beulich), > - improve comments > (suggested by Jan Beulich and Doug Goldstein). This is a huge change and would really be helpful to have the diff of what's changed to work from. --=20 Doug Goldstein --mhpQO8dpgO0EWNfgudxr1esKMAsBI7s4p-- --Xl7QWeoNtbX8sEdhJ9VSQi61dpIEs4jIP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJYiSSxXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvUF40P/1nraxC4SuC3PA/s9/jpWjfs UB+AkoZ8y/QtcV9GQmatSztMKWdy4wqWJSgT6sq8b4NwVBpUbFmIWXqzXX/9pOMA 0R1VY8/glhP5Olt3NBAx+yRyvkg3/2Cfyzuj3aTsOgxbv5aOj2jERtXQrTn/WJSp KV0x2LHS6YphksY6SdAaCgawCMzbGXuqhA9yLedwdo07+rjb05tjtB+pW9C9bJJd U2fKTmoiH41a9G/iRZtkQC9sFcp0wDxhKDb+EEOhtkfKFxbV2FOjj5Pep4YEL7Um zODYMvOC/e5+2lccgfC0MG3KCzbjTuMzaE3xXEG6/jd1DHX/yxHyv0lf85luYPDe FloYarUG12RjXIyzNxBb4LXsdt5OSGoufl2l+NVUNUk4iV/yNoF4ywEh5KxpblB7 hWFbJuMeNrtfDRd2sgxLV43LrzA2AnvGplwP5wLsngoQWDpSX3wdEaXhIJMIUsen D65Ysh8XvCWuP9dxqSuNE0Ag7HL3/NT4hgsWriooVYNbagetoCl3JtD5EWYsCs9W eNDHxKth3Rt+Ygt/WPvBxm0lcJw4m3VmXVkSqiK+xOaMwWk9dHrjGJBFpZ4krX95 FiI0+A+CKZ2Gjv5NMwDn1La0v9oy7cURuZIqXrBaBWBYnaV/QFN1F3Y5dqFjMD4P vVlPnjU9GNZfyZTBKig1 =jHBe -----END PGP SIGNATURE----- --Xl7QWeoNtbX8sEdhJ9VSQi61dpIEs4jIP-- --===============1355881157381436327== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============1355881157381436327==--