* [Qemu-devel] [PATCH] hw/input/tsc210x: Fix building with no verbosity
@ 2019-02-04 20:45 Philippe Mathieu-Daudé
2019-02-04 20:49 ` no-reply
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-02-04 20:45 UTC (permalink / raw)
To: qemu-trivial, qemu-devel
Cc: Peter Maydell, qemu-arm, Andrzej Zaborowski, Philippe Mathieu-Daudé
When building with TSC_VERBOSE not defined, we get:
CC arm-softmmu/hw/input/tsc210x.o
hw/input/tsc210x.c: In function ‘tsc2102_data_register_write’:
hw/input/tsc210x.c:554:5: error: label at end of compound statement
default:
^~~~~~~
hw/input/tsc210x.c: In function ‘tsc2102_control_register_write’:
hw/input/tsc210x.c:638:5: error: label at end of compound statement
bad_reg:
^~~~~~~
hw/input/tsc210x.c: In function ‘tsc2102_audio_register_write’:
hw/input/tsc210x.c:766:5: error: label at end of compound statement
default:
^~~~~~~
make[1]: *** [rules.mak:69: hw/input/tsc210x.o] Error 1
Fix this by replacing the culprit fprintf(stderr) calls by a more
recent API: qemu_log_mask(LOG_GUEST_ERROR). Other fprintf() calls
are left untouched.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/input/tsc210x.c | 18 ++++++------------
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/hw/input/tsc210x.c b/hw/input/tsc210x.c
index ded0db9351..2eb3cb9518 100644
--- a/hw/input/tsc210x.c
+++ b/hw/input/tsc210x.c
@@ -552,10 +552,8 @@ static void tsc2102_data_register_write(
return;
default:
-#ifdef TSC_VERBOSE
- fprintf(stderr, "tsc2102_data_register_write: "
- "no such register: 0x%02x\n", reg);
-#endif
+ qemu_log_mask(LOG_GUEST_ERROR, "tsc2102_data_register_write: "
+ "no such register: 0x%02x\n", reg);
}
}
@@ -636,10 +634,8 @@ static void tsc2102_control_register_write(
default:
bad_reg:
-#ifdef TSC_VERBOSE
- fprintf(stderr, "tsc2102_control_register_write: "
- "no such register: 0x%02x\n", reg);
-#endif
+ qemu_log_mask(LOG_GUEST_ERROR, "tsc2102_control_register_write: "
+ "no such register: 0x%02x\n", reg);
}
}
@@ -764,10 +760,8 @@ static void tsc2102_audio_register_write(
return;
default:
-#ifdef TSC_VERBOSE
- fprintf(stderr, "tsc2102_audio_register_write: "
- "no such register: 0x%02x\n", reg);
-#endif
+ qemu_log_mask(LOG_GUEST_ERROR, "tsc2102_audio_register_write: "
+ "no such register: 0x%02x\n", reg);
}
}
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/input/tsc210x: Fix building with no verbosity
2019-02-04 20:45 [Qemu-devel] [PATCH] hw/input/tsc210x: Fix building with no verbosity Philippe Mathieu-Daudé
@ 2019-02-04 20:49 ` no-reply
2019-02-04 23:32 ` Philippe Mathieu-Daudé
2019-02-05 3:25 ` Thomas Huth
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: no-reply @ 2019-02-04 20:49 UTC (permalink / raw)
To: philmd; +Cc: fam, qemu-trivial, qemu-devel, peter.maydell, qemu-arm
Patchew URL: https://patchew.org/QEMU/20190204204517.23698-1-philmd@redhat.com/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
time make docker-test-mingw@fedora SHOW_ENV=1 J=14
=== TEST SCRIPT END ===
The full log is available at
http://patchew.org/logs/20190204204517.23698-1-philmd@redhat.com/testing.docker-mingw@fedora/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/input/tsc210x: Fix building with no verbosity
2019-02-04 20:49 ` no-reply
@ 2019-02-04 23:32 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 6+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-02-04 23:32 UTC (permalink / raw)
To: qemu-devel, Paolo Bonzini
Cc: fam, qemu-trivial, peter.maydell, qemu-arm, patchew-devel
On 2/4/19 9:49 PM, no-reply@patchew.org wrote:
> Patchew URL: https://patchew.org/QEMU/20190204204517.23698-1-philmd@redhat.com/
>
> This series failed the docker-mingw@fedora build test. Please find the testing commands and
> their output below. If you have Docker installed, you can probably reproduce it
> locally.
>
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> time make docker-test-mingw@fedora SHOW_ENV=1 J=14
> === TEST SCRIPT END ===
>
> The full log is available at
> http://patchew.org/logs/20190204204517.23698-1-philmd@redhat.com/testing.docker-mingw@fedora/?type=message.
> ---
Full log is weird:
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
>From https://github.com/patchew-project/qemu
- [tag update]
patchew/20190117215300.29694-1-brijesh.singh@amd.com ->
patchew/20190117215300.29694-1-brijesh.singh@amd.com
fatal: Unable to create
'/home/patchew/.cache/patchew-git-cache/httpsgithubcompatchewprojectqemu-3c8cf5a9c21ff8782164d1def7f44bd888713384/refs/tags/patchew/20190204204517.23698-1-philmd@redhat.com.lock':
File exists.
If no other git process is currently running, this probably means a
git process crashed in this repository earlier. Make sure no other git
process is running and remove the file manually to continue.
Unexpected end of command stream
error: Could not fetch 3c8cf5a9c21ff8782164d1def7f44bd888713384
Traceback (most recent call last):
File "patchew-tester/src/patchew-cli", line 521, in test_one
git_clone_repo(clone, r["repo"], r["head"], logf, True)
File "patchew-tester/src/patchew-cli", line 48, in git_clone_repo
stdout=logf, stderr=logf)
File "/usr/lib64/python3.4/subprocess.py", line 558, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['git', 'remote', 'add', '-f',
'--mirror=fetch', '3c8cf5a9c21ff8782164d1def7f44bd888713384',
'https://github.com/patchew-project/qemu']' returned non-zero exit status 1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/input/tsc210x: Fix building with no verbosity
2019-02-04 20:45 [Qemu-devel] [PATCH] hw/input/tsc210x: Fix building with no verbosity Philippe Mathieu-Daudé
2019-02-04 20:49 ` no-reply
@ 2019-02-05 3:25 ` Thomas Huth
2019-02-06 9:23 ` Stefano Garzarella
2019-02-06 14:57 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
3 siblings, 0 replies; 6+ messages in thread
From: Thomas Huth @ 2019-02-05 3:25 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-trivial, qemu-devel
Cc: Peter Maydell, qemu-arm
On 2019-02-04 21:45, Philippe Mathieu-Daudé wrote:
> When building with TSC_VERBOSE not defined, we get:
> CC arm-softmmu/hw/input/tsc210x.o
> hw/input/tsc210x.c: In function ‘tsc2102_data_register_write’:
> hw/input/tsc210x.c:554:5: error: label at end of compound statement
> default:
> ^~~~~~~
> hw/input/tsc210x.c: In function ‘tsc2102_control_register_write’:
> hw/input/tsc210x.c:638:5: error: label at end of compound statement
> bad_reg:
> ^~~~~~~
> hw/input/tsc210x.c: In function ‘tsc2102_audio_register_write’:
> hw/input/tsc210x.c:766:5: error: label at end of compound statement
> default:
> ^~~~~~~
> make[1]: *** [rules.mak:69: hw/input/tsc210x.o] Error 1
>
> Fix this by replacing the culprit fprintf(stderr) calls by a more
> recent API: qemu_log_mask(LOG_GUEST_ERROR). Other fprintf() calls
> are left untouched.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/input/tsc210x.c | 18 ++++++------------
> 1 file changed, 6 insertions(+), 12 deletions(-)
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/input/tsc210x: Fix building with no verbosity
2019-02-04 20:45 [Qemu-devel] [PATCH] hw/input/tsc210x: Fix building with no verbosity Philippe Mathieu-Daudé
2019-02-04 20:49 ` no-reply
2019-02-05 3:25 ` Thomas Huth
@ 2019-02-06 9:23 ` Stefano Garzarella
2019-02-06 14:57 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
3 siblings, 0 replies; 6+ messages in thread
From: Stefano Garzarella @ 2019-02-06 9:23 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: qemu-trivial, qemu-devel, Peter Maydell, qemu-arm
On Mon, Feb 04, 2019 at 09:45:17PM +0100, Philippe Mathieu-Daudé wrote:
> When building with TSC_VERBOSE not defined, we get:
> CC arm-softmmu/hw/input/tsc210x.o
> hw/input/tsc210x.c: In function ‘tsc2102_data_register_write’:
> hw/input/tsc210x.c:554:5: error: label at end of compound statement
> default:
> ^~~~~~~
> hw/input/tsc210x.c: In function ‘tsc2102_control_register_write’:
> hw/input/tsc210x.c:638:5: error: label at end of compound statement
> bad_reg:
> ^~~~~~~
> hw/input/tsc210x.c: In function ‘tsc2102_audio_register_write’:
> hw/input/tsc210x.c:766:5: error: label at end of compound statement
> default:
> ^~~~~~~
> make[1]: *** [rules.mak:69: hw/input/tsc210x.o] Error 1
>
> Fix this by replacing the culprit fprintf(stderr) calls by a more
> recent API: qemu_log_mask(LOG_GUEST_ERROR). Other fprintf() calls
> are left untouched.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/input/tsc210x.c | 18 ++++++------------
> 1 file changed, 6 insertions(+), 12 deletions(-)
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] hw/input/tsc210x: Fix building with no verbosity
2019-02-04 20:45 [Qemu-devel] [PATCH] hw/input/tsc210x: Fix building with no verbosity Philippe Mathieu-Daudé
` (2 preceding siblings ...)
2019-02-06 9:23 ` Stefano Garzarella
@ 2019-02-06 14:57 ` Laurent Vivier
3 siblings, 0 replies; 6+ messages in thread
From: Laurent Vivier @ 2019-02-06 14:57 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-trivial, qemu-devel
Cc: Peter Maydell, qemu-arm, Andrzej Zaborowski
On 04/02/2019 21:45, Philippe Mathieu-Daudé wrote:
> When building with TSC_VERBOSE not defined, we get:
> CC arm-softmmu/hw/input/tsc210x.o
> hw/input/tsc210x.c: In function ‘tsc2102_data_register_write’:
> hw/input/tsc210x.c:554:5: error: label at end of compound statement
> default:
> ^~~~~~~
> hw/input/tsc210x.c: In function ‘tsc2102_control_register_write’:
> hw/input/tsc210x.c:638:5: error: label at end of compound statement
> bad_reg:
> ^~~~~~~
> hw/input/tsc210x.c: In function ‘tsc2102_audio_register_write’:
> hw/input/tsc210x.c:766:5: error: label at end of compound statement
> default:
> ^~~~~~~
> make[1]: *** [rules.mak:69: hw/input/tsc210x.o] Error 1
>
> Fix this by replacing the culprit fprintf(stderr) calls by a more
> recent API: qemu_log_mask(LOG_GUEST_ERROR). Other fprintf() calls
> are left untouched.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/input/tsc210x.c | 18 ++++++------------
> 1 file changed, 6 insertions(+), 12 deletions(-)
>
> diff --git a/hw/input/tsc210x.c b/hw/input/tsc210x.c
> index ded0db9351..2eb3cb9518 100644
> --- a/hw/input/tsc210x.c
> +++ b/hw/input/tsc210x.c
> @@ -552,10 +552,8 @@ static void tsc2102_data_register_write(
> return;
>
> default:
> -#ifdef TSC_VERBOSE
> - fprintf(stderr, "tsc2102_data_register_write: "
> - "no such register: 0x%02x\n", reg);
> -#endif
> + qemu_log_mask(LOG_GUEST_ERROR, "tsc2102_data_register_write: "
> + "no such register: 0x%02x\n", reg);
> }
> }
>
> @@ -636,10 +634,8 @@ static void tsc2102_control_register_write(
>
> default:
> bad_reg:
> -#ifdef TSC_VERBOSE
> - fprintf(stderr, "tsc2102_control_register_write: "
> - "no such register: 0x%02x\n", reg);
> -#endif
> + qemu_log_mask(LOG_GUEST_ERROR, "tsc2102_control_register_write: "
> + "no such register: 0x%02x\n", reg);
> }
> }
>
> @@ -764,10 +760,8 @@ static void tsc2102_audio_register_write(
> return;
>
> default:
> -#ifdef TSC_VERBOSE
> - fprintf(stderr, "tsc2102_audio_register_write: "
> - "no such register: 0x%02x\n", reg);
> -#endif
> + qemu_log_mask(LOG_GUEST_ERROR, "tsc2102_audio_register_write: "
> + "no such register: 0x%02x\n", reg);
> }
> }
>
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-02-06 14:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-04 20:45 [Qemu-devel] [PATCH] hw/input/tsc210x: Fix building with no verbosity Philippe Mathieu-Daudé
2019-02-04 20:49 ` no-reply
2019-02-04 23:32 ` Philippe Mathieu-Daudé
2019-02-05 3:25 ` Thomas Huth
2019-02-06 9:23 ` Stefano Garzarella
2019-02-06 14:57 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.