From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48641) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkBs1-0004qJ-Qf for qemu-devel@nongnu.org; Wed, 14 Sep 2016 11:13:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bkBrx-00048W-Tm for qemu-devel@nongnu.org; Wed, 14 Sep 2016 11:13:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46014) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkBrx-00048G-Lx for qemu-devel@nongnu.org; Wed, 14 Sep 2016 11:13:01 -0400 References: <1473750714-48290-1-git-send-email-aik@ozlabs.ru> <20160914161724.7d3ad28b@bahia> From: Eric Blake Message-ID: Date: Wed, 14 Sep 2016 10:12:58 -0500 MIME-Version: 1.0 In-Reply-To: <20160914161724.7d3ad28b@bahia> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lDH1pD3X6jmsaFaboXSI6isw7lBauqM2n" Subject: Re: [Qemu-devel] [PATCH qemu v2] tap: Allow specifying a bridge List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Greg Kurz , Alexey Kardashevskiy Cc: Jason Wang , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --lDH1pD3X6jmsaFaboXSI6isw7lBauqM2n From: Eric Blake To: Greg Kurz , Alexey Kardashevskiy Cc: Jason Wang , qemu-devel@nongnu.org Message-ID: Subject: Re: [Qemu-devel] [PATCH qemu v2] tap: Allow specifying a bridge References: <1473750714-48290-1-git-send-email-aik@ozlabs.ru> <20160914161724.7d3ad28b@bahia> In-Reply-To: <20160914161724.7d3ad28b@bahia> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/14/2016 09:17 AM, Greg Kurz wrote: > On Tue, 13 Sep 2016 17:11:54 +1000 > Alexey Kardashevskiy wrote: >=20 >> The tap backend is already using qemu-bridge-helper to attach tap >> interface to a bridge but (unlike the bridge backend) it always uses >> the default bridge name - br0. >> >> This adds a "br" property support to the tap backend. >> >> Signed-off-by: Alexey Kardashevskiy >> -- >=20 > Cool ! This allows to easily attach to virbr0 :) >=20 > Now that a consensus seems to have been reached for @br: Yes, but there was still my other comment that: >> +++ b/qapi-schema.json >> @@ -2575,6 +2575,8 @@ >> # >> # @downscript: #optional script to shut down the interface >> # >> +# @br: #optional bridge name this is missing a '(since 2.8)' designator. Perhaps the maintainer can supply it without needing a v3. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --lDH1pD3X6jmsaFaboXSI6isw7lBauqM2n Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJX2Wj6AAoJEKeha0olJ0Nq6vYH/Rc/bostsBGeMp0tsvPjrVsh Jp9cr7ZMAjBFNtlVnbcmwLIPbLTKLQ3QunIhM0JoioRLy987PdQ1Dh/BLkXmaX6Y EzgKCJysI+whU8ICBN/bspQewmzX3R2pfaHUiB+hXOiabkRAytZYUzGfAf0XWjNO YnLsYMa5xO4gr2v3+tLnxOf0Wz/ILmLGcsLzcPE2/RejnGDMkVyyFQgmZAUZguPt KfYk9aGMuWH+2gp3iao9jNmcL2RQLDOo0DcrpvCbdCjp528lmI30ieInQ9UZObO6 J5hajAx3LGuENGp10m+NqouqQ/zfT65g+uq6ID/RnOdVJ0buyinB/3AjPyRL/20= =tTAb -----END PGP SIGNATURE----- --lDH1pD3X6jmsaFaboXSI6isw7lBauqM2n--