All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex G." <mr.nuke.me@gmail.com>
To: Angelo Dureghello <angelo.dureghello@timesys.com>,
	trini@konsulko.com, Simon Glass <sjg@chromium.org>
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH] fit: display proper node on error
Date: Wed, 6 Oct 2021 11:00:33 -0500	[thread overview]
Message-ID: <db0d7cc8-3166-de76-f076-240c1c769128@gmail.com> (raw)
In-Reply-To: <20211006154717.1130245-1-angelo.dureghello@timesys.com>

+ Simon

On 10/6/21 10:47 AM, Angelo Dureghello wrote:
> Fix final error message from
> 
> Verification failed for '<NULL>' hash node in 'conf@1' config node
> 
> to
> 
> Verification failed for 'signature@1' hash node in 'conf@1' config node
> 
> Signed-off-by: Angelo Dureghello <angelo.dureghello@timesys.com>
> ---
>   common/image-fit-sig.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/common/image-fit-sig.c b/common/image-fit-sig.c
> index b979cd2a4b..4f2a6ef214 100644
> --- a/common/image-fit-sig.c
> +++ b/common/image-fit-sig.c
> @@ -166,8 +166,8 @@ static int fit_image_verify_sig(const void *fit, int image_noffset,
>   			} else {
>   				puts("+ ");
>   				verified = 1;
> -				break;
>   			}
> +			break;

This would stop checking after the first signature- node. It seems 
counter-intuitive, as I would expect all signatures to be checked.

In my mind, the 'break;' clause should only happen when 
fit_image_check_sig() returns an error. I have no idea why it happened 
on success. Simon, any thoughts?

Alex

  reply	other threads:[~2021-10-06 16:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-06 15:47 [PATCH] fit: display proper node on error Angelo Dureghello
2021-10-06 16:00 ` Alex G. [this message]
2021-10-24 19:53   ` Simon Glass
2021-10-25 21:09     ` Angelo Dureghello
2022-03-12  2:24       ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=db0d7cc8-3166-de76-f076-240c1c769128@gmail.com \
    --to=mr.nuke.me@gmail.com \
    --cc=angelo.dureghello@timesys.com \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.