From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6858C433F5 for ; Tue, 4 Oct 2022 10:49:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229495AbiJDKtT (ORCPT ); Tue, 4 Oct 2022 06:49:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229462AbiJDKtQ (ORCPT ); Tue, 4 Oct 2022 06:49:16 -0400 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E0CC50730 for ; Tue, 4 Oct 2022 03:49:14 -0700 (PDT) Received: by mail-lj1-x236.google.com with SMTP id t16so14859861ljh.3 for ; Tue, 04 Oct 2022 03:49:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=c5k6ZNI6sRUrczxfcsYS/c25P0zEUbDCEvkzt7XYe8g=; b=G3EHcKhnNoAjSMx/ocs4bY3RbE16aUdmufD3yRS9x3AiIWwFIVmiUyH3IVcGQfEBOA SOXUyuEBtDpV89NZXv+7EWvp+cd9xsdD3xaSL0A57S0b5UUssTcLrnH/kmLHFJ60Xc7N XSjN9c2UgwOuylWXLVt5dyUsQRJVUcbWdrqKpB+VBc8MoQRapE8TS2VFk88zVXHjcx5W ThHuO2bdbBT1tx225065qEGDNcPrs/gmls6CQhP19fQ4spldz5EkBKGEBhS4kZbNfvn0 p+MgX0Mr3qJro8BJAMpJ+eC4hlNypUoBGetW4VCEaEzVZIjCq1NKFEaDWSCi8I6/7qPT afdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=c5k6ZNI6sRUrczxfcsYS/c25P0zEUbDCEvkzt7XYe8g=; b=1xGNuxDS1LM81PFx1ZjCJmK6B51t/2lPUOHNw71UCA4WbMFw4iRNDTKj7v4rCTEvAo Qxmjn2B+aSI+SFRwEwV4JzOoTeLkb/DY+dhwsUTnNolsktab5Zi8nqX5lHiwz5tMnc2u 1z5rbYDP+8xR4qSBLKYEVKKmc6GmpQSdm2fWpq80RDOp1dMM25/vZUULKuTPFt8LaU2O HZurm31RF9coytiv/ozDkbbap4QLybABDuPj1AQGV/vjB6O8LbgDqxZXsiRF5c7b/N5k PVFjV0HpRIC65bmZdZFcxQd0WsdSKrAlGMr+XZ5qzuCITiKf0LS4MZ4vVAZE+ymAlOUu O6WQ== X-Gm-Message-State: ACrzQf2olVEgFaBgmaRhhc9DaLsBwtg9kCRHa9HdmzjKs4cVRJMCEWQV neM/7YgoTZkUPKFw71YwsRfAHg== X-Google-Smtp-Source: AMsMyM46dEzBBMohqQM+6j/OIqQeD7GRLhgNru1yX5N6Xlq3dupGTB8jWnZAA/XhAo1mPgS/lyXmiQ== X-Received: by 2002:a2e:9d88:0:b0:26a:95c1:218f with SMTP id c8-20020a2e9d88000000b0026a95c1218fmr7776212ljj.223.1664880552796; Tue, 04 Oct 2022 03:49:12 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id 2-20020ac24842000000b0048b3926351bsm1869697lfy.56.2022.10.04.03.49.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Oct 2022 03:49:12 -0700 (PDT) Message-ID: Date: Tue, 4 Oct 2022 12:49:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v1 17/17] drm/mediatek: Add mt8195-dpi support to drm_drv Content-Language: en-US To: Guillaume Ranquet , Kishon Vijay Abraham I , Matthias Brugger , Vinod Koul , Stephen Boyd , David Airlie , Rob Herring , Philipp Zabel , Krzysztof Kozlowski , Daniel Vetter , Chunfeng Yun , CK Hu , Jitao shi , Chun-Kuang Hu , Michael Turquette Cc: linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, Pablo Sun , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Mattijs Korpershoek , linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org References: <20220919-v1-0-4844816c9808@baylibre.com> <20220919-v1-17-4844816c9808@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/10/2022 17:29, Guillaume Ranquet wrote: > On Tue, 27 Sep 2022 16:28, Krzysztof Kozlowski > wrote: >> On 27/09/2022 15:04, Guillaume Ranquet wrote: >>> On Thu, 22 Sep 2022 09:20, Krzysztof Kozlowski >>> wrote: >>>> On 19/09/2022 18:56, Guillaume Ranquet wrote: >>>>> Add dpi support to enable the HDMI path. >>>>> >>>>> Signed-off-by: Guillaume Ranquet >>>>> >>>>> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c >>>>> index 72049a530ae1..27f029ca760b 100644 >>>>> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c >>>>> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c >>>>> @@ -820,6 +820,8 @@ static const struct of_device_id mtk_ddp_comp_dt_ids[] = { >>>>> .data = (void *)MTK_DPI }, >>>>> { .compatible = "mediatek,mt8192-dpi", >>>>> .data = (void *)MTK_DPI }, >>>>> + { .compatible = "mediatek,mt8195-dpi", >>>>> + .data = (void *)MTK_DPI }, >>>> >>>> It's compatible with the others. You don't need more compatibles. >>> >>> Hi Krzysztof, >>> >>> It's a bit confusing, because this compatible is used in both >>> mtk_drm_drv.c and in mtk_dpi.c >>> >>> Albeit it's entirely the same thing regarding the mtk_drm_drv module, >>> it's pretty different >>> regarding the mtk_dpi module. >> >> Sure, but this does not explain why do you need these entries here in >> mtk_drm_drv. >> >> Best regards, >> Krzysztof >> > > Hi Krzysztof, > > Sorry for the late answer. > The mtk_drm_drv is the component master of the full mediatek drm stack. > > it "binds" all of the crtc/dpi/ovl/mutex/merge... components of the stack. > > That mtk_ddp_comp_dt_ids array is iterated over to find all of the components > from the device tree. No. You said what the code is doing. I think I understand this. You still do not need more compatibles. Your sentence did not clarify it because it did not answer at all to question "why". Why do you need it? Sorry, the change looks not correct. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69DA3C433FE for ; Tue, 4 Oct 2022 10:49:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B3B4710E53D; Tue, 4 Oct 2022 10:49:17 +0000 (UTC) Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by gabe.freedesktop.org (Postfix) with ESMTPS id 765F210E53D for ; Tue, 4 Oct 2022 10:49:14 +0000 (UTC) Received: by mail-lj1-x230.google.com with SMTP id q17so14840237lji.11 for ; Tue, 04 Oct 2022 03:49:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=c5k6ZNI6sRUrczxfcsYS/c25P0zEUbDCEvkzt7XYe8g=; b=G3EHcKhnNoAjSMx/ocs4bY3RbE16aUdmufD3yRS9x3AiIWwFIVmiUyH3IVcGQfEBOA SOXUyuEBtDpV89NZXv+7EWvp+cd9xsdD3xaSL0A57S0b5UUssTcLrnH/kmLHFJ60Xc7N XSjN9c2UgwOuylWXLVt5dyUsQRJVUcbWdrqKpB+VBc8MoQRapE8TS2VFk88zVXHjcx5W ThHuO2bdbBT1tx225065qEGDNcPrs/gmls6CQhP19fQ4spldz5EkBKGEBhS4kZbNfvn0 p+MgX0Mr3qJro8BJAMpJ+eC4hlNypUoBGetW4VCEaEzVZIjCq1NKFEaDWSCi8I6/7qPT afdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=c5k6ZNI6sRUrczxfcsYS/c25P0zEUbDCEvkzt7XYe8g=; b=NnQxxH7dH2DPlLmLMPNm5B2ChkyFzslYlgRYhiB8Zl14jBBdp4V/bgC11j18KPVVpI FhDhiDUZGiaWrHeg9jWb9plI8/IYkx72QYub25QP8xEjgAWv6ANtRT9Ksxaz538scSRX Rd+5MYFfpSVW2/TRjgYjVgH8/37Dp8MHJ2/ACmoxMVYvJNGDupR6N5wOm7orY3vudjcC VKm2hzTbMS7qxahdWR2fjcRL+9/lTsbKql2hhyD3b1ftufn1hwKTQfGtwiNe8Diz+8H1 mMr+2wGqsaL6MFjupN6dyv4GgR5vh6ae5+hYF6y1LbZ7TndXdPA+q1NTHjmf6O2Y1mkp SFgA== X-Gm-Message-State: ACrzQf0C6eYPdGaqnJEZ2NNnjBSj43iuu6neBN7RVL5exJjTSkvJzyns Bhlv4apzT/Bwu5iEWRjrnyHNPg== X-Google-Smtp-Source: AMsMyM46dEzBBMohqQM+6j/OIqQeD7GRLhgNru1yX5N6Xlq3dupGTB8jWnZAA/XhAo1mPgS/lyXmiQ== X-Received: by 2002:a2e:9d88:0:b0:26a:95c1:218f with SMTP id c8-20020a2e9d88000000b0026a95c1218fmr7776212ljj.223.1664880552796; Tue, 04 Oct 2022 03:49:12 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id 2-20020ac24842000000b0048b3926351bsm1869697lfy.56.2022.10.04.03.49.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Oct 2022 03:49:12 -0700 (PDT) Message-ID: Date: Tue, 4 Oct 2022 12:49:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v1 17/17] drm/mediatek: Add mt8195-dpi support to drm_drv Content-Language: en-US To: Guillaume Ranquet , Kishon Vijay Abraham I , Matthias Brugger , Vinod Koul , Stephen Boyd , David Airlie , Rob Herring , Philipp Zabel , Krzysztof Kozlowski , Daniel Vetter , Chunfeng Yun , CK Hu , Jitao shi , Chun-Kuang Hu , Michael Turquette References: <20220919-v1-0-4844816c9808@baylibre.com> <20220919-v1-17-4844816c9808@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Mattijs Korpershoek , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-clk@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, Pablo Sun , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 03/10/2022 17:29, Guillaume Ranquet wrote: > On Tue, 27 Sep 2022 16:28, Krzysztof Kozlowski > wrote: >> On 27/09/2022 15:04, Guillaume Ranquet wrote: >>> On Thu, 22 Sep 2022 09:20, Krzysztof Kozlowski >>> wrote: >>>> On 19/09/2022 18:56, Guillaume Ranquet wrote: >>>>> Add dpi support to enable the HDMI path. >>>>> >>>>> Signed-off-by: Guillaume Ranquet >>>>> >>>>> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c >>>>> index 72049a530ae1..27f029ca760b 100644 >>>>> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c >>>>> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c >>>>> @@ -820,6 +820,8 @@ static const struct of_device_id mtk_ddp_comp_dt_ids[] = { >>>>> .data = (void *)MTK_DPI }, >>>>> { .compatible = "mediatek,mt8192-dpi", >>>>> .data = (void *)MTK_DPI }, >>>>> + { .compatible = "mediatek,mt8195-dpi", >>>>> + .data = (void *)MTK_DPI }, >>>> >>>> It's compatible with the others. You don't need more compatibles. >>> >>> Hi Krzysztof, >>> >>> It's a bit confusing, because this compatible is used in both >>> mtk_drm_drv.c and in mtk_dpi.c >>> >>> Albeit it's entirely the same thing regarding the mtk_drm_drv module, >>> it's pretty different >>> regarding the mtk_dpi module. >> >> Sure, but this does not explain why do you need these entries here in >> mtk_drm_drv. >> >> Best regards, >> Krzysztof >> > > Hi Krzysztof, > > Sorry for the late answer. > The mtk_drm_drv is the component master of the full mediatek drm stack. > > it "binds" all of the crtc/dpi/ovl/mutex/merge... components of the stack. > > That mtk_ddp_comp_dt_ids array is iterated over to find all of the components > from the device tree. No. You said what the code is doing. I think I understand this. You still do not need more compatibles. Your sentence did not clarify it because it did not answer at all to question "why". Why do you need it? Sorry, the change looks not correct. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8AA16C433FE for ; Tue, 4 Oct 2022 10:49:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CmS4tWQ8fGRi24ifkUJmVQxnfCuBHrdNQiTpLF+5VEk=; b=Xjaj1T8XAzeo7r 6kMlRD33LsuRP7nM6nJuE9uz1ZFlGnY3HieSd/o936U4gM1VYcWxxHqBSrYZcTu6UX8ycQRoVua24 vdYScXAkE3A/FzblPAu+RJurFMlHHe3gEW/BBht0q6RQAchFtR+YwjFZv/cuwsGwdJWwmbiIOiA8n Nu2CtOkfKiKP6LJlr8Hi12Su/IHI7vxeALxCTXth06gr+MnJFF/e3bQvS0TKAWPOUsism/9Pt/Zfm OOu6/0Hzp+JoflTM3lf1G9DbCSoxmFMcevsDLIN3Pv5kZo+X1hmKaoNvrfoMwMt//RiREUuH4Uc4q 1ETAHGe8LkUZKnur4Mqw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1offUN-009Pou-VP; Tue, 04 Oct 2022 10:49:27 +0000 Received: from mail-lj1-x233.google.com ([2a00:1450:4864:20::233]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1offUB-009PkA-Aj for linux-phy@lists.infradead.org; Tue, 04 Oct 2022 10:49:16 +0000 Received: by mail-lj1-x233.google.com with SMTP id q16so729825ljh.4 for ; Tue, 04 Oct 2022 03:49:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=c5k6ZNI6sRUrczxfcsYS/c25P0zEUbDCEvkzt7XYe8g=; b=G3EHcKhnNoAjSMx/ocs4bY3RbE16aUdmufD3yRS9x3AiIWwFIVmiUyH3IVcGQfEBOA SOXUyuEBtDpV89NZXv+7EWvp+cd9xsdD3xaSL0A57S0b5UUssTcLrnH/kmLHFJ60Xc7N XSjN9c2UgwOuylWXLVt5dyUsQRJVUcbWdrqKpB+VBc8MoQRapE8TS2VFk88zVXHjcx5W ThHuO2bdbBT1tx225065qEGDNcPrs/gmls6CQhP19fQ4spldz5EkBKGEBhS4kZbNfvn0 p+MgX0Mr3qJro8BJAMpJ+eC4hlNypUoBGetW4VCEaEzVZIjCq1NKFEaDWSCi8I6/7qPT afdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=c5k6ZNI6sRUrczxfcsYS/c25P0zEUbDCEvkzt7XYe8g=; b=vZXpxgk2C3u5PFvN03V0ldiEMmx3OoQqfByFuFWbaqyreXyF5YpKgp5M8CF7HFStK5 CpSPzI2ESmi74mOM3ffkOXgln2WexvolhUQg5SmDmccXskFLLGaIoIROhPEmrB1WiNhH /3e0jOYBdk/veQ3YQNmxFYGDEcD4xuF/vQk3/urHZh7owv3wyxIQDKNZuMJnhwCxL9nm aTpvHcPtiAjLNxyzvegN996p+nM3l9mUzXzum0POJRtL/TG1zZUJ41YBGWxr6EbIvzMB Rj6FM90Ec6Jx62gP1a6SEiWbjPMgFMBiHBLOFGpbOAE6vbTEpCekhJIA2jDMX87FptkS 3syQ== X-Gm-Message-State: ACrzQf21NiXY4ZqgaztiW90pWI5BeVxpCceIjRvnkqxmbo+vTL+4QvLi UdgbpwD1Eawf4Rj51IdQRRf/9w== X-Google-Smtp-Source: AMsMyM46dEzBBMohqQM+6j/OIqQeD7GRLhgNru1yX5N6Xlq3dupGTB8jWnZAA/XhAo1mPgS/lyXmiQ== X-Received: by 2002:a2e:9d88:0:b0:26a:95c1:218f with SMTP id c8-20020a2e9d88000000b0026a95c1218fmr7776212ljj.223.1664880552796; Tue, 04 Oct 2022 03:49:12 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id 2-20020ac24842000000b0048b3926351bsm1869697lfy.56.2022.10.04.03.49.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Oct 2022 03:49:12 -0700 (PDT) Message-ID: Date: Tue, 4 Oct 2022 12:49:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v1 17/17] drm/mediatek: Add mt8195-dpi support to drm_drv Content-Language: en-US To: Guillaume Ranquet , Kishon Vijay Abraham I , Matthias Brugger , Vinod Koul , Stephen Boyd , David Airlie , Rob Herring , Philipp Zabel , Krzysztof Kozlowski , Daniel Vetter , Chunfeng Yun , CK Hu , Jitao shi , Chun-Kuang Hu , Michael Turquette Cc: linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, Pablo Sun , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Mattijs Korpershoek , linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org References: <20220919-v1-0-4844816c9808@baylibre.com> <20220919-v1-17-4844816c9808@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221004_034915_382052_3F28AC44 X-CRM114-Status: GOOD ( 19.24 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On 03/10/2022 17:29, Guillaume Ranquet wrote: > On Tue, 27 Sep 2022 16:28, Krzysztof Kozlowski > wrote: >> On 27/09/2022 15:04, Guillaume Ranquet wrote: >>> On Thu, 22 Sep 2022 09:20, Krzysztof Kozlowski >>> wrote: >>>> On 19/09/2022 18:56, Guillaume Ranquet wrote: >>>>> Add dpi support to enable the HDMI path. >>>>> >>>>> Signed-off-by: Guillaume Ranquet >>>>> >>>>> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c >>>>> index 72049a530ae1..27f029ca760b 100644 >>>>> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c >>>>> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c >>>>> @@ -820,6 +820,8 @@ static const struct of_device_id mtk_ddp_comp_dt_ids[] = { >>>>> .data = (void *)MTK_DPI }, >>>>> { .compatible = "mediatek,mt8192-dpi", >>>>> .data = (void *)MTK_DPI }, >>>>> + { .compatible = "mediatek,mt8195-dpi", >>>>> + .data = (void *)MTK_DPI }, >>>> >>>> It's compatible with the others. You don't need more compatibles. >>> >>> Hi Krzysztof, >>> >>> It's a bit confusing, because this compatible is used in both >>> mtk_drm_drv.c and in mtk_dpi.c >>> >>> Albeit it's entirely the same thing regarding the mtk_drm_drv module, >>> it's pretty different >>> regarding the mtk_dpi module. >> >> Sure, but this does not explain why do you need these entries here in >> mtk_drm_drv. >> >> Best regards, >> Krzysztof >> > > Hi Krzysztof, > > Sorry for the late answer. > The mtk_drm_drv is the component master of the full mediatek drm stack. > > it "binds" all of the crtc/dpi/ovl/mutex/merge... components of the stack. > > That mtk_ddp_comp_dt_ids array is iterated over to find all of the components > from the device tree. No. You said what the code is doing. I think I understand this. You still do not need more compatibles. Your sentence did not clarify it because it did not answer at all to question "why". Why do you need it? Sorry, the change looks not correct. Best regards, Krzysztof -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D696CC433F5 for ; Tue, 4 Oct 2022 10:50:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cqyXdWkzfDohcP23xPgGjVMFgPYw4gJ/M/+0jlvDBWc=; b=zfTWavNCDNLns6 LmFCEyKSjRrymLwmTPVTz/fOUXjpizycnfC1i+v9HQzeHgF71pFfl7lk4AXBZ/ch2BuEw8yqF+D6L fh2Gp3v9JRkFcFXHyxtQ+KYD2MGgjrT3BKHX35WGMbJ9kfezNc9c10rWsLUNvshciufK54oUvtR5+ 6iSNnhA3aDVoDdokT4SDjdTOxGnbhBGbpRlBnzxpTEBqxsEfXpatQ4VjTF7KIBrrFeFudT7sziUCR h4/ZRGLar86Z6xDa6tKuvsepx9z0g90sefoNu0prEGr5WZuvvPjAqA0eaAtfXt9q9JeMW1yuvoOfi aLmgEbQr1xfjyhJKJJHQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1offUE-009Plr-Rf; Tue, 04 Oct 2022 10:49:18 +0000 Received: from mail-lj1-x22a.google.com ([2a00:1450:4864:20::22a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1offUA-009Pk7-Mj for linux-arm-kernel@lists.infradead.org; Tue, 04 Oct 2022 10:49:16 +0000 Received: by mail-lj1-x22a.google.com with SMTP id bs18so13254979ljb.1 for ; Tue, 04 Oct 2022 03:49:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=c5k6ZNI6sRUrczxfcsYS/c25P0zEUbDCEvkzt7XYe8g=; b=G3EHcKhnNoAjSMx/ocs4bY3RbE16aUdmufD3yRS9x3AiIWwFIVmiUyH3IVcGQfEBOA SOXUyuEBtDpV89NZXv+7EWvp+cd9xsdD3xaSL0A57S0b5UUssTcLrnH/kmLHFJ60Xc7N XSjN9c2UgwOuylWXLVt5dyUsQRJVUcbWdrqKpB+VBc8MoQRapE8TS2VFk88zVXHjcx5W ThHuO2bdbBT1tx225065qEGDNcPrs/gmls6CQhP19fQ4spldz5EkBKGEBhS4kZbNfvn0 p+MgX0Mr3qJro8BJAMpJ+eC4hlNypUoBGetW4VCEaEzVZIjCq1NKFEaDWSCi8I6/7qPT afdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=c5k6ZNI6sRUrczxfcsYS/c25P0zEUbDCEvkzt7XYe8g=; b=vxNA/mO36L2KL4B1dN/5qFqKaDVIexESMVHL4/E/15AtR/K0vGIhBK6tIhpxmeRDkF 3eFSJ44UwyoP5G4ZJH3HEvW/mvTXZmprxrRS+wm91Zq/v4QiOz0jyxHY3MFAp9OoodpV iGZRZqGZA3JZpEPe5BoI1AWen+/KG3bQT8BhErVLHRlLx8xWikD95t8nendpSlS4I2/p vQ1a7YLo5YJltHbbzZHm4AVgLJbE5tRssvC1o7n1+sJuK2liPX1DBmQgFayGMMOuwd3p XdQBQACu3KFr0lMN+tLmacoRL0KMQXGPFp8RQPUF5xvpop3yoETfetFFgx0m5nWTNrvy vS0g== X-Gm-Message-State: ACrzQf0hohBX6MbO3PiYj+38ZKyfTiloE2EZAuBF8gd/qFiOFCQzryzd RsKzVp6kOrqsdVwp79rHUaCi8w== X-Google-Smtp-Source: AMsMyM46dEzBBMohqQM+6j/OIqQeD7GRLhgNru1yX5N6Xlq3dupGTB8jWnZAA/XhAo1mPgS/lyXmiQ== X-Received: by 2002:a2e:9d88:0:b0:26a:95c1:218f with SMTP id c8-20020a2e9d88000000b0026a95c1218fmr7776212ljj.223.1664880552796; Tue, 04 Oct 2022 03:49:12 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id 2-20020ac24842000000b0048b3926351bsm1869697lfy.56.2022.10.04.03.49.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Oct 2022 03:49:12 -0700 (PDT) Message-ID: Date: Tue, 4 Oct 2022 12:49:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v1 17/17] drm/mediatek: Add mt8195-dpi support to drm_drv Content-Language: en-US To: Guillaume Ranquet , Kishon Vijay Abraham I , Matthias Brugger , Vinod Koul , Stephen Boyd , David Airlie , Rob Herring , Philipp Zabel , Krzysztof Kozlowski , Daniel Vetter , Chunfeng Yun , CK Hu , Jitao shi , Chun-Kuang Hu , Michael Turquette Cc: linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, Pablo Sun , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Mattijs Korpershoek , linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org References: <20220919-v1-0-4844816c9808@baylibre.com> <20220919-v1-17-4844816c9808@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221004_034914_778261_D5687362 X-CRM114-Status: GOOD ( 20.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 03/10/2022 17:29, Guillaume Ranquet wrote: > On Tue, 27 Sep 2022 16:28, Krzysztof Kozlowski > wrote: >> On 27/09/2022 15:04, Guillaume Ranquet wrote: >>> On Thu, 22 Sep 2022 09:20, Krzysztof Kozlowski >>> wrote: >>>> On 19/09/2022 18:56, Guillaume Ranquet wrote: >>>>> Add dpi support to enable the HDMI path. >>>>> >>>>> Signed-off-by: Guillaume Ranquet >>>>> >>>>> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c >>>>> index 72049a530ae1..27f029ca760b 100644 >>>>> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c >>>>> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c >>>>> @@ -820,6 +820,8 @@ static const struct of_device_id mtk_ddp_comp_dt_ids[] = { >>>>> .data = (void *)MTK_DPI }, >>>>> { .compatible = "mediatek,mt8192-dpi", >>>>> .data = (void *)MTK_DPI }, >>>>> + { .compatible = "mediatek,mt8195-dpi", >>>>> + .data = (void *)MTK_DPI }, >>>> >>>> It's compatible with the others. You don't need more compatibles. >>> >>> Hi Krzysztof, >>> >>> It's a bit confusing, because this compatible is used in both >>> mtk_drm_drv.c and in mtk_dpi.c >>> >>> Albeit it's entirely the same thing regarding the mtk_drm_drv module, >>> it's pretty different >>> regarding the mtk_dpi module. >> >> Sure, but this does not explain why do you need these entries here in >> mtk_drm_drv. >> >> Best regards, >> Krzysztof >> > > Hi Krzysztof, > > Sorry for the late answer. > The mtk_drm_drv is the component master of the full mediatek drm stack. > > it "binds" all of the crtc/dpi/ovl/mutex/merge... components of the stack. > > That mtk_ddp_comp_dt_ids array is iterated over to find all of the components > from the device tree. No. You said what the code is doing. I think I understand this. You still do not need more compatibles. Your sentence did not clarify it because it did not answer at all to question "why". Why do you need it? Sorry, the change looks not correct. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel