All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxim Levitsky <mlevitsk@redhat.com>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: Re: [PATCH v4 2/4] block: add bdrv_co_delete_file_noerr
Date: Wed, 09 Dec 2020 22:26:06 +0200	[thread overview]
Message-ID: <db2d85c6191540de19ca32bbcca23b400c19d42d.camel@redhat.com> (raw)
In-Reply-To: <w51pn3inasm.fsf@maestria.local.igalia.com>

On Wed, 2020-12-09 at 18:34 +0100, Alberto Garcia wrote:
> On Wed 09 Dec 2020 05:44:39 PM CET, Maxim Levitsky wrote:
> > +void coroutine_fn bdrv_co_delete_file_noerr(BlockDriverState *bs)
> > +{
> > +    Error *local_err = NULL;
> > +
> > +    if (!bs) {
> > +        return;
> > +    }
> > +
> > +    int ret = bdrv_co_delete_file(bs, &local_err);
>        ^^^
> 
> According to the QEMU coding style we should not have declarations in
> the middle of a block.

Oops!

I will send next version now.

Thanks a lot for the review!

Best regards,
	Maxim Levitsky

> 
> The patch looks otherwise fine.
> 
> Reviewed-by: Alberto Garcia <berto@igalia.com>
> 
> Berto
> 




  reply	other threads:[~2020-12-09 20:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-09 16:44 [PATCH v4 0/4] qcow2: don't leave partially initialized file on image creation Maxim Levitsky
2020-12-09 16:44 ` [PATCH v4 1/4] crypto: luks: Fix tiny memory leak Maxim Levitsky
2020-12-09 16:44 ` [PATCH v4 2/4] block: add bdrv_co_delete_file_noerr Maxim Levitsky
2020-12-09 17:34   ` Alberto Garcia
2020-12-09 20:26     ` Maxim Levitsky [this message]
2020-12-09 16:44 ` [PATCH v4 3/4] crypto: luks: use bdrv_co_delete_file_noerr Maxim Levitsky
2020-12-09 17:34   ` Alberto Garcia
2020-12-09 16:44 ` [PATCH v4 4/4] block: qcow2: remove the created file on initialization error Maxim Levitsky
2020-12-09 17:41   ` Alberto Garcia
2020-12-09 20:33     ` Maxim Levitsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=db2d85c6191540de19ca32bbcca23b400c19d42d.camel@redhat.com \
    --to=mlevitsk@redhat.com \
    --cc=berto@igalia.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.