From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52150)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1bHd8A-00071S-90
	for qemu-devel@nongnu.org; Mon, 27 Jun 2016 16:27:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1bHd87-0003CP-4i
	for qemu-devel@nongnu.org; Mon, 27 Jun 2016 16:27:42 -0400
Received: from mail-qt0-x244.google.com ([2607:f8b0:400d:c0d::244]:33495)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1bHd86-0003CK-Vs
	for qemu-devel@nongnu.org; Mon, 27 Jun 2016 16:27:39 -0400
Received: by mail-qt0-x244.google.com with SMTP id f89so4229297qtd.0
	for <qemu-devel@nongnu.org>; Mon, 27 Jun 2016 13:27:38 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
References: <1467054136-10430-1-git-send-email-cota@braap.org>
	<1467054136-10430-12-git-send-email-cota@braap.org>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <db3490d5-34e4-9f49-8174-fd8d7d521d8c@twiddle.net>
Date: Mon, 27 Jun 2016 13:27:35 -0700
MIME-Version: 1.0
In-Reply-To: <1467054136-10430-12-git-send-email-cota@braap.org>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC 11/30] target-i386: add atomic helpers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Emilio G. Cota" <cota@braap.org>, QEMU Developers <qemu-devel@nongnu.org>, MTTCG Devel <mttcg@greensocs.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Alvise Rigo <a.rigo@virtualopensystems.com>, Sergey Fedorov <serge.fdrv@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, =?UTF-8?Q?Alex_Benn=c3=a9e?= <alex.bennee@linaro.org>

On 06/27/2016 12:01 PM, Emilio G. Cota wrote:
> This patch only adds the helpers. Functions to invoke the helpers
> from translated code are generated in subsequent patches.
>
> Signed-off-by: Emilio G. Cota <cota@braap.org>
> ---
>  target-i386/helper.h     | 34 ++++++++++++++++++++++++++++++++++
>  target-i386/mem_helper.c | 38 ++++++++++++++++++++++++++++++++++++++
>  target-i386/translate.c  | 45 +++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 117 insertions(+)


These are bare wrappers around what you've just added to exec/cpu_ldst*.

(1) Is there any reason these shouldn't go into tcg-runtime.h and tcg-runtime.c 
instead?

(2) If so, is there any good reason to add these to cpu_ldst* instead of *only* 
adding them as helpers to tcg-runtime.c?


r~