From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 54E2CC3526D for ; Wed, 26 Jan 2022 14:11:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 346EF10E6EE; Wed, 26 Jan 2022 14:11:57 +0000 (UTC) Received: from pio-pvt-msa2.bahnhof.se (pio-pvt-msa2.bahnhof.se [79.136.2.41]) by gabe.freedesktop.org (Postfix) with ESMTPS id 47CFE10E6B6; Wed, 26 Jan 2022 14:11:55 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by pio-pvt-msa2.bahnhof.se (Postfix) with ESMTP id C0FB23F36F; Wed, 26 Jan 2022 15:11:53 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at bahnhof.se Authentication-Results: pio-pvt-msa2.bahnhof.se (amavisd-new); dkim=pass (1024-bit key) header.d=shipmail.org Received: from pio-pvt-msa2.bahnhof.se ([127.0.0.1]) by localhost (pio-pvt-msa2.bahnhof.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xl03J6hK3jv6; Wed, 26 Jan 2022 15:11:52 +0100 (CET) Received: by pio-pvt-msa2.bahnhof.se (Postfix) with ESMTPA id CF3553F2DE; Wed, 26 Jan 2022 15:11:49 +0100 (CET) Received: from [192.168.0.209] (unknown [192.55.55.54]) by mail1.shipmail.org (Postfix) with ESMTPSA id A19CB3626AA; Wed, 26 Jan 2022 15:11:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=shipmail.org; s=mail; t=1643206309; bh=LMhkrBdLZkCEhoHLd421DsjJY0iUDjhzCRAXtSuRAVw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=bhGE/1T/HXW8ty3QjO7s0GAIEecumC7GzazfLWYDD2jQYG02G3lCi6TF9ppxG7z+d L8nfU6tWYcT5EHAEj2WlaO+dNC6RtJAjOqTwv4SegMhbcVhC3tAsjrlLS28INKx8vS 0aYvFwy3m9W8Crjy6Y22md3wupm4M61QnUs9KDTU= Message-ID: Date: Wed, 26 Jan 2022 15:11:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [Intel-gfx] [PATCH v5 5/5] drm/i915/uapi: document behaviour for DG2 64K support Content-Language: en-US To: Robert Beckett , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter References: <20220125193530.3272386-1-bob.beckett@collabora.com> <20220125193530.3272386-6-bob.beckett@collabora.com> From: =?UTF-8?Q?Thomas_Hellstr=c3=b6m_=28Intel=29?= In-Reply-To: <20220125193530.3272386-6-bob.beckett@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, Kenneth Graunke , dri-devel@lists.freedesktop.org, Slawomir Milczarek , Matthew Auld , mesa-dev@lists.freedesktop.org, linux-kernel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 1/25/22 20:35, Robert Beckett wrote: > From: Matthew Auld > > On discrete platforms like DG2, we need to support a minimum page size > of 64K when dealing with device local-memory. This is quite tricky for > various reasons, so try to document the new implicit uapi for this. > > v3: fix typos and less emphasis > v2: Fixed suggestions on formatting [Daniel] > > Signed-off-by: Matthew Auld > Signed-off-by: Ramalingam C > Signed-off-by: Robert Beckett > Acked-by: Jordan Justen > Reviewed-by: Ramalingam C > cc: Simon Ser > cc: Pekka Paalanen > Cc: Jordan Justen > Cc: Kenneth Graunke > Cc: mesa-dev@lists.freedesktop.org > Cc: Tony Ye > Cc: Slawomir Milczarek > --- Reviewed-by: Thomas Hellström From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35B37C28CF5 for ; Wed, 26 Jan 2022 14:11:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241936AbiAZOL5 (ORCPT ); Wed, 26 Jan 2022 09:11:57 -0500 Received: from pio-pvt-msa2.bahnhof.se ([79.136.2.41]:58524 "EHLO pio-pvt-msa2.bahnhof.se" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241925AbiAZOLz (ORCPT ); Wed, 26 Jan 2022 09:11:55 -0500 Received: from localhost (localhost [127.0.0.1]) by pio-pvt-msa2.bahnhof.se (Postfix) with ESMTP id C0FB23F36F; Wed, 26 Jan 2022 15:11:53 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at bahnhof.se Authentication-Results: pio-pvt-msa2.bahnhof.se (amavisd-new); dkim=pass (1024-bit key) header.d=shipmail.org Received: from pio-pvt-msa2.bahnhof.se ([127.0.0.1]) by localhost (pio-pvt-msa2.bahnhof.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xl03J6hK3jv6; Wed, 26 Jan 2022 15:11:52 +0100 (CET) Received: by pio-pvt-msa2.bahnhof.se (Postfix) with ESMTPA id CF3553F2DE; Wed, 26 Jan 2022 15:11:49 +0100 (CET) Received: from [192.168.0.209] (unknown [192.55.55.54]) by mail1.shipmail.org (Postfix) with ESMTPSA id A19CB3626AA; Wed, 26 Jan 2022 15:11:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=shipmail.org; s=mail; t=1643206309; bh=LMhkrBdLZkCEhoHLd421DsjJY0iUDjhzCRAXtSuRAVw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=bhGE/1T/HXW8ty3QjO7s0GAIEecumC7GzazfLWYDD2jQYG02G3lCi6TF9ppxG7z+d L8nfU6tWYcT5EHAEj2WlaO+dNC6RtJAjOqTwv4SegMhbcVhC3tAsjrlLS28INKx8vS 0aYvFwy3m9W8Crjy6Y22md3wupm4M61QnUs9KDTU= Message-ID: Date: Wed, 26 Jan 2022 15:11:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [Intel-gfx] [PATCH v5 5/5] drm/i915/uapi: document behaviour for DG2 64K support Content-Language: en-US To: Robert Beckett , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter Cc: intel-gfx@lists.freedesktop.org, Kenneth Graunke , dri-devel@lists.freedesktop.org, Slawomir Milczarek , Pekka Paalanen , Matthew Auld , Simon Ser , mesa-dev@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20220125193530.3272386-1-bob.beckett@collabora.com> <20220125193530.3272386-6-bob.beckett@collabora.com> From: =?UTF-8?Q?Thomas_Hellstr=c3=b6m_=28Intel=29?= In-Reply-To: <20220125193530.3272386-6-bob.beckett@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/25/22 20:35, Robert Beckett wrote: > From: Matthew Auld > > On discrete platforms like DG2, we need to support a minimum page size > of 64K when dealing with device local-memory. This is quite tricky for > various reasons, so try to document the new implicit uapi for this. > > v3: fix typos and less emphasis > v2: Fixed suggestions on formatting [Daniel] > > Signed-off-by: Matthew Auld > Signed-off-by: Ramalingam C > Signed-off-by: Robert Beckett > Acked-by: Jordan Justen > Reviewed-by: Ramalingam C > cc: Simon Ser > cc: Pekka Paalanen > Cc: Jordan Justen > Cc: Kenneth Graunke > Cc: mesa-dev@lists.freedesktop.org > Cc: Tony Ye > Cc: Slawomir Milczarek > --- Reviewed-by: Thomas Hellström From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 79975C2BA4C for ; Wed, 26 Jan 2022 14:11:56 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C82E710E6B6; Wed, 26 Jan 2022 14:11:55 +0000 (UTC) Received: from pio-pvt-msa2.bahnhof.se (pio-pvt-msa2.bahnhof.se [79.136.2.41]) by gabe.freedesktop.org (Postfix) with ESMTPS id 47CFE10E6B6; Wed, 26 Jan 2022 14:11:55 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by pio-pvt-msa2.bahnhof.se (Postfix) with ESMTP id C0FB23F36F; Wed, 26 Jan 2022 15:11:53 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at bahnhof.se Authentication-Results: pio-pvt-msa2.bahnhof.se (amavisd-new); dkim=pass (1024-bit key) header.d=shipmail.org Received: from pio-pvt-msa2.bahnhof.se ([127.0.0.1]) by localhost (pio-pvt-msa2.bahnhof.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xl03J6hK3jv6; Wed, 26 Jan 2022 15:11:52 +0100 (CET) Received: by pio-pvt-msa2.bahnhof.se (Postfix) with ESMTPA id CF3553F2DE; Wed, 26 Jan 2022 15:11:49 +0100 (CET) Received: from [192.168.0.209] (unknown [192.55.55.54]) by mail1.shipmail.org (Postfix) with ESMTPSA id A19CB3626AA; Wed, 26 Jan 2022 15:11:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=shipmail.org; s=mail; t=1643206309; bh=LMhkrBdLZkCEhoHLd421DsjJY0iUDjhzCRAXtSuRAVw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=bhGE/1T/HXW8ty3QjO7s0GAIEecumC7GzazfLWYDD2jQYG02G3lCi6TF9ppxG7z+d L8nfU6tWYcT5EHAEj2WlaO+dNC6RtJAjOqTwv4SegMhbcVhC3tAsjrlLS28INKx8vS 0aYvFwy3m9W8Crjy6Y22md3wupm4M61QnUs9KDTU= Message-ID: Date: Wed, 26 Jan 2022 15:11:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Content-Language: en-US To: Robert Beckett , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter References: <20220125193530.3272386-1-bob.beckett@collabora.com> <20220125193530.3272386-6-bob.beckett@collabora.com> From: =?UTF-8?Q?Thomas_Hellstr=c3=b6m_=28Intel=29?= In-Reply-To: <20220125193530.3272386-6-bob.beckett@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Intel-gfx] [PATCH v5 5/5] drm/i915/uapi: document behaviour for DG2 64K support X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Simon Ser , intel-gfx@lists.freedesktop.org, Kenneth Graunke , dri-devel@lists.freedesktop.org, Slawomir Milczarek , Pekka Paalanen , Matthew Auld , mesa-dev@lists.freedesktop.org, linux-kernel@vger.kernel.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 1/25/22 20:35, Robert Beckett wrote: > From: Matthew Auld > > On discrete platforms like DG2, we need to support a minimum page size > of 64K when dealing with device local-memory. This is quite tricky for > various reasons, so try to document the new implicit uapi for this. > > v3: fix typos and less emphasis > v2: Fixed suggestions on formatting [Daniel] > > Signed-off-by: Matthew Auld > Signed-off-by: Ramalingam C > Signed-off-by: Robert Beckett > Acked-by: Jordan Justen > Reviewed-by: Ramalingam C > cc: Simon Ser > cc: Pekka Paalanen > Cc: Jordan Justen > Cc: Kenneth Graunke > Cc: mesa-dev@lists.freedesktop.org > Cc: Tony Ye > Cc: Slawomir Milczarek > --- Reviewed-by: Thomas Hellström