From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53C00C433E6 for ; Mon, 25 Jan 2021 04:14:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 26E282079A for ; Mon, 25 Jan 2021 04:14:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726951AbhAYEOH (ORCPT ); Sun, 24 Jan 2021 23:14:07 -0500 Received: from new2-smtp.messagingengine.com ([66.111.4.224]:43017 "EHLO new2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726630AbhAYEN4 (ORCPT ); Sun, 24 Jan 2021 23:13:56 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id 6ED495807D1; Sun, 24 Jan 2021 23:13:09 -0500 (EST) Received: from imap2 ([10.202.2.52]) by compute3.internal (MEProxy); Sun, 24 Jan 2021 23:13:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm1; bh=GTLpuJENuXu/9veLzAJYxFan+D7b3di 4Fck02B7mcmI=; b=P6kP2F0MHdA2xPLtwetdDp54jp17pVt4kIXzJ/ZqtSKsKdX py1B2DmMZclFKmdLrHK39NqzPIVe9HqxvQfa4jxeHrJyXRKrY8cR+t5LYgXDy27b zrtkon0vOSyA6WLsudV8BQs8BCd9LuK/so3t62zATEKdcgnY88jqw7J9HxhoR/Yk S8OlWW7Djwl39ilIr/ynhSrhz5SbvWnELsUxWf9H+e77RanD6FFIK5ZRoH+ajyo9 zqj8Qc8sHOw/Qt/Tve4zmlGuIEWK5UxeGT83IJz1lKIwhK8VgFYKl0IHnwxxi4Zb c4qwnKE8JzcjtmXJsuLTpNIuHHBTrCJK0yIaZSw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=GTLpuJ ENuXu/9veLzAJYxFan+D7b3di4Fck02B7mcmI=; b=VId8n7gqDILYFOWy6nGtOx +1LhbAGWyDmPQmWpKwbPwwW9Af6NQsu6+A+rtJOcj2qAT5lcwLUDNN7Hl3HZYGY+ tASc8XWadVqQd9bvUOp7ynuRf34zVlpBM6CURROXazbhoio+HESwj3mnAUcqc6cV MmGEWMfKOYKwnRlHhrhneE8tAy55ar4s+fS8365XLheRisfeBUHGzJWFkkJl+F6d mTOewDwMR9qRTdUetcUE45GRhnKs92C3jAFO3a4GJ3/UV1vKZlClJDgXZQ6xFI1w qa0K0wW5hqDJfrq9WQhhmpqUMMVr3IxX+LzqpMa3MemwEiFsVDPpXnwPgjMfDStg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvddvgdeikecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvufgtsehttdertderredtnecuhfhrohhmpedftehnughr vgifucflvghffhgvrhihfdcuoegrnhgurhgvfiesrghjrdhiugdrrghuqeenucggtffrrg htthgvrhhnpeehhfefkefgkeduveehffehieehudejfeejveejfedugfefuedtuedvhefh veeuffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grnhgurhgvfiesrghjrdhiugdrrghu X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 6AA73A0005D; Sun, 24 Jan 2021 23:13:05 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-78-g36b56e88ef-fm-20210120.001-g36b56e88 Mime-Version: 1.0 Message-Id: In-Reply-To: <20210114131622.8951-3-chiawei_wang@aspeedtech.com> References: <20210114131622.8951-1-chiawei_wang@aspeedtech.com> <20210114131622.8951-3-chiawei_wang@aspeedtech.com> Date: Mon, 25 Jan 2021 14:42:45 +1030 From: "Andrew Jeffery" To: "Chia-Wei, Wang" , "Rob Herring" , "Lee Jones" , "Joel Stanley" , "Linus Walleij" , "Corey Minyard" , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org Cc: BMC-SW@aspeedtech.com, "Haiyue Wang" , "Cyril Bur" , "Robert Lippert" Subject: Re: [PATCH v5 2/5] ARM: dts: Remove LPC BMC and Host partitions Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 14 Jan 2021, at 23:46, Chia-Wei, Wang wrote: > The LPC controller has no concept of the BMC and the Host partitions. > > A concrete instance is that the HICRB[5:4] are for the I/O port address > configurtaion of KCS channel 1/2. However, the KCS driver cannot access > HICRB for channel 1/2 initialization via syscon regmap interface due to > the parition boundary. (i.e. offset 80h) > > In addition, for the HW design backward compatibility, a newly added HW > control bit could be located at any reserved one over the LPC addressing > space. Thereby, this patch removes the lpc-bmc and lpc-host child node > and thus the LPC partitioning. > > Note that this change requires the synchronization between device tree > change and the driver change. To prevent the misuse of old devicetrees > with new drivers, or vice versa, the v2 compatible strings are adopted > for the LPC device as listed: > > "aspeed,ast2400-lpc-v2" > "aspeed,ast2500-lpc-v2" > "aspeed,ast2600-lpc-v2" > > Signed-off-by: Chia-Wei, Wang > --- > arch/arm/boot/dts/aspeed-g4.dtsi | 74 +++++++---------- > arch/arm/boot/dts/aspeed-g5.dtsi | 135 ++++++++++++++----------------- > arch/arm/boot/dts/aspeed-g6.dtsi | 135 ++++++++++++++----------------- I've booted a Witherspoon BMC and host with these patches applied, so for aspeed-g5.dtsi: Tested-by: Andrew Jeffery From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84610C433DB for ; Mon, 25 Jan 2021 04:14:46 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 889F120738 for ; Mon, 25 Jan 2021 04:14:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 889F120738 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aj.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4DPGjH2CfLzDqmJ for ; Mon, 25 Jan 2021 15:14:43 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=aj.id.au (client-ip=66.111.4.224; helo=new2-smtp.messagingengine.com; envelope-from=andrew@aj.id.au; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=aj.id.au header.i=@aj.id.au header.a=rsa-sha256 header.s=fm1 header.b=P6kP2F0M; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm1 header.b=VId8n7gq; dkim-atps=neutral Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4DPGgY565HzDqXJ; Mon, 25 Jan 2021 15:13:12 +1100 (AEDT) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id 6ED495807D1; Sun, 24 Jan 2021 23:13:09 -0500 (EST) Received: from imap2 ([10.202.2.52]) by compute3.internal (MEProxy); Sun, 24 Jan 2021 23:13:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm1; bh=GTLpuJENuXu/9veLzAJYxFan+D7b3di 4Fck02B7mcmI=; b=P6kP2F0MHdA2xPLtwetdDp54jp17pVt4kIXzJ/ZqtSKsKdX py1B2DmMZclFKmdLrHK39NqzPIVe9HqxvQfa4jxeHrJyXRKrY8cR+t5LYgXDy27b zrtkon0vOSyA6WLsudV8BQs8BCd9LuK/so3t62zATEKdcgnY88jqw7J9HxhoR/Yk S8OlWW7Djwl39ilIr/ynhSrhz5SbvWnELsUxWf9H+e77RanD6FFIK5ZRoH+ajyo9 zqj8Qc8sHOw/Qt/Tve4zmlGuIEWK5UxeGT83IJz1lKIwhK8VgFYKl0IHnwxxi4Zb c4qwnKE8JzcjtmXJsuLTpNIuHHBTrCJK0yIaZSw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=GTLpuJ ENuXu/9veLzAJYxFan+D7b3di4Fck02B7mcmI=; b=VId8n7gqDILYFOWy6nGtOx +1LhbAGWyDmPQmWpKwbPwwW9Af6NQsu6+A+rtJOcj2qAT5lcwLUDNN7Hl3HZYGY+ tASc8XWadVqQd9bvUOp7ynuRf34zVlpBM6CURROXazbhoio+HESwj3mnAUcqc6cV MmGEWMfKOYKwnRlHhrhneE8tAy55ar4s+fS8365XLheRisfeBUHGzJWFkkJl+F6d mTOewDwMR9qRTdUetcUE45GRhnKs92C3jAFO3a4GJ3/UV1vKZlClJDgXZQ6xFI1w qa0K0wW5hqDJfrq9WQhhmpqUMMVr3IxX+LzqpMa3MemwEiFsVDPpXnwPgjMfDStg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvddvgdeikecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvufgtsehttdertderredtnecuhfhrohhmpedftehnughr vgifucflvghffhgvrhihfdcuoegrnhgurhgvfiesrghjrdhiugdrrghuqeenucggtffrrg htthgvrhhnpeehhfefkefgkeduveehffehieehudejfeejveejfedugfefuedtuedvhefh veeuffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grnhgurhgvfiesrghjrdhiugdrrghu X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 6AA73A0005D; Sun, 24 Jan 2021 23:13:05 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-78-g36b56e88ef-fm-20210120.001-g36b56e88 Mime-Version: 1.0 Message-Id: In-Reply-To: <20210114131622.8951-3-chiawei_wang@aspeedtech.com> References: <20210114131622.8951-1-chiawei_wang@aspeedtech.com> <20210114131622.8951-3-chiawei_wang@aspeedtech.com> Date: Mon, 25 Jan 2021 14:42:45 +1030 From: "Andrew Jeffery" To: "Chia-Wei, Wang" , "Rob Herring" , "Lee Jones" , "Joel Stanley" , "Linus Walleij" , "Corey Minyard" , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org Subject: Re: [PATCH v5 2/5] ARM: dts: Remove LPC BMC and Host partitions Content-Type: text/plain X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: BMC-SW@aspeedtech.com, Cyril Bur , Haiyue Wang Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Thu, 14 Jan 2021, at 23:46, Chia-Wei, Wang wrote: > The LPC controller has no concept of the BMC and the Host partitions. > > A concrete instance is that the HICRB[5:4] are for the I/O port address > configurtaion of KCS channel 1/2. However, the KCS driver cannot access > HICRB for channel 1/2 initialization via syscon regmap interface due to > the parition boundary. (i.e. offset 80h) > > In addition, for the HW design backward compatibility, a newly added HW > control bit could be located at any reserved one over the LPC addressing > space. Thereby, this patch removes the lpc-bmc and lpc-host child node > and thus the LPC partitioning. > > Note that this change requires the synchronization between device tree > change and the driver change. To prevent the misuse of old devicetrees > with new drivers, or vice versa, the v2 compatible strings are adopted > for the LPC device as listed: > > "aspeed,ast2400-lpc-v2" > "aspeed,ast2500-lpc-v2" > "aspeed,ast2600-lpc-v2" > > Signed-off-by: Chia-Wei, Wang > --- > arch/arm/boot/dts/aspeed-g4.dtsi | 74 +++++++---------- > arch/arm/boot/dts/aspeed-g5.dtsi | 135 ++++++++++++++----------------- > arch/arm/boot/dts/aspeed-g6.dtsi | 135 ++++++++++++++----------------- I've booted a Witherspoon BMC and host with these patches applied, so for aspeed-g5.dtsi: Tested-by: Andrew Jeffery From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26821C433E0 for ; Mon, 25 Jan 2021 04:15:52 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE0D12079A for ; Mon, 25 Jan 2021 04:15:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE0D12079A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aj.id.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:To:From:Date:References:In-Reply-To: Message-Id:Mime-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qpSdxozQNaQZNGMPVZw6jC2P4l1Tc2jvU/Ppk4S8cjE=; b=TdE4IUaoaUgZqsrfwH79mWXP+ gIbPLO8t716PO0CjsScUTr2XP1tV1jSewFbAXVqDy8EbykJiKPP3SsiOeupexkhiMb5hQ8cVM2ejE 2ls6h4aGhDkxaiP8DFshgUTftpG6HGMXF1hh1iKEov2yHhRCZ945NaeUBOoqULz3KCEnWc6ApkhUK q+UaFoJBH9wkpoUugg0ob7VejmXek3Y/NVEjw/r4/hyd/OXnkMjUjxct+4RdtmB8QnwGpYr+fM6iY bJMPnPSsEoj6KZbBtMv4whctZqgsRHalAXoynOgFgZ3NpIxIc9wjOWxgPGQijXAGuAMhJwxKxGM4M MjUb8eauw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l3tFa-0000qj-L7; Mon, 25 Jan 2021 04:13:14 +0000 Received: from new2-smtp.messagingengine.com ([66.111.4.224]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l3tFY-0000qG-47 for linux-arm-kernel@lists.infradead.org; Mon, 25 Jan 2021 04:13:12 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id 6ED495807D1; Sun, 24 Jan 2021 23:13:09 -0500 (EST) Received: from imap2 ([10.202.2.52]) by compute3.internal (MEProxy); Sun, 24 Jan 2021 23:13:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm1; bh=GTLpuJENuXu/9veLzAJYxFan+D7b3di 4Fck02B7mcmI=; b=P6kP2F0MHdA2xPLtwetdDp54jp17pVt4kIXzJ/ZqtSKsKdX py1B2DmMZclFKmdLrHK39NqzPIVe9HqxvQfa4jxeHrJyXRKrY8cR+t5LYgXDy27b zrtkon0vOSyA6WLsudV8BQs8BCd9LuK/so3t62zATEKdcgnY88jqw7J9HxhoR/Yk S8OlWW7Djwl39ilIr/ynhSrhz5SbvWnELsUxWf9H+e77RanD6FFIK5ZRoH+ajyo9 zqj8Qc8sHOw/Qt/Tve4zmlGuIEWK5UxeGT83IJz1lKIwhK8VgFYKl0IHnwxxi4Zb c4qwnKE8JzcjtmXJsuLTpNIuHHBTrCJK0yIaZSw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=GTLpuJ ENuXu/9veLzAJYxFan+D7b3di4Fck02B7mcmI=; b=VId8n7gqDILYFOWy6nGtOx +1LhbAGWyDmPQmWpKwbPwwW9Af6NQsu6+A+rtJOcj2qAT5lcwLUDNN7Hl3HZYGY+ tASc8XWadVqQd9bvUOp7ynuRf34zVlpBM6CURROXazbhoio+HESwj3mnAUcqc6cV MmGEWMfKOYKwnRlHhrhneE8tAy55ar4s+fS8365XLheRisfeBUHGzJWFkkJl+F6d mTOewDwMR9qRTdUetcUE45GRhnKs92C3jAFO3a4GJ3/UV1vKZlClJDgXZQ6xFI1w qa0K0wW5hqDJfrq9WQhhmpqUMMVr3IxX+LzqpMa3MemwEiFsVDPpXnwPgjMfDStg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvddvgdeikecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvufgtsehttdertderredtnecuhfhrohhmpedftehnughr vgifucflvghffhgvrhihfdcuoegrnhgurhgvfiesrghjrdhiugdrrghuqeenucggtffrrg htthgvrhhnpeehhfefkefgkeduveehffehieehudejfeejveejfedugfefuedtuedvhefh veeuffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grnhgurhgvfiesrghjrdhiugdrrghu X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 6AA73A0005D; Sun, 24 Jan 2021 23:13:05 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-78-g36b56e88ef-fm-20210120.001-g36b56e88 Mime-Version: 1.0 Message-Id: In-Reply-To: <20210114131622.8951-3-chiawei_wang@aspeedtech.com> References: <20210114131622.8951-1-chiawei_wang@aspeedtech.com> <20210114131622.8951-3-chiawei_wang@aspeedtech.com> Date: Mon, 25 Jan 2021 14:42:45 +1030 From: "Andrew Jeffery" To: "Chia-Wei, Wang" , "Rob Herring" , "Lee Jones" , "Joel Stanley" , "Linus Walleij" , "Corey Minyard" , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org Subject: Re: [PATCH v5 2/5] ARM: dts: Remove LPC BMC and Host partitions X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210124_231312_228367_D3F1874B X-CRM114-Status: GOOD ( 14.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: BMC-SW@aspeedtech.com, Cyril Bur , Haiyue Wang , Robert Lippert Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 14 Jan 2021, at 23:46, Chia-Wei, Wang wrote: > The LPC controller has no concept of the BMC and the Host partitions. > > A concrete instance is that the HICRB[5:4] are for the I/O port address > configurtaion of KCS channel 1/2. However, the KCS driver cannot access > HICRB for channel 1/2 initialization via syscon regmap interface due to > the parition boundary. (i.e. offset 80h) > > In addition, for the HW design backward compatibility, a newly added HW > control bit could be located at any reserved one over the LPC addressing > space. Thereby, this patch removes the lpc-bmc and lpc-host child node > and thus the LPC partitioning. > > Note that this change requires the synchronization between device tree > change and the driver change. To prevent the misuse of old devicetrees > with new drivers, or vice versa, the v2 compatible strings are adopted > for the LPC device as listed: > > "aspeed,ast2400-lpc-v2" > "aspeed,ast2500-lpc-v2" > "aspeed,ast2600-lpc-v2" > > Signed-off-by: Chia-Wei, Wang > --- > arch/arm/boot/dts/aspeed-g4.dtsi | 74 +++++++---------- > arch/arm/boot/dts/aspeed-g5.dtsi | 135 ++++++++++++++----------------- > arch/arm/boot/dts/aspeed-g6.dtsi | 135 ++++++++++++++----------------- I've booted a Witherspoon BMC and host with these patches applied, so for aspeed-g5.dtsi: Tested-by: Andrew Jeffery _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel