* [PATCH][next] net: bridge: Fix missing return assignment from br_vlan_replay_one call
@ 2021-03-24 15:09 ` Colin King
0 siblings, 0 replies; 8+ messages in thread
From: Colin King @ 2021-03-24 15:09 UTC (permalink / raw)
To: Roopa Prabhu, Nikolay Aleksandrov, David S . Miller,
Jakub Kicinski, Vladimir Oltean, bridge, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The call to br_vlan_replay_one is returning an error return value but
this is not being assigned to err and the following check on err is
currently always false because err was initialized to zero. Fix this
by assigning err.
Addresses-Coverity: ("'Constant' variable guards dead code")
Fixes: 22f67cdfae6a ("net: bridge: add helper to replay VLANs installed on port")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
net/bridge/br_vlan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bridge/br_vlan.c b/net/bridge/br_vlan.c
index ca8daccff217..7422691230b1 100644
--- a/net/bridge/br_vlan.c
+++ b/net/bridge/br_vlan.c
@@ -1815,7 +1815,7 @@ int br_vlan_replay(struct net_device *br_dev, struct net_device *dev,
if (!br_vlan_should_use(v))
continue;
- br_vlan_replay_one(nb, dev, &vlan, extack);
+ err = br_vlan_replay_one(nb, dev, &vlan, extack);
if (err)
return err;
}
--
2.30.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Bridge] [PATCH][next] net: bridge: Fix missing return assignment from br_vlan_replay_one call
@ 2021-03-24 15:09 ` Colin King
0 siblings, 0 replies; 8+ messages in thread
From: Colin King @ 2021-03-24 15:09 UTC (permalink / raw)
To: Roopa Prabhu, Nikolay Aleksandrov, David S . Miller,
Jakub Kicinski, Vladimir Oltean, bridge, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The call to br_vlan_replay_one is returning an error return value but
this is not being assigned to err and the following check on err is
currently always false because err was initialized to zero. Fix this
by assigning err.
Addresses-Coverity: ("'Constant' variable guards dead code")
Fixes: 22f67cdfae6a ("net: bridge: add helper to replay VLANs installed on port")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
net/bridge/br_vlan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bridge/br_vlan.c b/net/bridge/br_vlan.c
index ca8daccff217..7422691230b1 100644
--- a/net/bridge/br_vlan.c
+++ b/net/bridge/br_vlan.c
@@ -1815,7 +1815,7 @@ int br_vlan_replay(struct net_device *br_dev, struct net_device *dev,
if (!br_vlan_should_use(v))
continue;
- br_vlan_replay_one(nb, dev, &vlan, extack);
+ err = br_vlan_replay_one(nb, dev, &vlan, extack);
if (err)
return err;
}
--
2.30.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH][next] net: bridge: Fix missing return assignment from br_vlan_replay_one call
2021-03-24 15:09 ` [Bridge] " Colin King
@ 2021-03-24 16:02 ` Vladimir Oltean
-1 siblings, 0 replies; 8+ messages in thread
From: Vladimir Oltean @ 2021-03-24 16:02 UTC (permalink / raw)
To: Colin King
Cc: Roopa Prabhu, Nikolay Aleksandrov, David S . Miller,
Jakub Kicinski, Vladimir Oltean, bridge, netdev, kernel-janitors,
linux-kernel
On Wed, Mar 24, 2021 at 03:09:50PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The call to br_vlan_replay_one is returning an error return value but
> this is not being assigned to err and the following check on err is
> currently always false because err was initialized to zero. Fix this
> by assigning err.
>
> Addresses-Coverity: ("'Constant' variable guards dead code")
> Fixes: 22f67cdfae6a ("net: bridge: add helper to replay VLANs installed on port")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Bridge] [PATCH][next] net: bridge: Fix missing return assignment from br_vlan_replay_one call
@ 2021-03-24 16:02 ` Vladimir Oltean
0 siblings, 0 replies; 8+ messages in thread
From: Vladimir Oltean @ 2021-03-24 16:02 UTC (permalink / raw)
To: Colin King
Cc: Vladimir Oltean, bridge, kernel-janitors, linux-kernel, netdev,
Nikolay Aleksandrov, Roopa Prabhu, Jakub Kicinski,
David S . Miller
On Wed, Mar 24, 2021 at 03:09:50PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The call to br_vlan_replay_one is returning an error return value but
> this is not being assigned to err and the following check on err is
> currently always false because err was initialized to zero. Fix this
> by assigning err.
>
> Addresses-Coverity: ("'Constant' variable guards dead code")
> Fixes: 22f67cdfae6a ("net: bridge: add helper to replay VLANs installed on port")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH][next] net: bridge: Fix missing return assignment from br_vlan_replay_one call
2021-03-24 15:09 ` [Bridge] " Colin King
@ 2021-03-24 18:50 ` Nikolay Aleksandrov
-1 siblings, 0 replies; 8+ messages in thread
From: Nikolay Aleksandrov @ 2021-03-24 18:50 UTC (permalink / raw)
To: Colin King, Roopa Prabhu, David S . Miller, Jakub Kicinski,
Vladimir Oltean, bridge, netdev
Cc: kernel-janitors, linux-kernel
On 24/03/2021 17:09, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The call to br_vlan_replay_one is returning an error return value but
> this is not being assigned to err and the following check on err is
> currently always false because err was initialized to zero. Fix this
> by assigning err.
>
> Addresses-Coverity: ("'Constant' variable guards dead code")
> Fixes: 22f67cdfae6a ("net: bridge: add helper to replay VLANs installed on port")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> net/bridge/br_vlan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/bridge/br_vlan.c b/net/bridge/br_vlan.c
> index ca8daccff217..7422691230b1 100644
> --- a/net/bridge/br_vlan.c
> +++ b/net/bridge/br_vlan.c
> @@ -1815,7 +1815,7 @@ int br_vlan_replay(struct net_device *br_dev, struct net_device *dev,
> if (!br_vlan_should_use(v))
> continue;
>
> - br_vlan_replay_one(nb, dev, &vlan, extack);
> + err = br_vlan_replay_one(nb, dev, &vlan, extack);
> if (err)
> return err;
> }
>
Thanks,
Acked-by: Nikolay Aleksandrov <nikolay@nvidia.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Bridge] [PATCH][next] net: bridge: Fix missing return assignment from br_vlan_replay_one call
@ 2021-03-24 18:50 ` Nikolay Aleksandrov
0 siblings, 0 replies; 8+ messages in thread
From: Nikolay Aleksandrov @ 2021-03-24 18:50 UTC (permalink / raw)
To: Colin King, Roopa Prabhu, David S . Miller, Jakub Kicinski,
Vladimir Oltean, bridge, netdev
Cc: kernel-janitors, linux-kernel
On 24/03/2021 17:09, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The call to br_vlan_replay_one is returning an error return value but
> this is not being assigned to err and the following check on err is
> currently always false because err was initialized to zero. Fix this
> by assigning err.
>
> Addresses-Coverity: ("'Constant' variable guards dead code")
> Fixes: 22f67cdfae6a ("net: bridge: add helper to replay VLANs installed on port")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> net/bridge/br_vlan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/bridge/br_vlan.c b/net/bridge/br_vlan.c
> index ca8daccff217..7422691230b1 100644
> --- a/net/bridge/br_vlan.c
> +++ b/net/bridge/br_vlan.c
> @@ -1815,7 +1815,7 @@ int br_vlan_replay(struct net_device *br_dev, struct net_device *dev,
> if (!br_vlan_should_use(v))
> continue;
>
> - br_vlan_replay_one(nb, dev, &vlan, extack);
> + err = br_vlan_replay_one(nb, dev, &vlan, extack);
> if (err)
> return err;
> }
>
Thanks,
Acked-by: Nikolay Aleksandrov <nikolay@nvidia.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH][next] net: bridge: Fix missing return assignment from br_vlan_replay_one call
2021-03-24 15:09 ` [Bridge] " Colin King
@ 2021-03-24 19:50 ` patchwork-bot+netdevbpf
-1 siblings, 0 replies; 8+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-03-24 19:50 UTC (permalink / raw)
To: Colin King
Cc: roopa, nikolay, davem, kuba, vladimir.oltean, bridge, netdev,
kernel-janitors, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Wed, 24 Mar 2021 15:09:50 +0000 you wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The call to br_vlan_replay_one is returning an error return value but
> this is not being assigned to err and the following check on err is
> currently always false because err was initialized to zero. Fix this
> by assigning err.
>
> [...]
Here is the summary with links:
- [next] net: bridge: Fix missing return assignment from br_vlan_replay_one call
https://git.kernel.org/netdev/net-next/c/ad248f7761eb
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Bridge] [PATCH][next] net: bridge: Fix missing return assignment from br_vlan_replay_one call
@ 2021-03-24 19:50 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 8+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-03-24 19:50 UTC (permalink / raw)
To: Colin King
Cc: vladimir.oltean, bridge, kernel-janitors, linux-kernel, netdev,
nikolay, roopa, kuba, davem
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Wed, 24 Mar 2021 15:09:50 +0000 you wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The call to br_vlan_replay_one is returning an error return value but
> this is not being assigned to err and the following check on err is
> currently always false because err was initialized to zero. Fix this
> by assigning err.
>
> [...]
Here is the summary with links:
- [next] net: bridge: Fix missing return assignment from br_vlan_replay_one call
https://git.kernel.org/netdev/net-next/c/ad248f7761eb
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-03-24 19:51 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-24 15:09 [PATCH][next] net: bridge: Fix missing return assignment from br_vlan_replay_one call Colin King
2021-03-24 15:09 ` [Bridge] " Colin King
2021-03-24 16:02 ` Vladimir Oltean
2021-03-24 16:02 ` [Bridge] " Vladimir Oltean
2021-03-24 18:50 ` Nikolay Aleksandrov
2021-03-24 18:50 ` [Bridge] " Nikolay Aleksandrov
2021-03-24 19:50 ` patchwork-bot+netdevbpf
2021-03-24 19:50 ` [Bridge] " patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.