From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 07/22] drm/i915: Stop needlessly acquiring wakeref for debugfs/drop_caches_set Date: Mon, 18 Mar 2019 13:08:47 +0000 Message-ID: References: <20190318095204.9913-1-chris@chris-wilson.co.uk> <20190318095204.9913-7-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0542B89690 for ; Mon, 18 Mar 2019 13:09:07 +0000 (UTC) In-Reply-To: <20190318095204.9913-7-chris@chris-wilson.co.uk> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: Yokoyama@freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE4LzAzLzIwMTkgMDk6NTEsIENocmlzIFdpbHNvbiB3cm90ZToKPiBXZSBvbmx5IG5lZWQg dG8gYWNxdWlyZSBhIHdha2VyZWYgZm9yIG91cnNlbHZlcyBmb3IgYSBmZXcgb3BlcmF0aW9ucywg YXMKPiBtb3N0IGVpdGhlciBhbHJlYWR5IGFjcXVpcmUgdGhlaXIgb3duIHdha2VyZWYgb3IgaW1w bHkgYSB3YWtlcmVmLiBJbgo+IHBhcnRpY3VsYXIsIGl0IGlzIGk5MTVfZ2VtX3NldF93ZWRnZWQo KSB0aGF0IG5lZWRlZCB1cyB0byBwcmVzZW50IGl0Cj4gd2l0aCBhIHdha2VyZWYsIHdoaWNoIGlz IGluY29uZ3J1b3VzIHdpdGggaXRzICJ1c2UgYW55d2hlcmUiIGFiaWxpdHkuCj4gCj4gU3VnZ2Vz dGVkLWJ5OiBZb2tveWFtYSwgQ2F6IDxjYXoueW9rb3lhbWFAaW50ZWwuY29tPgo+IFNpZ25lZC1v ZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IENjOiBZb2tv eWFtYSwgQ2F6IDxjYXoueW9rb3lhbWFAaW50ZWwuY29tPgo+IENjOiBNaWthIEt1b3BwYWxhIDxt aWthLmt1b3BwYWxhQGxpbnV4LmludGVsLmNvbT4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZGVidWdmcy5jIHwgMTIgKysrKy0tLS0tLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X3Jlc2V0LmMgICB8ICA0ICsrKy0KPiAgIDIgZmlsZXMgY2hhbmdlZCwgNyBpbnNl cnRpb25zKCspLCA5IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2RlYnVnZnMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdm cy5jCj4gaW5kZXggNmE5MDU1OGRlMjEzLi4wODY4M2RjYTc3NzUgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2RlYnVnZnMuYwo+IEBAIC0zODg4LDEyICszODg4LDkgQEAgc3RhdGljIGludAo+ ICAgaTkxNV9kcm9wX2NhY2hlc19zZXQodm9pZCAqZGF0YSwgdTY0IHZhbCkKPiAgIHsKPiAgIAlz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSA9IGRhdGE7Cj4gLQlpbnRlbF93YWtlcmVmX3Qg d2FrZXJlZjsKPiAtCWludCByZXQgPSAwOwo+ICAgCj4gICAJRFJNX0RFQlVHKCJEcm9wcGluZyBj YWNoZXM6IDB4JTA4bGx4IFsweCUwOGxseF1cbiIsCj4gICAJCSAgdmFsLCB2YWwgJiBEUk9QX0FM TCk7Cj4gLQl3YWtlcmVmID0gaW50ZWxfcnVudGltZV9wbV9nZXQoaTkxNSk7Cj4gICAKPiAgIAlp ZiAodmFsICYgRFJPUF9SRVNFVF9BQ1RJVkUgJiYKPiAgIAkgICAgd2FpdF9mb3IoaW50ZWxfZW5n aW5lc19hcmVfaWRsZShpOTE1KSwgSTkxNV9JRExFX0VOR0lORVNfVElNRU9VVCkpCj4gQEAgLTM5 MDIsOSArMzg5OSwxMSBAQCBpOTE1X2Ryb3BfY2FjaGVzX3NldCh2b2lkICpkYXRhLCB1NjQgdmFs KQo+ICAgCS8qIE5vIG5lZWQgdG8gY2hlY2sgYW5kIHdhaXQgZm9yIGdwdSByZXNldHMsIG9ubHkg bGliZHJtIGF1dG8tcmVzdGFydHMKPiAgIAkgKiBvbiBpb2N0bHMgb24gLUVBR0FJTi4gKi8KPiAg IAlpZiAodmFsICYgKERST1BfQUNUSVZFIHwgRFJPUF9SRVRJUkUgfCBEUk9QX1JFU0VUX1NFUU5P KSkgewo+ICsJCWludCByZXQ7Cj4gKwo+ICAgCQlyZXQgPSBtdXRleF9sb2NrX2ludGVycnVwdGli bGUoJmk5MTUtPmRybS5zdHJ1Y3RfbXV0ZXgpOwo+ICAgCQlpZiAocmV0KQo+IC0JCQlnb3RvIG91 dDsKPiArCQkJcmV0dXJuIHJldDsKPiAgIAo+ICAgCQlpZiAodmFsICYgRFJPUF9BQ1RJVkUpCj4g ICAJCQlyZXQgPSBpOTE1X2dlbV93YWl0X2Zvcl9pZGxlKGk5MTUsCj4gQEAgLTM5NDMsMTAgKzM5 NDIsNyBAQCBpOTE1X2Ryb3BfY2FjaGVzX3NldCh2b2lkICpkYXRhLCB1NjQgdmFsKQo+ICAgCWlm ICh2YWwgJiBEUk9QX0ZSRUVEKQo+ICAgCQlpOTE1X2dlbV9kcmFpbl9mcmVlZF9vYmplY3RzKGk5 MTUpOwo+ICAgCj4gLW91dDoKPiAtCWludGVsX3J1bnRpbWVfcG1fcHV0KGk5MTUsIHdha2VyZWYp Owo+IC0KPiAtCXJldHVybiByZXQ7Cj4gKwlyZXR1cm4gMDsKPiAgIH0KPiAgIAo+ICAgREVGSU5F X1NJTVBMRV9BVFRSSUJVVEUoaTkxNV9kcm9wX2NhY2hlc19mb3BzLAo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3Jlc2V0LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X3Jlc2V0LmMKPiBpbmRleCBiOGRhZWM3ZGRjMDYuLmU2MWJmYTBmYzRlMCAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3Jlc2V0LmMKPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X3Jlc2V0LmMKPiBAQCAtODYzLDkgKzg2MywxMSBAQCBzdGF0aWMgdm9p ZCBfX2k5MTVfZ2VtX3NldF93ZWRnZWQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUpCj4g ICB2b2lkIGk5MTVfZ2VtX3NldF93ZWRnZWQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUp Cj4gICB7Cj4gICAJc3RydWN0IGk5MTVfZ3B1X2Vycm9yICplcnJvciA9ICZpOTE1LT5ncHVfZXJy b3I7Cj4gKwlpbnRlbF93YWtlcmVmX3Qgd2FrZXJlZjsKPiAgIAo+ICAgCW11dGV4X2xvY2soJmVy cm9yLT53ZWRnZV9tdXRleCk7Cj4gLQlfX2k5MTVfZ2VtX3NldF93ZWRnZWQoaTkxNSk7Cj4gKwl3 aXRoX2ludGVsX3J1bnRpbWVfcG0oaTkxNSwgd2FrZXJlZikKPiArCQlfX2k5MTVfZ2VtX3NldF93 ZWRnZWQoaTkxNSk7Cj4gICAJbXV0ZXhfdW5sb2NrKCZlcnJvci0+d2VkZ2VfbXV0ZXgpOwo+ICAg fQo+ICAgCj4gCgpTdGF0ZW1lbnQgdGhhdCBhbGwgcGF0aHMgd2lsbCB0YWtlIGEgd2FrZXJlZiBs b29rcyB0cnVlLgoKUmV2aWV3ZWQtYnk6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBp bnRlbC5jb20+CgpSZWdhcmRzLAoKVHZydGtvCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2ludGVsLWdmeA==