From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCF12C433DB for ; Tue, 22 Dec 2020 19:20:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8751523130 for ; Tue, 22 Dec 2020 19:20:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727435AbgLVTUL (ORCPT ); Tue, 22 Dec 2020 14:20:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727298AbgLVTUK (ORCPT ); Tue, 22 Dec 2020 14:20:10 -0500 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22759C0613D3; Tue, 22 Dec 2020 11:19:30 -0800 (PST) Received: by mail-lf1-x12e.google.com with SMTP id a12so34548474lfl.6; Tue, 22 Dec 2020 11:19:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ulrdoVbGsjwhkH0t5gig0hbyBd9UYXc8gP96903YDxw=; b=TfyVQnVt/DSKdLojw95WJ4Y3kr9B3JreJXSNeZLBEluhzjCcPf6K2C/ui4C3A+RAcn NzqrO2ZQ73TaLD5uGBoTA4sttmca1xpwHqU863FtGcUC88cxmEAsuxQikrmwuidA4uCP nm3AAm9TZcl214JdJVxmbY480arDu40d/ZRO/LMZqIPpdTU56ZnmabVMuRGGAvhILYBZ Lo8a4O4xH2G8xK6eSxS2dJykl50tEw6QNTNuUIOxtAh5QuaHw5oC9C+9K8KQXGYHYHDU yCrcC+UxT5hZUbtUNDzWRin0i+Cl3uko4BCCxLbueXyFERpjQkeXnBMSkzUwEXUzI6/8 3Csg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ulrdoVbGsjwhkH0t5gig0hbyBd9UYXc8gP96903YDxw=; b=dsoeetUwex5UebJxUv84mb4Vs1xaKKF2Q9XEKlDDB/PAxF+LhRd9kq2qOyO91XkuWZ FH6jXitwHL23gonl/VgJNPxPaZE8z2zPiU3T2+DqMMqfrlc57sS4xU2Qc95guptKGaH4 9PotBAowkweOIoLdOnAzPHizf59JUpUcRWxT4WMOdknjfn3GzUyMbVYZX/sg+Ez1IcZM jdIbM67HA/TpVjT+dSxXTcK9QmygC4+X0Wnf42VVaP9SLEPC8cj3ze8IpMP8uxILUiBb XM8EW7iRRryWKLjmvh9d+tUimbR2FWvPjFPz6pm7SvZTcdnalCek9YtFAoYBdvOiIz5K iWxg== X-Gm-Message-State: AOAM5336fVnJPkK6YjvMNVhV2LwICm871pRIORHsGwDFEvK8gHgtqEBY 3gbcJC0Qw2v3gd/BWvppGe+z6DyelkI= X-Google-Smtp-Source: ABdhPJyniuH4JIVLYX09aJTJXG2DPOZ3u4RjQh1NfGfdwzaSui65HwnwuqSmtJhso1bwXfgrrij1mg== X-Received: by 2002:ac2:46e4:: with SMTP id q4mr8665320lfo.413.1608664768348; Tue, 22 Dec 2020 11:19:28 -0800 (PST) Received: from [192.168.2.145] (109-252-192-57.dynamic.spd-mgts.ru. [109.252.192.57]) by smtp.googlemail.com with ESMTPSA id w6sm3032131lji.74.2020.12.22.11.19.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Dec 2020 11:19:27 -0800 (PST) Subject: Re: [PATCH v2 19/48] opp: Fix adding OPP entries in a wrong order if rate is unavailable To: Viresh Kumar Cc: Thierry Reding , Jonathan Hunter , Mark Brown , Liam Girdwood , Ulf Hansson , Mauro Carvalho Chehab , Rob Herring , Peter Geis , Nicolas Chauvet , Krzysztof Kozlowski , "Rafael J. Wysocki" , Kevin Hilman , Peter De Schrijver , Viresh Kumar , Stephen Boyd , Michael Turquette , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linux-tegra@vger.kernel.org, linux-clk@vger.kernel.org References: <20201217180638.22748-1-digetx@gmail.com> <20201217180638.22748-20-digetx@gmail.com> <20201222091255.wentz5hyt726qezg@vireshk-i7> From: Dmitry Osipenko Message-ID: Date: Tue, 22 Dec 2020 22:19:26 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.2 MIME-Version: 1.0 In-Reply-To: <20201222091255.wentz5hyt726qezg@vireshk-i7> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org 22.12.2020 12:12, Viresh Kumar пишет: > On 17-12-20, 21:06, Dmitry Osipenko wrote: >> Fix adding OPP entries in a wrong (opposite) order if OPP rate is >> unavailable. The OPP comparison is erroneously skipped if OPP rate is >> missing, thus OPPs are left unsorted. >> >> Signed-off-by: Dmitry Osipenko >> --- >> drivers/opp/core.c | 23 ++++++++++++----------- >> drivers/opp/opp.h | 2 +- >> 2 files changed, 13 insertions(+), 12 deletions(-) >> >> diff --git a/drivers/opp/core.c b/drivers/opp/core.c >> index 34f7e530d941..5c7f130a8de2 100644 >> --- a/drivers/opp/core.c >> +++ b/drivers/opp/core.c >> @@ -1531,9 +1531,10 @@ static bool _opp_supported_by_regulators(struct dev_pm_opp *opp, >> return true; >> } >> >> -int _opp_compare_key(struct dev_pm_opp *opp1, struct dev_pm_opp *opp2) >> +int _opp_compare_key(struct dev_pm_opp *opp1, struct dev_pm_opp *opp2, >> + bool rate_not_available) >> { >> - if (opp1->rate != opp2->rate) >> + if (!rate_not_available && opp1->rate != opp2->rate) > > rate will be 0 for both the OPPs here if rate_not_available is true and so this > change shouldn't be required. The rate_not_available is negated in the condition. This change is required because both rates are 0 and then we should proceed to the levels comparison. I guess it's not clear by looking at this patch, please see a full version of the function: int _opp_compare_key(struct dev_pm_opp *opp1, struct dev_pm_opp *opp2, bool rate_not_available) { if (!rate_not_available && opp1->rate != opp2->rate) return opp1->rate < opp2->rate ? -1 : 1; if (opp1->bandwidth && opp2->bandwidth && opp1->bandwidth[0].peak != opp2->bandwidth[0].peak) return opp1->bandwidth[0].peak < opp2->bandwidth[0].peak ? -1 : 1; if (opp1->level != opp2->level) return opp1->level < opp2->level ? -1 : 1; return 0; } Perhaps we could check whether opp1->rate=0, like it's done for the opp1->bandwidth. I'll consider this variant for v3, thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.6 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C62CAC433DB for ; Tue, 22 Dec 2020 19:19:34 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 64E3623130 for ; Tue, 22 Dec 2020 19:19:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64E3623130 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 2FC378688A; Tue, 22 Dec 2020 19:19:34 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VP6vUxRAF+ep; Tue, 22 Dec 2020 19:19:32 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 24F018685A; Tue, 22 Dec 2020 19:19:32 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 3D7E01BF3D1 for ; Tue, 22 Dec 2020 19:19:31 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 39C5B87244 for ; Tue, 22 Dec 2020 19:19:31 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cP+rL4Gv8boI for ; Tue, 22 Dec 2020 19:19:30 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by hemlock.osuosl.org (Postfix) with ESMTPS id 38C8487228 for ; Tue, 22 Dec 2020 19:19:30 +0000 (UTC) Received: by mail-lf1-f49.google.com with SMTP id o17so34572720lfg.4 for ; Tue, 22 Dec 2020 11:19:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ulrdoVbGsjwhkH0t5gig0hbyBd9UYXc8gP96903YDxw=; b=TfyVQnVt/DSKdLojw95WJ4Y3kr9B3JreJXSNeZLBEluhzjCcPf6K2C/ui4C3A+RAcn NzqrO2ZQ73TaLD5uGBoTA4sttmca1xpwHqU863FtGcUC88cxmEAsuxQikrmwuidA4uCP nm3AAm9TZcl214JdJVxmbY480arDu40d/ZRO/LMZqIPpdTU56ZnmabVMuRGGAvhILYBZ Lo8a4O4xH2G8xK6eSxS2dJykl50tEw6QNTNuUIOxtAh5QuaHw5oC9C+9K8KQXGYHYHDU yCrcC+UxT5hZUbtUNDzWRin0i+Cl3uko4BCCxLbueXyFERpjQkeXnBMSkzUwEXUzI6/8 3Csg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ulrdoVbGsjwhkH0t5gig0hbyBd9UYXc8gP96903YDxw=; b=CUvJv5rHK58GSi0GCoZurb5cwMgCVHQa86gaJzkLujxi4bAxGrW+OHWby8dF47pSQ8 b3YE6vKsiflRAc3zxGUDi7bnaisuPOv7wfKwPQMyvqc+CvieNx8dMA69Hm/39LFT6dKJ JMnpkEvwDeZvc6CSwBgb+sOS1r94NlPp7I6TymHqfXCB30VOWtnM7vLvTG3L9biquiXQ fg/JNz9nl2nrzJ7dzP6l2vvzghJZZ2EOrluNYEP8sy9UjhNLn6s1535x7Yfle2Z02n5E OPEz+cmy31nGLDZnmN87l6ja/1p2I6YhpK2L/kl7Cj2HFjS5+q6v0XcKpA08vOBY4BVF Ogeg== X-Gm-Message-State: AOAM5337C/4sGyRRjCb8vjSR9nz/g6Seif/+pAP5AwZ+1bbKOTegtkTA 21vvtLccgIawGAkNUJ50N+A= X-Google-Smtp-Source: ABdhPJyniuH4JIVLYX09aJTJXG2DPOZ3u4RjQh1NfGfdwzaSui65HwnwuqSmtJhso1bwXfgrrij1mg== X-Received: by 2002:ac2:46e4:: with SMTP id q4mr8665320lfo.413.1608664768348; Tue, 22 Dec 2020 11:19:28 -0800 (PST) Received: from [192.168.2.145] (109-252-192-57.dynamic.spd-mgts.ru. [109.252.192.57]) by smtp.googlemail.com with ESMTPSA id w6sm3032131lji.74.2020.12.22.11.19.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Dec 2020 11:19:27 -0800 (PST) Subject: Re: [PATCH v2 19/48] opp: Fix adding OPP entries in a wrong order if rate is unavailable To: Viresh Kumar References: <20201217180638.22748-1-digetx@gmail.com> <20201217180638.22748-20-digetx@gmail.com> <20201222091255.wentz5hyt726qezg@vireshk-i7> From: Dmitry Osipenko Message-ID: Date: Tue, 22 Dec 2020 22:19:26 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.2 MIME-Version: 1.0 In-Reply-To: <20201222091255.wentz5hyt726qezg@vireshk-i7> Content-Language: en-US X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , Michael Turquette , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thierry Reding , linux-clk@vger.kernel.org, devel@driverdev.osuosl.org, Kevin Hilman , Nicolas Chauvet , Viresh Kumar , Krzysztof Kozlowski , Jonathan Hunter , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , linux-tegra@vger.kernel.org, Mauro Carvalho Chehab , Stephen Boyd , Peter De Schrijver , "Rafael J. Wysocki" , Liam Girdwood , Mark Brown , Peter Geis Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" MjIuMTIuMjAyMCAxMjoxMiwgVmlyZXNoIEt1bWFyINC/0LjRiNC10YI6Cj4gT24gMTctMTItMjAs IDIxOjA2LCBEbWl0cnkgT3NpcGVua28gd3JvdGU6Cj4+IEZpeCBhZGRpbmcgT1BQIGVudHJpZXMg aW4gYSB3cm9uZyAob3Bwb3NpdGUpIG9yZGVyIGlmIE9QUCByYXRlIGlzCj4+IHVuYXZhaWxhYmxl LiBUaGUgT1BQIGNvbXBhcmlzb24gaXMgZXJyb25lb3VzbHkgc2tpcHBlZCBpZiBPUFAgcmF0ZSBp cwo+PiBtaXNzaW5nLCB0aHVzIE9QUHMgYXJlIGxlZnQgdW5zb3J0ZWQuCj4+Cj4+IFNpZ25lZC1v ZmYtYnk6IERtaXRyeSBPc2lwZW5rbyA8ZGlnZXR4QGdtYWlsLmNvbT4KPj4gLS0tCj4+ICBkcml2 ZXJzL29wcC9jb3JlLmMgfCAyMyArKysrKysrKysrKystLS0tLS0tLS0tLQo+PiAgZHJpdmVycy9v cHAvb3BwLmggIHwgIDIgKy0KPj4gIDIgZmlsZXMgY2hhbmdlZCwgMTMgaW5zZXJ0aW9ucygrKSwg MTIgZGVsZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL29wcC9jb3JlLmMgYi9k cml2ZXJzL29wcC9jb3JlLmMKPj4gaW5kZXggMzRmN2U1MzBkOTQxLi41YzdmMTMwYThkZTIgMTAw NjQ0Cj4+IC0tLSBhL2RyaXZlcnMvb3BwL2NvcmUuYwo+PiArKysgYi9kcml2ZXJzL29wcC9jb3Jl LmMKPj4gQEAgLTE1MzEsOSArMTUzMSwxMCBAQCBzdGF0aWMgYm9vbCBfb3BwX3N1cHBvcnRlZF9i eV9yZWd1bGF0b3JzKHN0cnVjdCBkZXZfcG1fb3BwICpvcHAsCj4+ICAJcmV0dXJuIHRydWU7Cj4+ ICB9Cj4+ICAKPj4gLWludCBfb3BwX2NvbXBhcmVfa2V5KHN0cnVjdCBkZXZfcG1fb3BwICpvcHAx LCBzdHJ1Y3QgZGV2X3BtX29wcCAqb3BwMikKPj4gK2ludCBfb3BwX2NvbXBhcmVfa2V5KHN0cnVj dCBkZXZfcG1fb3BwICpvcHAxLCBzdHJ1Y3QgZGV2X3BtX29wcCAqb3BwMiwKPj4gKwkJICAgICBi b29sIHJhdGVfbm90X2F2YWlsYWJsZSkKPj4gIHsKPj4gLQlpZiAob3BwMS0+cmF0ZSAhPSBvcHAy LT5yYXRlKQo+PiArCWlmICghcmF0ZV9ub3RfYXZhaWxhYmxlICYmIG9wcDEtPnJhdGUgIT0gb3Bw Mi0+cmF0ZSkKPiAKPiByYXRlIHdpbGwgYmUgMCBmb3IgYm90aCB0aGUgT1BQcyBoZXJlIGlmIHJh dGVfbm90X2F2YWlsYWJsZSBpcyB0cnVlIGFuZCBzbyB0aGlzCj4gY2hhbmdlIHNob3VsZG4ndCBi ZSByZXF1aXJlZC4KClRoZSByYXRlX25vdF9hdmFpbGFibGUgaXMgbmVnYXRlZCBpbiB0aGUgY29u ZGl0aW9uLiBUaGlzIGNoYW5nZSBpcwpyZXF1aXJlZCBiZWNhdXNlIGJvdGggcmF0ZXMgYXJlIDAg YW5kIHRoZW4gd2Ugc2hvdWxkIHByb2NlZWQgdG8gdGhlCmxldmVscyBjb21wYXJpc29uLgoKSSBn dWVzcyBpdCdzIG5vdCBjbGVhciBieSBsb29raW5nIGF0IHRoaXMgcGF0Y2gsIHBsZWFzZSBzZWUg YSBmdWxsCnZlcnNpb24gb2YgdGhlIGZ1bmN0aW9uOgoKaW50IF9vcHBfY29tcGFyZV9rZXkoc3Ry dWN0IGRldl9wbV9vcHAgKm9wcDEsIHN0cnVjdCBkZXZfcG1fb3BwICpvcHAyLAogICAgICAgICBi b29sIHJhdGVfbm90X2F2YWlsYWJsZSkKewogIGlmICghcmF0ZV9ub3RfYXZhaWxhYmxlICYmIG9w cDEtPnJhdGUgIT0gb3BwMi0+cmF0ZSkKICAgIHJldHVybiBvcHAxLT5yYXRlIDwgb3BwMi0+cmF0 ZSA/IC0xIDogMTsKICBpZiAob3BwMS0+YmFuZHdpZHRoICYmIG9wcDItPmJhbmR3aWR0aCAmJgog ICAgICBvcHAxLT5iYW5kd2lkdGhbMF0ucGVhayAhPSBvcHAyLT5iYW5kd2lkdGhbMF0ucGVhaykK ICAgIHJldHVybiBvcHAxLT5iYW5kd2lkdGhbMF0ucGVhayA8IG9wcDItPmJhbmR3aWR0aFswXS5w ZWFrID8gLTEgOiAxOwogIGlmIChvcHAxLT5sZXZlbCAhPSBvcHAyLT5sZXZlbCkKICAgIHJldHVy biBvcHAxLT5sZXZlbCA8IG9wcDItPmxldmVsID8gLTEgOiAxOwogIHJldHVybiAwOwp9CgpQZXJo YXBzIHdlIGNvdWxkIGNoZWNrIHdoZXRoZXIgb3BwMS0+cmF0ZT0wLCBsaWtlIGl0J3MgZG9uZSBm b3IgdGhlCm9wcDEtPmJhbmR3aWR0aC4gSSdsbCBjb25zaWRlciB0aGlzIHZhcmlhbnQgZm9yIHYz LCB0aGFua3MuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkZXZlbCBtYWlsaW5nIGxpc3QKZGV2ZWxAbGludXhkcml2ZXJwcm9qZWN0Lm9yZwpodHRwOi8v ZHJpdmVyZGV2LmxpbnV4ZHJpdmVycHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcml2ZXJk ZXYtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.6 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 622B6C433E6 for ; Wed, 23 Dec 2020 10:51:54 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 12AA4207F7 for ; Wed, 23 Dec 2020 10:51:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 12AA4207F7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6E9BC6E8EA; Wed, 23 Dec 2020 10:51:33 +0000 (UTC) Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by gabe.freedesktop.org (Postfix) with ESMTPS id E23BF6E16D for ; Tue, 22 Dec 2020 19:19:29 +0000 (UTC) Received: by mail-lf1-x12e.google.com with SMTP id m12so34537470lfo.7 for ; Tue, 22 Dec 2020 11:19:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ulrdoVbGsjwhkH0t5gig0hbyBd9UYXc8gP96903YDxw=; b=TfyVQnVt/DSKdLojw95WJ4Y3kr9B3JreJXSNeZLBEluhzjCcPf6K2C/ui4C3A+RAcn NzqrO2ZQ73TaLD5uGBoTA4sttmca1xpwHqU863FtGcUC88cxmEAsuxQikrmwuidA4uCP nm3AAm9TZcl214JdJVxmbY480arDu40d/ZRO/LMZqIPpdTU56ZnmabVMuRGGAvhILYBZ Lo8a4O4xH2G8xK6eSxS2dJykl50tEw6QNTNuUIOxtAh5QuaHw5oC9C+9K8KQXGYHYHDU yCrcC+UxT5hZUbtUNDzWRin0i+Cl3uko4BCCxLbueXyFERpjQkeXnBMSkzUwEXUzI6/8 3Csg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ulrdoVbGsjwhkH0t5gig0hbyBd9UYXc8gP96903YDxw=; b=JNnssSRzWhVwO1t1XOqa3D4rfUL40dV3xhJmdw0QZE2fP/WFFYahOqYIM0914eXZJw en9+uiGavrtIkOMfJthyo90TlHMJDTm9l8DV+gvf6f2th4skwkdlv/xIS2FouqhPAdIE Zfm8Oibxd5Qt0unHnyfQwZaOIPyssjZS4bQEcTpQPs8+PKPgJ2fJsfB3LSbqF/t/xN6v Ibm0Q7Z48yDpo9xw3oHWO4if736/w13dxJ1W3oapKyxepRfs9qg7RORjx90gCeT3cW6d CkmwnLTG/sLjEIPTdVQB9XCmuAJeRX8QFbh2QqaX7M7Yc0doxoM72gDTjitZG5RagIym Nh7w== X-Gm-Message-State: AOAM532NoLTLH739egLeTMQ/0pDiQ6+C3jbHL/cyc8LPkuAbDVZwqVwj i6xUGESnpuGxz1SfUC7T7oQ= X-Google-Smtp-Source: ABdhPJyniuH4JIVLYX09aJTJXG2DPOZ3u4RjQh1NfGfdwzaSui65HwnwuqSmtJhso1bwXfgrrij1mg== X-Received: by 2002:ac2:46e4:: with SMTP id q4mr8665320lfo.413.1608664768348; Tue, 22 Dec 2020 11:19:28 -0800 (PST) Received: from [192.168.2.145] (109-252-192-57.dynamic.spd-mgts.ru. [109.252.192.57]) by smtp.googlemail.com with ESMTPSA id w6sm3032131lji.74.2020.12.22.11.19.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Dec 2020 11:19:27 -0800 (PST) Subject: Re: [PATCH v2 19/48] opp: Fix adding OPP entries in a wrong order if rate is unavailable To: Viresh Kumar References: <20201217180638.22748-1-digetx@gmail.com> <20201217180638.22748-20-digetx@gmail.com> <20201222091255.wentz5hyt726qezg@vireshk-i7> From: Dmitry Osipenko Message-ID: Date: Tue, 22 Dec 2020 22:19:26 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.2 MIME-Version: 1.0 In-Reply-To: <20201222091255.wentz5hyt726qezg@vireshk-i7> Content-Language: en-US X-Mailman-Approved-At: Wed, 23 Dec 2020 10:51:31 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , Michael Turquette , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thierry Reding , linux-clk@vger.kernel.org, devel@driverdev.osuosl.org, Kevin Hilman , Nicolas Chauvet , Viresh Kumar , Krzysztof Kozlowski , Jonathan Hunter , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , linux-tegra@vger.kernel.org, Mauro Carvalho Chehab , Stephen Boyd , Peter De Schrijver , "Rafael J. Wysocki" , Liam Girdwood , Mark Brown , Peter Geis Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" MjIuMTIuMjAyMCAxMjoxMiwgVmlyZXNoIEt1bWFyINC/0LjRiNC10YI6Cj4gT24gMTctMTItMjAs IDIxOjA2LCBEbWl0cnkgT3NpcGVua28gd3JvdGU6Cj4+IEZpeCBhZGRpbmcgT1BQIGVudHJpZXMg aW4gYSB3cm9uZyAob3Bwb3NpdGUpIG9yZGVyIGlmIE9QUCByYXRlIGlzCj4+IHVuYXZhaWxhYmxl LiBUaGUgT1BQIGNvbXBhcmlzb24gaXMgZXJyb25lb3VzbHkgc2tpcHBlZCBpZiBPUFAgcmF0ZSBp cwo+PiBtaXNzaW5nLCB0aHVzIE9QUHMgYXJlIGxlZnQgdW5zb3J0ZWQuCj4+Cj4+IFNpZ25lZC1v ZmYtYnk6IERtaXRyeSBPc2lwZW5rbyA8ZGlnZXR4QGdtYWlsLmNvbT4KPj4gLS0tCj4+ICBkcml2 ZXJzL29wcC9jb3JlLmMgfCAyMyArKysrKysrKysrKystLS0tLS0tLS0tLQo+PiAgZHJpdmVycy9v cHAvb3BwLmggIHwgIDIgKy0KPj4gIDIgZmlsZXMgY2hhbmdlZCwgMTMgaW5zZXJ0aW9ucygrKSwg MTIgZGVsZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL29wcC9jb3JlLmMgYi9k cml2ZXJzL29wcC9jb3JlLmMKPj4gaW5kZXggMzRmN2U1MzBkOTQxLi41YzdmMTMwYThkZTIgMTAw NjQ0Cj4+IC0tLSBhL2RyaXZlcnMvb3BwL2NvcmUuYwo+PiArKysgYi9kcml2ZXJzL29wcC9jb3Jl LmMKPj4gQEAgLTE1MzEsOSArMTUzMSwxMCBAQCBzdGF0aWMgYm9vbCBfb3BwX3N1cHBvcnRlZF9i eV9yZWd1bGF0b3JzKHN0cnVjdCBkZXZfcG1fb3BwICpvcHAsCj4+ICAJcmV0dXJuIHRydWU7Cj4+ ICB9Cj4+ICAKPj4gLWludCBfb3BwX2NvbXBhcmVfa2V5KHN0cnVjdCBkZXZfcG1fb3BwICpvcHAx LCBzdHJ1Y3QgZGV2X3BtX29wcCAqb3BwMikKPj4gK2ludCBfb3BwX2NvbXBhcmVfa2V5KHN0cnVj dCBkZXZfcG1fb3BwICpvcHAxLCBzdHJ1Y3QgZGV2X3BtX29wcCAqb3BwMiwKPj4gKwkJICAgICBi b29sIHJhdGVfbm90X2F2YWlsYWJsZSkKPj4gIHsKPj4gLQlpZiAob3BwMS0+cmF0ZSAhPSBvcHAy LT5yYXRlKQo+PiArCWlmICghcmF0ZV9ub3RfYXZhaWxhYmxlICYmIG9wcDEtPnJhdGUgIT0gb3Bw Mi0+cmF0ZSkKPiAKPiByYXRlIHdpbGwgYmUgMCBmb3IgYm90aCB0aGUgT1BQcyBoZXJlIGlmIHJh dGVfbm90X2F2YWlsYWJsZSBpcyB0cnVlIGFuZCBzbyB0aGlzCj4gY2hhbmdlIHNob3VsZG4ndCBi ZSByZXF1aXJlZC4KClRoZSByYXRlX25vdF9hdmFpbGFibGUgaXMgbmVnYXRlZCBpbiB0aGUgY29u ZGl0aW9uLiBUaGlzIGNoYW5nZSBpcwpyZXF1aXJlZCBiZWNhdXNlIGJvdGggcmF0ZXMgYXJlIDAg YW5kIHRoZW4gd2Ugc2hvdWxkIHByb2NlZWQgdG8gdGhlCmxldmVscyBjb21wYXJpc29uLgoKSSBn dWVzcyBpdCdzIG5vdCBjbGVhciBieSBsb29raW5nIGF0IHRoaXMgcGF0Y2gsIHBsZWFzZSBzZWUg YSBmdWxsCnZlcnNpb24gb2YgdGhlIGZ1bmN0aW9uOgoKaW50IF9vcHBfY29tcGFyZV9rZXkoc3Ry dWN0IGRldl9wbV9vcHAgKm9wcDEsIHN0cnVjdCBkZXZfcG1fb3BwICpvcHAyLAogICAgICAgICBi b29sIHJhdGVfbm90X2F2YWlsYWJsZSkKewogIGlmICghcmF0ZV9ub3RfYXZhaWxhYmxlICYmIG9w cDEtPnJhdGUgIT0gb3BwMi0+cmF0ZSkKICAgIHJldHVybiBvcHAxLT5yYXRlIDwgb3BwMi0+cmF0 ZSA/IC0xIDogMTsKICBpZiAob3BwMS0+YmFuZHdpZHRoICYmIG9wcDItPmJhbmR3aWR0aCAmJgog ICAgICBvcHAxLT5iYW5kd2lkdGhbMF0ucGVhayAhPSBvcHAyLT5iYW5kd2lkdGhbMF0ucGVhaykK ICAgIHJldHVybiBvcHAxLT5iYW5kd2lkdGhbMF0ucGVhayA8IG9wcDItPmJhbmR3aWR0aFswXS5w ZWFrID8gLTEgOiAxOwogIGlmIChvcHAxLT5sZXZlbCAhPSBvcHAyLT5sZXZlbCkKICAgIHJldHVy biBvcHAxLT5sZXZlbCA8IG9wcDItPmxldmVsID8gLTEgOiAxOwogIHJldHVybiAwOwp9CgpQZXJo YXBzIHdlIGNvdWxkIGNoZWNrIHdoZXRoZXIgb3BwMS0+cmF0ZT0wLCBsaWtlIGl0J3MgZG9uZSBm b3IgdGhlCm9wcDEtPmJhbmR3aWR0aC4gSSdsbCBjb25zaWRlciB0aGlzIHZhcmlhbnQgZm9yIHYz LCB0aGFua3MuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK