From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52EB7C47096 for ; Sun, 6 Jun 2021 17:54:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 256AF613DF for ; Sun, 6 Jun 2021 17:54:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229932AbhFFRrA (ORCPT ); Sun, 6 Jun 2021 13:47:00 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:18891 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229445AbhFFRq4 (ORCPT ); Sun, 6 Jun 2021 13:46:56 -0400 Received: from localhost (mailhub3.si.c-s.fr [192.168.12.233]) by localhost (Postfix) with ESMTP id 4FykRP4MdGzBBbh; Sun, 6 Jun 2021 19:45:05 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id snyJ6LhJy8YG; Sun, 6 Jun 2021 19:45:05 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 4FykRP3MfrzBBbc; Sun, 6 Jun 2021 19:45:05 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 65D1B8B770; Sun, 6 Jun 2021 19:45:05 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id kZKpm_gipPil; Sun, 6 Jun 2021 19:45:05 +0200 (CEST) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 09AB38B763; Sun, 6 Jun 2021 19:45:04 +0200 (CEST) Subject: Re: [PATCH] Fixup for "[v2] powerpc/8xx: Allow disabling KUAP at boot time" From: Christophe Leroy To: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org References: Message-ID: Date: Sun, 6 Jun 2021 19:45:04 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 06/06/2021 à 19:43, Christophe Leroy a écrit : Michael, I sent it as a Fixup because it's in next-test, but if you prefer I can sent a v3. Christophe > Kernel test robot reported: > >>> ERROR: modpost: "disable_kuap_key" [net/phonet/pn_pep.ko] undefined! >>> ERROR: modpost: "disable_kuap_key" [net/phonet/phonet.ko] undefined! >>> ERROR: modpost: "disable_kuap_key" [net/decnet/decnet.ko] undefined! >>> ERROR: modpost: "disable_kuap_key" [drivers/tee/tee.ko] undefined! >>> ERROR: modpost: "disable_kuap_key" [drivers/input/evdev.ko] undefined! >>> ERROR: modpost: "disable_kuap_key" [drivers/input/joydev.ko] undefined! >>> ERROR: modpost: "disable_kuap_key" [drivers/input/mousedev.ko] undefined! >>> ERROR: modpost: "disable_kuap_key" [drivers/input/serio/serio_raw.ko] undefined! >>> ERROR: modpost: "disable_kuap_key" [drivers/fsi/fsi-scom.ko] undefined! >>> ERROR: modpost: "disable_kuap_key" [drivers/watchdog/mv64x60_wdt.ko] undefined! > WARNING: modpost: suppressed 13 unresolved symbol warnings because there were too many) > > disable_kuap_key has to be exported. Use EXPORT_SYMBOL() as userspace > access function are not exported as GPL today. > > Reported-by: kernel test robot > Signed-off-by: Christophe Leroy > --- > arch/powerpc/mm/nohash/8xx.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/powerpc/mm/nohash/8xx.c b/arch/powerpc/mm/nohash/8xx.c > index a8d44e9342f3..fc663322ba58 100644 > --- a/arch/powerpc/mm/nohash/8xx.c > +++ b/arch/powerpc/mm/nohash/8xx.c > @@ -257,6 +257,7 @@ void __init setup_kuep(bool disabled) > > #ifdef CONFIG_PPC_KUAP > struct static_key_false disable_kuap_key; > +EXPORT_SYMBOL(disable_kuap_key); > > void __init setup_kuap(bool disabled) > { >