From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3081EC3F2D1 for ; Mon, 2 Mar 2020 12:09:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F0DC92187F for ; Mon, 2 Mar 2020 12:09:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583150978; bh=/kKqSL1/BQ+dOVDuB+J6MXMNhp46sJ9EIoVg6zdqQ0k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=Aw/zNOcxnqBayXRN5+uay2twaoOI5T/rim+b/WWZA1xhSwGv/HqjNOrxyxvxmEucg 89gjR8vKfAXI8B39Fu/tySuEeT44dqp5gqx5dJFro1qIYHZ2EMwKMSxvp8ATPUXtGs Ags5KfmN5ognsPgFzNUe2xnAJhwZmAagIlNfSIuA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725802AbgCBMJh (ORCPT ); Mon, 2 Mar 2020 07:09:37 -0500 Received: from mail.kernel.org ([198.145.29.99]:57840 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726654AbgCBMJg (ORCPT ); Mon, 2 Mar 2020 07:09:36 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A63412173E; Mon, 2 Mar 2020 12:09:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583150975; bh=/kKqSL1/BQ+dOVDuB+J6MXMNhp46sJ9EIoVg6zdqQ0k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=UnW9k+By/DJjzanJO2aiRSCSCFKWrDOefChvcbg6RBUFUzBw2gsqv1/BH1n5DulSX qfg5Vv7O8iWGhLzFd2FAYgd2CPUhZ+uf4XUhRoHa8TO67Mtp1lPlt1CTcubTRy9nX6 +wwCEHHTAub0pmgm1s4geTfluo33PLANPc6F94W8= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1j8jt7-009N70-ST; Mon, 02 Mar 2020 12:09:34 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Mon, 02 Mar 2020 12:09:33 +0000 From: Marc Zyngier To: Zenghui Yu Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Lorenzo Pieralisi , Jason Cooper , Robert Richter , Thomas Gleixner , Eric Auger , James Morse , Julien Thierry , Suzuki K Poulose Subject: Re: [PATCH v4 08/20] irqchip/gic-v4.1: Plumb get/set_irqchip_state SGI callbacks In-Reply-To: <4f8f3958-2976-b0a7-8d17-440ecaba0fc8@huawei.com> References: <20200214145736.18550-1-maz@kernel.org> <20200214145736.18550-9-maz@kernel.org> <4b7f71f1-5e7f-e6af-f47d-7ed0d3a8739f@huawei.com> <75597af0d2373ac4d92d8162a1338cbb@kernel.org> <19a7c193f0e4b97343e822a35f0911ed@kernel.org> <3d725ede-6631-59fb-1a10-9fb9890f3df6@huawei.com> <54c52057161f925c818446953050c951@kernel.org> <4f8f3958-2976-b0a7-8d17-440ecaba0fc8@huawei.com> Message-ID: X-Sender: maz@kernel.org User-Agent: Roundcube Webmail/1.3.10 X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: yuzenghui@huawei.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, lorenzo.pieralisi@arm.com, jason@lakedaemon.net, rrichter@marvell.com, tglx@linutronix.de, eric.auger@redhat.com, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Zenghui, On 2020-03-02 08:18, Zenghui Yu wrote: > On 2020/3/2 3:00, Marc Zyngier wrote: >> On 2020-02-28 19:37, Marc Zyngier wrote: >>> On 2020-02-20 03:11, Zenghui Yu wrote: >> >>>> Do we really need to grab the vpe_lock for those which are belong to >>>> the same irqchip with its_vpe_set_affinity()? The IRQ core code >>>> should >>>> already ensure the mutual exclusion among them, wrong? >>> >>> I've been trying to think about that, but jet-lag keeps getting in >>> the way. >>> I empirically think that you are right, but I need to go and check >>> the various >>> code paths to be sure. Hopefully I'll have a bit more brain space >>> next week. >> >> So I slept on it and came back to my senses. The only case we actually >> need >> to deal with is when an affinity change impacts *another* interrupt. >> >> There is only two instances of this issue: >> >> - vLPIs have their *physical* affinity impacted by the affinity of the >>   vPE. Their virtual affinity is of course unchanged, but the >> physical >>   one becomes important with direct invalidation. Taking a per-VPE >> lock >>   in such context should address the issue. >> >> - vSGIs have the exact same issue, plus the matter of requiring some >>   *extra* one when reading the pending state, which requires a RMW >>   on two different registers. This requires an extra per-RD lock. > > Agreed with both! > >> >> My original patch was stupidly complex, and the irq_desc lock is >> perfectly enough to deal with anything that only affects the interrupt >> state itself. >> >> GICv4 + direct invalidation for vLPIs breaks this by bypassing the >> serialization initially provided by the ITS, as the RD is completely >> out of band. The per-vPE lock brings back this serialization. >> >> I've updated the branch, which seems to run OK on D05. I still need >> to run the usual tests on the FVP model though. > > I have pulled the latest branch and it looks good to me, except for > one remaining concern: > > GICR_INV{LPI, ALL}R + GICR_SYNCR can also be accessed concurrently > by multiple direct invalidation, should we also use the per-RD lock > to ensure mutual exclusion? It looks not so harmful though, as this > will only increase one's polling time against the Busy bit (in my > view). > > But I point it out again for confirmation. I was about to say that it doesn't really matter because it is only a performance optimisation (and we're noty quite there yet), until I spotted this great nugget in the spec: Writing GICR_INVLPIR or GICR_INVALLR when GICR_SYNCR.Busy==1 is CONSTRAINED UNPREDICTABLE: - The write is IGNORED . - The invalidate specified by the write is performed. So we really need some form of mutual exclusion on a per-RD basis to ensure that no two invalidations occur at the same time, ensuring that Busy clears between the two. Thanks for the heads up, M. -- Jazz is not dead. It just smells funny... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA196C3F2D1 for ; Mon, 2 Mar 2020 12:09:43 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 2E1DE2187F for ; Mon, 2 Mar 2020 12:09:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="UnW9k+By" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2E1DE2187F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id AD9854AF7C; Mon, 2 Mar 2020 07:09:42 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UxEKKKLBIzRt; Mon, 2 Mar 2020 07:09:40 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 4EE8B4AF75; Mon, 2 Mar 2020 07:09:40 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id ED0854AF75 for ; Mon, 2 Mar 2020 07:09:38 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id n969HvUBffJ8 for ; Mon, 2 Mar 2020 07:09:37 -0500 (EST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id E150F4AF46 for ; Mon, 2 Mar 2020 07:09:36 -0500 (EST) Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A63412173E; Mon, 2 Mar 2020 12:09:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583150975; bh=/kKqSL1/BQ+dOVDuB+J6MXMNhp46sJ9EIoVg6zdqQ0k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=UnW9k+By/DJjzanJO2aiRSCSCFKWrDOefChvcbg6RBUFUzBw2gsqv1/BH1n5DulSX qfg5Vv7O8iWGhLzFd2FAYgd2CPUhZ+uf4XUhRoHa8TO67Mtp1lPlt1CTcubTRy9nX6 +wwCEHHTAub0pmgm1s4geTfluo33PLANPc6F94W8= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1j8jt7-009N70-ST; Mon, 02 Mar 2020 12:09:34 +0000 MIME-Version: 1.0 Date: Mon, 02 Mar 2020 12:09:33 +0000 From: Marc Zyngier To: Zenghui Yu Subject: Re: [PATCH v4 08/20] irqchip/gic-v4.1: Plumb get/set_irqchip_state SGI callbacks In-Reply-To: <4f8f3958-2976-b0a7-8d17-440ecaba0fc8@huawei.com> References: <20200214145736.18550-1-maz@kernel.org> <20200214145736.18550-9-maz@kernel.org> <4b7f71f1-5e7f-e6af-f47d-7ed0d3a8739f@huawei.com> <75597af0d2373ac4d92d8162a1338cbb@kernel.org> <19a7c193f0e4b97343e822a35f0911ed@kernel.org> <3d725ede-6631-59fb-1a10-9fb9890f3df6@huawei.com> <54c52057161f925c818446953050c951@kernel.org> <4f8f3958-2976-b0a7-8d17-440ecaba0fc8@huawei.com> Message-ID: X-Sender: maz@kernel.org User-Agent: Roundcube Webmail/1.3.10 X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: yuzenghui@huawei.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, lorenzo.pieralisi@arm.com, jason@lakedaemon.net, rrichter@marvell.com, tglx@linutronix.de, eric.auger@redhat.com, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: Lorenzo Pieralisi , Jason Cooper , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Robert Richter , Thomas Gleixner , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu SGkgWmVuZ2h1aSwKCk9uIDIwMjAtMDMtMDIgMDg6MTgsIFplbmdodWkgWXUgd3JvdGU6Cj4gT24g MjAyMC8zLzIgMzowMCwgTWFyYyBaeW5naWVyIHdyb3RlOgo+PiBPbiAyMDIwLTAyLTI4IDE5OjM3 LCBNYXJjIFp5bmdpZXIgd3JvdGU6Cj4+PiBPbiAyMDIwLTAyLTIwIDAzOjExLCBaZW5naHVpIFl1 IHdyb3RlOgo+PiAKPj4+PiBEbyB3ZSByZWFsbHkgbmVlZCB0byBncmFiIHRoZSB2cGVfbG9jayBm b3IgdGhvc2Ugd2hpY2ggYXJlIGJlbG9uZyB0bwo+Pj4+IHRoZSBzYW1lIGlycWNoaXAgd2l0aCBp dHNfdnBlX3NldF9hZmZpbml0eSgpPyBUaGUgSVJRIGNvcmUgY29kZSAKPj4+PiBzaG91bGQKPj4+ PiBhbHJlYWR5IGVuc3VyZSB0aGUgbXV0dWFsIGV4Y2x1c2lvbiBhbW9uZyB0aGVtLCB3cm9uZz8K Pj4+IAo+Pj4gSSd2ZSBiZWVuIHRyeWluZyB0byB0aGluayBhYm91dCB0aGF0LCBidXQgamV0LWxh ZyBrZWVwcyBnZXR0aW5nIGluIAo+Pj4gdGhlIHdheS4KPj4+IEkgZW1waXJpY2FsbHkgdGhpbmsg dGhhdCB5b3UgYXJlIHJpZ2h0LCBidXQgSSBuZWVkIHRvIGdvIGFuZCBjaGVjayAKPj4+IHRoZSB2 YXJpb3VzCj4+PiBjb2RlIHBhdGhzIHRvIGJlIHN1cmUuIEhvcGVmdWxseSBJJ2xsIGhhdmUgYSBi aXQgbW9yZSBicmFpbiBzcGFjZSAKPj4+IG5leHQgd2Vlay4KPj4gCj4+IFNvIEkgc2xlcHQgb24g aXQgYW5kIGNhbWUgYmFjayB0byBteSBzZW5zZXMuIFRoZSBvbmx5IGNhc2Ugd2UgYWN0dWFsbHkg Cj4+IG5lZWQKPj4gdG8gZGVhbCB3aXRoIGlzIHdoZW4gYW4gYWZmaW5pdHkgY2hhbmdlIGltcGFj dHMgKmFub3RoZXIqIGludGVycnVwdC4KPj4gCj4+IFRoZXJlIGlzIG9ubHkgdHdvIGluc3RhbmNl cyBvZiB0aGlzIGlzc3VlOgo+PiAKPj4gLSB2TFBJcyBoYXZlIHRoZWlyICpwaHlzaWNhbCogYWZm aW5pdHkgaW1wYWN0ZWQgYnkgdGhlIGFmZmluaXR5IG9mIHRoZQo+PiAgwqAgdlBFLiBUaGVpciB2 aXJ0dWFsIGFmZmluaXR5IGlzIG9mIGNvdXJzZSB1bmNoYW5nZWQsIGJ1dCB0aGUgCj4+IHBoeXNp Y2FsCj4+ICDCoCBvbmUgYmVjb21lcyBpbXBvcnRhbnQgd2l0aCBkaXJlY3QgaW52YWxpZGF0aW9u LiBUYWtpbmcgYSBwZXItVlBFIAo+PiBsb2NrCj4+ICDCoCBpbiBzdWNoIGNvbnRleHQgc2hvdWxk IGFkZHJlc3MgdGhlIGlzc3VlLgo+PiAKPj4gLSB2U0dJcyBoYXZlIHRoZSBleGFjdCBzYW1lIGlz c3VlLCBwbHVzIHRoZSBtYXR0ZXIgb2YgcmVxdWlyaW5nIHNvbWUKPj4gIMKgICpleHRyYSogb25l IHdoZW4gcmVhZGluZyB0aGUgcGVuZGluZyBzdGF0ZSwgd2hpY2ggcmVxdWlyZXMgYSBSTVcKPj4g IMKgIG9uIHR3byBkaWZmZXJlbnQgcmVnaXN0ZXJzLiBUaGlzIHJlcXVpcmVzIGFuIGV4dHJhIHBl ci1SRCBsb2NrLgo+IAo+IEFncmVlZCB3aXRoIGJvdGghCj4gCj4+IAo+PiBNeSBvcmlnaW5hbCBw YXRjaCB3YXMgc3R1cGlkbHkgY29tcGxleCwgYW5kIHRoZSBpcnFfZGVzYyBsb2NrIGlzCj4+IHBl cmZlY3RseSBlbm91Z2ggdG8gZGVhbCB3aXRoIGFueXRoaW5nIHRoYXQgb25seSBhZmZlY3RzIHRo ZSBpbnRlcnJ1cHQKPj4gc3RhdGUgaXRzZWxmLgo+PiAKPj4gR0lDdjQgKyBkaXJlY3QgaW52YWxp ZGF0aW9uIGZvciB2TFBJcyBicmVha3MgdGhpcyBieSBieXBhc3NpbmcgdGhlCj4+IHNlcmlhbGl6 YXRpb24gaW5pdGlhbGx5IHByb3ZpZGVkIGJ5IHRoZSBJVFMsIGFzIHRoZSBSRCBpcyBjb21wbGV0 ZWx5Cj4+IG91dCBvZiBiYW5kLiBUaGUgcGVyLXZQRSBsb2NrIGJyaW5ncyBiYWNrIHRoaXMgc2Vy aWFsaXphdGlvbi4KPj4gCj4+IEkndmUgdXBkYXRlZCB0aGUgYnJhbmNoLCB3aGljaCBzZWVtcyB0 byBydW4gT0sgb24gRDA1LiBJIHN0aWxsIG5lZWQKPj4gdG8gcnVuIHRoZSB1c3VhbCB0ZXN0cyBv biB0aGUgRlZQIG1vZGVsIHRob3VnaC4KPiAKPiBJIGhhdmUgcHVsbGVkIHRoZSBsYXRlc3QgYnJh bmNoIGFuZCBpdCBsb29rcyBnb29kIHRvIG1lLCBleGNlcHQgZm9yCj4gb25lIHJlbWFpbmluZyBj b25jZXJuOgo+IAo+IEdJQ1JfSU5We0xQSSwgQUxMfVIgKyBHSUNSX1NZTkNSIGNhbiBhbHNvIGJl IGFjY2Vzc2VkIGNvbmN1cnJlbnRseQo+IGJ5IG11bHRpcGxlIGRpcmVjdCBpbnZhbGlkYXRpb24s IHNob3VsZCB3ZSBhbHNvIHVzZSB0aGUgcGVyLVJEIGxvY2sKPiB0byBlbnN1cmUgbXV0dWFsIGV4 Y2x1c2lvbj8gIEl0IGxvb2tzIG5vdCBzbyBoYXJtZnVsIHRob3VnaCwgYXMgdGhpcwo+IHdpbGwg b25seSBpbmNyZWFzZSBvbmUncyBwb2xsaW5nIHRpbWUgYWdhaW5zdCB0aGUgQnVzeSBiaXQgKGlu IG15IAo+IHZpZXcpLgo+IAo+IEJ1dCBJIHBvaW50IGl0IG91dCBhZ2FpbiBmb3IgY29uZmlybWF0 aW9uLgoKSSB3YXMgYWJvdXQgdG8gc2F5IHRoYXQgaXQgZG9lc24ndCByZWFsbHkgbWF0dGVyIGJl Y2F1c2UgaXQgaXMgb25seSBhCnBlcmZvcm1hbmNlIG9wdGltaXNhdGlvbiAoYW5kIHdlJ3JlIG5v dHkgcXVpdGUgdGhlcmUgeWV0KSwgdW50aWwgSSAKc3BvdHRlZAp0aGlzIGdyZWF0IG51Z2dldCBp biB0aGUgc3BlYzoKCjxxdW90ZT4KV3JpdGluZyBHSUNSX0lOVkxQSVIgb3IgR0lDUl9JTlZBTExS IHdoZW4gR0lDUl9TWU5DUi5CdXN5PT0xIGlzIApDT05TVFJBSU5FRApVTlBSRURJQ1RBQkxFOgot IFRoZSB3cml0ZSBpcyBJR05PUkVEIC4KLSBUaGUgaW52YWxpZGF0ZSBzcGVjaWZpZWQgYnkgdGhl IHdyaXRlIGlzIHBlcmZvcm1lZC4KPC9xdW90ZT4KClNvIHdlIHJlYWxseSBuZWVkIHNvbWUgZm9y bSBvZiBtdXR1YWwgZXhjbHVzaW9uIG9uIGEgcGVyLVJEIGJhc2lzIHRvIAplbnN1cmUKdGhhdCBu byB0d28gaW52YWxpZGF0aW9ucyBvY2N1ciBhdCB0aGUgc2FtZSB0aW1lLCBlbnN1cmluZyB0aGF0 IEJ1c3kgCmNsZWFycwpiZXR3ZWVuIHRoZSB0d28uCgpUaGFua3MgZm9yIHRoZSBoZWFkcyB1cCwK CiAgICAgICAgIE0uCi0tIApKYXp6IGlzIG5vdCBkZWFkLiBJdCBqdXN0IHNtZWxscyBmdW5ueS4u LgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwprdm1hcm0g bWFpbGluZyBsaXN0Cmt2bWFybUBsaXN0cy5jcy5jb2x1bWJpYS5lZHUKaHR0cHM6Ly9saXN0cy5j cy5jb2x1bWJpYS5lZHUvbWFpbG1hbi9saXN0aW5mby9rdm1hcm0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A0ECC3F2D2 for ; Mon, 2 Mar 2020 12:09:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE7712173E for ; Mon, 2 Mar 2020 12:09:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kakhABjm"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="UnW9k+By" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE7712173E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kOeq4QqWG8tqwQi9izXVZ6ufVxDT8TiAf3BixHVpu3Y=; b=kakhABjm7f+YcQ4zzsHMGA3Fh FXmLsMXeOopZqj29BMSGw77hnuzsYLsHeYQH2FM4uXtLIogsGWWTj7UKbYZDzpiqN6tO50NqMd2q6 4cNvmgMAqX86vUAVqFfxxj5Y94W8gohgwQiwc2UPDIQlg3zX9O3IHA0IQjjyjlVu8mzcXEFD/ybYA IEbvMt5W06zR/zabRe5NvQWTp5RN1Em6v64hhnVaGxFqv6/fTPcSHmU63bCBzbjSQK2vqjX9ukaht 5JPRgEAKJHG1NBjNOvRHLr7B+1DOIAn3WvHHXNyypDCUCd/DK1AzU/nShOWSw7VC28oDp25wyFUVA POp+Z7vaA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j8jtG-0000Z5-A8; Mon, 02 Mar 2020 12:09:42 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j8jtA-0000YU-7o for linux-arm-kernel@lists.infradead.org; Mon, 02 Mar 2020 12:09:37 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A63412173E; Mon, 2 Mar 2020 12:09:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583150975; bh=/kKqSL1/BQ+dOVDuB+J6MXMNhp46sJ9EIoVg6zdqQ0k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=UnW9k+By/DJjzanJO2aiRSCSCFKWrDOefChvcbg6RBUFUzBw2gsqv1/BH1n5DulSX qfg5Vv7O8iWGhLzFd2FAYgd2CPUhZ+uf4XUhRoHa8TO67Mtp1lPlt1CTcubTRy9nX6 +wwCEHHTAub0pmgm1s4geTfluo33PLANPc6F94W8= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1j8jt7-009N70-ST; Mon, 02 Mar 2020 12:09:34 +0000 MIME-Version: 1.0 Date: Mon, 02 Mar 2020 12:09:33 +0000 From: Marc Zyngier To: Zenghui Yu Subject: Re: [PATCH v4 08/20] irqchip/gic-v4.1: Plumb get/set_irqchip_state SGI callbacks In-Reply-To: <4f8f3958-2976-b0a7-8d17-440ecaba0fc8@huawei.com> References: <20200214145736.18550-1-maz@kernel.org> <20200214145736.18550-9-maz@kernel.org> <4b7f71f1-5e7f-e6af-f47d-7ed0d3a8739f@huawei.com> <75597af0d2373ac4d92d8162a1338cbb@kernel.org> <19a7c193f0e4b97343e822a35f0911ed@kernel.org> <3d725ede-6631-59fb-1a10-9fb9890f3df6@huawei.com> <54c52057161f925c818446953050c951@kernel.org> <4f8f3958-2976-b0a7-8d17-440ecaba0fc8@huawei.com> Message-ID: X-Sender: maz@kernel.org User-Agent: Roundcube Webmail/1.3.10 X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: yuzenghui@huawei.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, lorenzo.pieralisi@arm.com, jason@lakedaemon.net, rrichter@marvell.com, tglx@linutronix.de, eric.auger@redhat.com, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200302_040936_319944_4368F25C X-CRM114-Status: GOOD ( 16.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lorenzo Pieralisi , Jason Cooper , kvm@vger.kernel.org, Suzuki K Poulose , linux-kernel@vger.kernel.org, Eric Auger , Robert Richter , James Morse , Julien Thierry , Thomas Gleixner , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgWmVuZ2h1aSwKCk9uIDIwMjAtMDMtMDIgMDg6MTgsIFplbmdodWkgWXUgd3JvdGU6Cj4gT24g MjAyMC8zLzIgMzowMCwgTWFyYyBaeW5naWVyIHdyb3RlOgo+PiBPbiAyMDIwLTAyLTI4IDE5OjM3 LCBNYXJjIFp5bmdpZXIgd3JvdGU6Cj4+PiBPbiAyMDIwLTAyLTIwIDAzOjExLCBaZW5naHVpIFl1 IHdyb3RlOgo+PiAKPj4+PiBEbyB3ZSByZWFsbHkgbmVlZCB0byBncmFiIHRoZSB2cGVfbG9jayBm b3IgdGhvc2Ugd2hpY2ggYXJlIGJlbG9uZyB0bwo+Pj4+IHRoZSBzYW1lIGlycWNoaXAgd2l0aCBp dHNfdnBlX3NldF9hZmZpbml0eSgpPyBUaGUgSVJRIGNvcmUgY29kZSAKPj4+PiBzaG91bGQKPj4+ PiBhbHJlYWR5IGVuc3VyZSB0aGUgbXV0dWFsIGV4Y2x1c2lvbiBhbW9uZyB0aGVtLCB3cm9uZz8K Pj4+IAo+Pj4gSSd2ZSBiZWVuIHRyeWluZyB0byB0aGluayBhYm91dCB0aGF0LCBidXQgamV0LWxh ZyBrZWVwcyBnZXR0aW5nIGluIAo+Pj4gdGhlIHdheS4KPj4+IEkgZW1waXJpY2FsbHkgdGhpbmsg dGhhdCB5b3UgYXJlIHJpZ2h0LCBidXQgSSBuZWVkIHRvIGdvIGFuZCBjaGVjayAKPj4+IHRoZSB2 YXJpb3VzCj4+PiBjb2RlIHBhdGhzIHRvIGJlIHN1cmUuIEhvcGVmdWxseSBJJ2xsIGhhdmUgYSBi aXQgbW9yZSBicmFpbiBzcGFjZSAKPj4+IG5leHQgd2Vlay4KPj4gCj4+IFNvIEkgc2xlcHQgb24g aXQgYW5kIGNhbWUgYmFjayB0byBteSBzZW5zZXMuIFRoZSBvbmx5IGNhc2Ugd2UgYWN0dWFsbHkg Cj4+IG5lZWQKPj4gdG8gZGVhbCB3aXRoIGlzIHdoZW4gYW4gYWZmaW5pdHkgY2hhbmdlIGltcGFj dHMgKmFub3RoZXIqIGludGVycnVwdC4KPj4gCj4+IFRoZXJlIGlzIG9ubHkgdHdvIGluc3RhbmNl cyBvZiB0aGlzIGlzc3VlOgo+PiAKPj4gLSB2TFBJcyBoYXZlIHRoZWlyICpwaHlzaWNhbCogYWZm aW5pdHkgaW1wYWN0ZWQgYnkgdGhlIGFmZmluaXR5IG9mIHRoZQo+PiAgwqAgdlBFLiBUaGVpciB2 aXJ0dWFsIGFmZmluaXR5IGlzIG9mIGNvdXJzZSB1bmNoYW5nZWQsIGJ1dCB0aGUgCj4+IHBoeXNp Y2FsCj4+ICDCoCBvbmUgYmVjb21lcyBpbXBvcnRhbnQgd2l0aCBkaXJlY3QgaW52YWxpZGF0aW9u LiBUYWtpbmcgYSBwZXItVlBFIAo+PiBsb2NrCj4+ICDCoCBpbiBzdWNoIGNvbnRleHQgc2hvdWxk IGFkZHJlc3MgdGhlIGlzc3VlLgo+PiAKPj4gLSB2U0dJcyBoYXZlIHRoZSBleGFjdCBzYW1lIGlz c3VlLCBwbHVzIHRoZSBtYXR0ZXIgb2YgcmVxdWlyaW5nIHNvbWUKPj4gIMKgICpleHRyYSogb25l IHdoZW4gcmVhZGluZyB0aGUgcGVuZGluZyBzdGF0ZSwgd2hpY2ggcmVxdWlyZXMgYSBSTVcKPj4g IMKgIG9uIHR3byBkaWZmZXJlbnQgcmVnaXN0ZXJzLiBUaGlzIHJlcXVpcmVzIGFuIGV4dHJhIHBl ci1SRCBsb2NrLgo+IAo+IEFncmVlZCB3aXRoIGJvdGghCj4gCj4+IAo+PiBNeSBvcmlnaW5hbCBw YXRjaCB3YXMgc3R1cGlkbHkgY29tcGxleCwgYW5kIHRoZSBpcnFfZGVzYyBsb2NrIGlzCj4+IHBl cmZlY3RseSBlbm91Z2ggdG8gZGVhbCB3aXRoIGFueXRoaW5nIHRoYXQgb25seSBhZmZlY3RzIHRo ZSBpbnRlcnJ1cHQKPj4gc3RhdGUgaXRzZWxmLgo+PiAKPj4gR0lDdjQgKyBkaXJlY3QgaW52YWxp ZGF0aW9uIGZvciB2TFBJcyBicmVha3MgdGhpcyBieSBieXBhc3NpbmcgdGhlCj4+IHNlcmlhbGl6 YXRpb24gaW5pdGlhbGx5IHByb3ZpZGVkIGJ5IHRoZSBJVFMsIGFzIHRoZSBSRCBpcyBjb21wbGV0 ZWx5Cj4+IG91dCBvZiBiYW5kLiBUaGUgcGVyLXZQRSBsb2NrIGJyaW5ncyBiYWNrIHRoaXMgc2Vy aWFsaXphdGlvbi4KPj4gCj4+IEkndmUgdXBkYXRlZCB0aGUgYnJhbmNoLCB3aGljaCBzZWVtcyB0 byBydW4gT0sgb24gRDA1LiBJIHN0aWxsIG5lZWQKPj4gdG8gcnVuIHRoZSB1c3VhbCB0ZXN0cyBv biB0aGUgRlZQIG1vZGVsIHRob3VnaC4KPiAKPiBJIGhhdmUgcHVsbGVkIHRoZSBsYXRlc3QgYnJh bmNoIGFuZCBpdCBsb29rcyBnb29kIHRvIG1lLCBleGNlcHQgZm9yCj4gb25lIHJlbWFpbmluZyBj b25jZXJuOgo+IAo+IEdJQ1JfSU5We0xQSSwgQUxMfVIgKyBHSUNSX1NZTkNSIGNhbiBhbHNvIGJl IGFjY2Vzc2VkIGNvbmN1cnJlbnRseQo+IGJ5IG11bHRpcGxlIGRpcmVjdCBpbnZhbGlkYXRpb24s IHNob3VsZCB3ZSBhbHNvIHVzZSB0aGUgcGVyLVJEIGxvY2sKPiB0byBlbnN1cmUgbXV0dWFsIGV4 Y2x1c2lvbj8gIEl0IGxvb2tzIG5vdCBzbyBoYXJtZnVsIHRob3VnaCwgYXMgdGhpcwo+IHdpbGwg b25seSBpbmNyZWFzZSBvbmUncyBwb2xsaW5nIHRpbWUgYWdhaW5zdCB0aGUgQnVzeSBiaXQgKGlu IG15IAo+IHZpZXcpLgo+IAo+IEJ1dCBJIHBvaW50IGl0IG91dCBhZ2FpbiBmb3IgY29uZmlybWF0 aW9uLgoKSSB3YXMgYWJvdXQgdG8gc2F5IHRoYXQgaXQgZG9lc24ndCByZWFsbHkgbWF0dGVyIGJl Y2F1c2UgaXQgaXMgb25seSBhCnBlcmZvcm1hbmNlIG9wdGltaXNhdGlvbiAoYW5kIHdlJ3JlIG5v dHkgcXVpdGUgdGhlcmUgeWV0KSwgdW50aWwgSSAKc3BvdHRlZAp0aGlzIGdyZWF0IG51Z2dldCBp biB0aGUgc3BlYzoKCjxxdW90ZT4KV3JpdGluZyBHSUNSX0lOVkxQSVIgb3IgR0lDUl9JTlZBTExS IHdoZW4gR0lDUl9TWU5DUi5CdXN5PT0xIGlzIApDT05TVFJBSU5FRApVTlBSRURJQ1RBQkxFOgot IFRoZSB3cml0ZSBpcyBJR05PUkVEIC4KLSBUaGUgaW52YWxpZGF0ZSBzcGVjaWZpZWQgYnkgdGhl IHdyaXRlIGlzIHBlcmZvcm1lZC4KPC9xdW90ZT4KClNvIHdlIHJlYWxseSBuZWVkIHNvbWUgZm9y bSBvZiBtdXR1YWwgZXhjbHVzaW9uIG9uIGEgcGVyLVJEIGJhc2lzIHRvIAplbnN1cmUKdGhhdCBu byB0d28gaW52YWxpZGF0aW9ucyBvY2N1ciBhdCB0aGUgc2FtZSB0aW1lLCBlbnN1cmluZyB0aGF0 IEJ1c3kgCmNsZWFycwpiZXR3ZWVuIHRoZSB0d28uCgpUaGFua3MgZm9yIHRoZSBoZWFkcyB1cCwK CiAgICAgICAgIE0uCi0tIApKYXp6IGlzIG5vdCBkZWFkLiBJdCBqdXN0IHNtZWxscyBmdW5ueS4u LgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgt YXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQu b3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJt LWtlcm5lbAo=