From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42912) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhSd3-0004gK-LY for qemu-devel@nongnu.org; Tue, 06 Sep 2016 22:30:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bhScz-0004Eb-E5 for qemu-devel@nongnu.org; Tue, 06 Sep 2016 22:30:20 -0400 Received: from mail-pf0-x243.google.com ([2607:f8b0:400e:c00::243]:33284) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhScz-0004EW-75 for qemu-devel@nongnu.org; Tue, 06 Sep 2016 22:30:17 -0400 Received: by mail-pf0-x243.google.com with SMTP id 128so139668pfb.0 for ; Tue, 06 Sep 2016 19:30:17 -0700 (PDT) Sender: Richard Henderson References: <1470929064-4092-1-git-send-email-alex.bennee@linaro.org> <1470929064-4092-7-git-send-email-alex.bennee@linaro.org> From: Richard Henderson Message-ID: Date: Tue, 6 Sep 2016 19:30:14 -0700 MIME-Version: 1.0 In-Reply-To: <1470929064-4092-7-git-send-email-alex.bennee@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [RFC v4 06/28] tcg: comment on which functions have to be called with tb_lock held List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , mttcg@greensocs.com, qemu-devel@nongnu.org, fred.konrad@greensocs.com, a.rigo@virtualopensystems.com, cota@braap.org, bobby.prani@gmail.com, nikunj@linux.vnet.ibm.com Cc: peter.maydell@linaro.org, claudio.fontana@huawei.com, Peter Crosthwaite , jan.kiszka@siemens.com, mark.burton@greensocs.com, serge.fdrv@gmail.com, pbonzini@redhat.com On 08/11/2016 08:24 AM, Alex Bennée wrote: > From: Paolo Bonzini > > softmmu requires more functions to be thread-safe, because translation > blocks can be invalidated from e.g. notdirty callbacks. Probably the > same holds for user-mode emulation, it's just that no one has ever > tried to produce a coherent locking there. > > This patch will guide the introduction of more tb_lock and tb_unlock > calls for system emulation. > > Note that after this patch some (most) of the mentioned functions are > still called outside tb_lock/tb_unlock. The next one will rectify this. > > Signed-off-by: Paolo Bonzini > Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson r~