From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH v1 16/19] tools/kvm_stat: add new interactive command 't' Date: Thu, 22 Jun 2017 09:52:18 +0200 Message-ID: References: <20170607190843.76869-1-raspl@linux.vnet.ibm.com> <20170607190843.76869-17-raspl@linux.vnet.ibm.com> <535a16ce-8f48-8446-5e4a-4d7e375086bd@redhat.com> <3ec6c83a-5554-2497-ed58-b6da6d3c6868@linux.vnet.ibm.com> <828a0b8f-f5d0-b11a-c2ef-b3b3f2c91e8c@redhat.com> <1803ed91-0d78-742f-66a7-a88dd4dc5786@linux.vnet.ibm.com> <9b5eb94a-94f5-817a-c371-8beb12f613f3@redhat.com> <19a20f2b-f143-a14e-e4da-090aa55705e3@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: raspl@linux.vnet.ibm.com, Janosch Frank , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , KVM list Return-path: Received: from mail-lf0-f67.google.com ([209.85.215.67]:34430 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751116AbdFVHwX (ORCPT ); Thu, 22 Jun 2017 03:52:23 -0400 Received: by mail-lf0-f67.google.com with SMTP id l200so1047725lfg.1 for ; Thu, 22 Jun 2017 00:52:22 -0700 (PDT) In-Reply-To: Content-Language: en-US Sender: kvm-owner@vger.kernel.org List-ID: On 22/06/2017 09:46, Stefan Raspl wrote: > OK, so that sounds like we're in agreement that this is a useful > feature. The question is whether to do it via an interactive command > or a command line switch, or both. > I guess my vote would be to do both, i.e. add > '--debugfs-include-past' as a new command line switch to the patch, > but leave 't' in place. I would prefer to add only the new option for now. Paolo