From: "Arnd Bergmann" <arnd@arndb.de>
To: "Simon Horman" <simon.horman@corigine.com>,
"Arnd Bergmann" <arnd@kernel.org>
Cc: "Shannon Nelson" <shannon.nelson@amd.com>,
"Brett Creeley" <brett.creeley@amd.com>,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
Netdev <netdev@vger.kernel.org>,
linux-kernel@vger.kernel.org,
"Conor Dooley" <conor.dooley@microchip.com>,
"Philipp Zabel" <p.zabel@pengutronix.de>
Subject: Re: [PATCH] pds_core: fix linking without CONFIG_DEBUG_FS
Date: Mon, 01 May 2023 21:34:54 +0200 [thread overview]
Message-ID: <db973b45-a292-4924-a351-40bec063434e@app.fastmail.com> (raw)
In-Reply-To: <ZE/duNH3lBLreNkJ@corigine.com>
On Mon, May 1, 2023, at 17:41, Simon Horman wrote:
> On Mon, May 01, 2023 at 05:06:14PM +0200, Arnd Bergmann wrote:
>
> While exercising this I noticed that building pds_core fails
> if either CONFIG_AUXILIARY_BUS or NET_DEVLINK are not enabled.
>
> I think the solution is for PFS_CORE to select both CONFIG_AUXILIARY_BUS
> and NET_DEVLINK.
Makes sense. I just double-checked the other uses of these symbols
to see if they should be 'select' or 'depends on', and you are
right that selecting them is the correct solution.
There are two instances of 'depends on CONFIG_AUXILIARY_BUS'
in drivers/reset that both should be 'select' as well, since
this is not a user-visible symbol.
Arnd
next prev parent reply other threads:[~2023-05-01 19:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-01 15:06 [PATCH] pds_core: fix linking without CONFIG_DEBUG_FS Arnd Bergmann
2023-05-01 15:41 ` Simon Horman
2023-05-01 19:34 ` Arnd Bergmann [this message]
2023-05-01 22:35 ` Jakub Kicinski
2023-05-02 4:01 ` Shannon Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db973b45-a292-4924-a351-40bec063434e@app.fastmail.com \
--to=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=brett.creeley@amd.com \
--cc=conor.dooley@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=shannon.nelson@amd.com \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.