From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 782FEC4332F for ; Sat, 26 Nov 2022 09:46:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229542AbiKZJqE (ORCPT ); Sat, 26 Nov 2022 04:46:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229502AbiKZJqC (ORCPT ); Sat, 26 Nov 2022 04:46:02 -0500 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 597921CFEF; Sat, 26 Nov 2022 01:46:01 -0800 (PST) Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4NK6Kd0krvzRpYH; Sat, 26 Nov 2022 17:45:25 +0800 (CST) Received: from kwepemm600003.china.huawei.com (7.193.23.202) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 26 Nov 2022 17:45:59 +0800 Received: from [10.67.111.205] (10.67.111.205) by kwepemm600003.china.huawei.com (7.193.23.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 26 Nov 2022 17:45:58 +0800 Subject: Re: [PATCH bpf v2 1/5] bpf: Adapt 32-bit return value kfunc for 32-bit ARM when zext extension To: Martin KaFai Lau CC: , , , , , , , , , , , , , , , , , , , , , , , , , , References: <20221107092032.178235-1-yangjihong1@huawei.com> <20221107092032.178235-2-yangjihong1@huawei.com> <62bf28ac-c1fa-fc60-ce52-6d993a8a4bbf@linux.dev> From: Yang Jihong Message-ID: Date: Sat, 26 Nov 2022 17:45:57 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <62bf28ac-c1fa-fc60-ce52-6d993a8a4bbf@linux.dev> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.111.205] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemm600003.china.huawei.com (7.193.23.202) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On 2022/11/9 7:12, Martin KaFai Lau wrote: > On 11/7/22 1:20 AM, Yang Jihong wrote: >> For ARM32 architecture, if data width of kfunc return value is 32 bits, >> need to do explicit zero extension for high 32-bit, insn_def_regno should >> return dst_reg for BPF_JMP type of BPF_PSEUDO_KFUNC_CALL. Otherwise, >> opt_subreg_zext_lo32_rnd_hi32 returns -EFAULT, resulting in BPF failure. >> >> Signed-off-by: Yang Jihong >> --- >>   kernel/bpf/verifier.c | 3 +++ >>   1 file changed, 3 insertions(+) >> >> diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c >> index 7f0a9f6cb889..bac37757ffca 100644 >> --- a/kernel/bpf/verifier.c >> +++ b/kernel/bpf/verifier.c >> @@ -2404,6 +2404,9 @@ static int insn_def_regno(const struct bpf_insn >> *insn) >>   { >>       switch (BPF_CLASS(insn->code)) { >>       case BPF_JMP: >> +        if (insn->src_reg == BPF_PSEUDO_KFUNC_CALL) >> +            return insn->dst_reg; > > This does not look right.  A kfunc can return void.  The btf type of the > kfunc's return value needs to be checked against "void" first? OK, will add the check in next version. > Also, this will affect insn_has_def32(), does is_reg64 (called from > insn_has_def32) need to be adjusted also? Yes, is_reg64 need to be adjusted, will fix in next version. > > > For patch 2, as replied earlier in v1, I would separate out the prog > that does __sk_buff->sk and use the uapi's bpf.h instead of vmlinux.h > since it does not need CO-RE. OK, will remove adjust sk check patches in next verion. As mentioned in v1: "bpf-tc program can take'struct sk_buff *skb' instead of'struct __sk_buff *skb' but it will be a separate topic." It is a separate topic, only the lskel test cases are affected. The ARM32 kfunc function is not affected. > > This set should target for bpf-next instead of bpf. OK, will send to bpf-next in next version. Thanks, Yang From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 84075C4332F for ; Sat, 26 Nov 2022 09:47:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0pfnaiDeUgtHcNs66/dL5QIpFL/w7Q0BlBEn5QM4uxY=; b=XRumQHAEAk4DWCbT+5/hT9mDf5 AIpxcqU4feNzummNiPqkVkOsxLlCKd+xqgAGCSMEG+9CiKnG+0ZQso7c+dnYbRedwMaT1A0QdIeCU bwzjxmx/TCc3kNBPm163dp7UY/juha8EPyRopt/UfLG0utdAZ0Fe8FGY/BErwupidVL9yYzRw3gOE 4OfrRKmUC4C/n7KaWlZTQiox4AWOzEsAfagqnNKQ3P7LCdHACNBz8pLf99VqdrERvE4w9aj4m3iJA KDIjVmwS8ucup6LxOfRg4aCmOQl2kV6J+Hic+dewKwYF8Fz1MT4+6g7Tt0uLPtIDTe0vhO8tOa5dl sTGMPdDw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oyrlH-005MOQ-Iv; Sat, 26 Nov 2022 09:46:15 +0000 Received: from szxga02-in.huawei.com ([45.249.212.188]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oyrlE-005MJq-Lj for linux-arm-kernel@lists.infradead.org; Sat, 26 Nov 2022 09:46:14 +0000 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4NK6Kd0krvzRpYH; Sat, 26 Nov 2022 17:45:25 +0800 (CST) Received: from kwepemm600003.china.huawei.com (7.193.23.202) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 26 Nov 2022 17:45:59 +0800 Received: from [10.67.111.205] (10.67.111.205) by kwepemm600003.china.huawei.com (7.193.23.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 26 Nov 2022 17:45:58 +0800 Subject: Re: [PATCH bpf v2 1/5] bpf: Adapt 32-bit return value kfunc for 32-bit ARM when zext extension To: Martin KaFai Lau CC: , , , , , , , , , , , , , , , , , , , , , , , , , , References: <20221107092032.178235-1-yangjihong1@huawei.com> <20221107092032.178235-2-yangjihong1@huawei.com> <62bf28ac-c1fa-fc60-ce52-6d993a8a4bbf@linux.dev> From: Yang Jihong Message-ID: Date: Sat, 26 Nov 2022 17:45:57 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <62bf28ac-c1fa-fc60-ce52-6d993a8a4bbf@linux.dev> Content-Language: en-US X-Originating-IP: [10.67.111.205] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemm600003.china.huawei.com (7.193.23.202) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221126_014613_071465_5EB3D50F X-CRM114-Status: GOOD ( 16.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGVsbG8sCgpPbiAyMDIyLzExLzkgNzoxMiwgTWFydGluIEthRmFpIExhdSB3cm90ZToKPiBPbiAx MS83LzIyIDE6MjAgQU0sIFlhbmcgSmlob25nIHdyb3RlOgo+PiBGb3IgQVJNMzIgYXJjaGl0ZWN0 dXJlLCBpZiBkYXRhIHdpZHRoIG9mIGtmdW5jIHJldHVybiB2YWx1ZSBpcyAzMiBiaXRzLAo+PiBu ZWVkIHRvIGRvIGV4cGxpY2l0IHplcm8gZXh0ZW5zaW9uIGZvciBoaWdoIDMyLWJpdCwgaW5zbl9k ZWZfcmVnbm8gc2hvdWxkCj4+IHJldHVybiBkc3RfcmVnIGZvciBCUEZfSk1QIHR5cGUgb2YgQlBG X1BTRVVET19LRlVOQ19DQUxMLiBPdGhlcndpc2UsCj4+IG9wdF9zdWJyZWdfemV4dF9sbzMyX3Ju ZF9oaTMyIHJldHVybnMgLUVGQVVMVCwgcmVzdWx0aW5nIGluIEJQRiBmYWlsdXJlLgo+Pgo+PiBT aWduZWQtb2ZmLWJ5OiBZYW5nIEppaG9uZyA8eWFuZ2ppaG9uZzFAaHVhd2VpLmNvbT4KPj4gLS0t Cj4+IMKgIGtlcm5lbC9icGYvdmVyaWZpZXIuYyB8IDMgKysrCj4+IMKgIDEgZmlsZSBjaGFuZ2Vk LCAzIGluc2VydGlvbnMoKykKPj4KPj4gZGlmZiAtLWdpdCBhL2tlcm5lbC9icGYvdmVyaWZpZXIu YyBiL2tlcm5lbC9icGYvdmVyaWZpZXIuYwo+PiBpbmRleCA3ZjBhOWY2Y2I4ODkuLmJhYzM3NzU3 ZmZjYSAxMDA2NDQKPj4gLS0tIGEva2VybmVsL2JwZi92ZXJpZmllci5jCj4+ICsrKyBiL2tlcm5l bC9icGYvdmVyaWZpZXIuYwo+PiBAQCAtMjQwNCw2ICsyNDA0LDkgQEAgc3RhdGljIGludCBpbnNu X2RlZl9yZWdubyhjb25zdCBzdHJ1Y3QgYnBmX2luc24gCj4+ICppbnNuKQo+PiDCoCB7Cj4+IMKg wqDCoMKgwqAgc3dpdGNoIChCUEZfQ0xBU1MoaW5zbi0+Y29kZSkpIHsKPj4gwqDCoMKgwqDCoCBj YXNlIEJQRl9KTVA6Cj4+ICvCoMKgwqDCoMKgwqDCoCBpZiAoaW5zbi0+c3JjX3JlZyA9PSBCUEZf UFNFVURPX0tGVU5DX0NBTEwpCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiBpbnNu LT5kc3RfcmVnOwo+IAo+IFRoaXMgZG9lcyBub3QgbG9vayByaWdodC7CoCBBIGtmdW5jIGNhbiBy ZXR1cm4gdm9pZC7CoCBUaGUgYnRmIHR5cGUgb2YgdGhlIAo+IGtmdW5jJ3MgcmV0dXJuIHZhbHVl IG5lZWRzIHRvIGJlIGNoZWNrZWQgYWdhaW5zdCAidm9pZCIgZmlyc3Q/Ck9LLCB3aWxsIGFkZCB0 aGUgY2hlY2sgaW4gbmV4dCB2ZXJzaW9uLgoKPiBBbHNvLCB0aGlzIHdpbGwgYWZmZWN0IGluc25f aGFzX2RlZjMyKCksIGRvZXMgaXNfcmVnNjQgKGNhbGxlZCBmcm9tIAo+IGluc25faGFzX2RlZjMy KSBuZWVkIHRvIGJlIGFkanVzdGVkIGFsc28/ClllcywgaXNfcmVnNjQgbmVlZCB0byBiZSBhZGp1 c3RlZCwgd2lsbCBmaXggaW4gbmV4dCB2ZXJzaW9uLgo+IAo+IAo+IEZvciBwYXRjaCAyLCBhcyBy ZXBsaWVkIGVhcmxpZXIgaW4gdjEsIEkgd291bGQgc2VwYXJhdGUgb3V0IHRoZSBwcm9nIAo+IHRo YXQgZG9lcyBfX3NrX2J1ZmYtPnNrIGFuZCB1c2UgdGhlIHVhcGkncyBicGYuaCBpbnN0ZWFkIG9m IHZtbGludXguaCAKPiBzaW5jZSBpdCBkb2VzIG5vdCBuZWVkIENPLVJFLgpPSywgd2lsbCByZW1v dmUgYWRqdXN0IHNrIGNoZWNrIHBhdGNoZXMgaW4gbmV4dCB2ZXJpb24uCgpBcyBtZW50aW9uZWQg aW4gdjE6CiJicGYtdGMgcHJvZ3JhbSBjYW4gdGFrZSdzdHJ1Y3Qgc2tfYnVmZiAqc2tiJyBpbnN0 ZWFkIG9mJ3N0cnVjdApfX3NrX2J1ZmYgKnNrYicgYnV0IGl0IHdpbGwgYmUgYSBzZXBhcmF0ZSB0 b3BpYy4iCgpJdCBpcyBhIHNlcGFyYXRlIHRvcGljLCBvbmx5IHRoZSBsc2tlbCB0ZXN0IGNhc2Vz IGFyZSBhZmZlY3RlZC4KVGhlIEFSTTMyIGtmdW5jIGZ1bmN0aW9uIGlzIG5vdCBhZmZlY3RlZC4K Cj4gCj4gVGhpcyBzZXQgc2hvdWxkIHRhcmdldCBmb3IgYnBmLW5leHQgaW5zdGVhZCBvZiBicGYu Ck9LLCB3aWxsIHNlbmQgdG8gYnBmLW5leHQgaW4gbmV4dCB2ZXJzaW9uLgoKVGhhbmtzLApZYW5n CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1h cm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5v cmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0t a2VybmVsCg==