All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Nelson <eric@nelint.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Henri Roosen <henri.roosen@ginzinger.com>,
	Fugang Duan <fugang.duan@nxp.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: commit-3ac72b7b63d5 breaks networking on iMX28
Date: Fri, 21 Oct 2016 06:48:36 -0700	[thread overview]
Message-ID: <dba221c7-5329-4d5e-2320-c68a95caf206@nelint.com> (raw)
In-Reply-To: <CAOMZO5DG6=pNDYgT4Bf4KBj4UPOwemBHNk6PYd8DZKt6Yp0PfQ@mail.gmail.com>

Thanks Fabio.

On 10/21/2016 06:43 AM, Fabio Estevam wrote:
> Hi Eric,
> 
> On Fri, Oct 21, 2016 at 11:39 AM, Eric Nelson <eric@nelint.com> wrote:
> 
>> Reading the i.MX28 reference manual, it appears that this SoC doesn't
>> have the RACC bit, and I missed removal of the FEC_QUIRK_HAS_RACC flag.
> 
> On MX28 the register is called HW_ENET_MAC_IPACCRXCONF.
> 
> I sent a patch that fixes the issue.
> 

I saw that. Nice catch!

  reply	other threads:[~2016-10-21 13:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-21  9:19 commit-3ac72b7b63d5 breaks networking on iMX28 Henri Roosen
2016-10-21 10:55 ` Fabio Estevam
2016-10-21 11:09   ` Henri Roosen
2016-10-21 13:39 ` Eric Nelson
2016-10-21 13:43   ` Fabio Estevam
2016-10-21 13:48     ` Eric Nelson [this message]
2016-10-21 13:46   ` Eric Nelson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dba221c7-5329-4d5e-2320-c68a95caf206@nelint.com \
    --to=eric@nelint.com \
    --cc=festevam@gmail.com \
    --cc=fugang.duan@nxp.com \
    --cc=henri.roosen@ginzinger.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.