From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4378C433DB for ; Tue, 5 Jan 2021 12:05:06 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3EF6822A84; Tue, 5 Jan 2021 12:05:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3EF6822A84 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=web.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1kwl5E-0007LI-NU; Tue, 05 Jan 2021 12:05:04 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwl5D-0007LB-2r for linux-f2fs-devel@lists.sourceforge.net; Tue, 05 Jan 2021 12:05:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:Subject:From:References:Cc:To:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=fhemPGF7qJLSHf9CL6xDUCzO0PgBOO584c32nkmxX3U=; b=AVzALWlxoGk95KAl3npkZ8kE1 753pU+8WeI5qDi2MCV6mQx6aJJUDbS4TkYTbTMCHN2d6I1VN0UYvdP0pWJZNO6u8Ta9iOvGrQJhwB 031icSHe+MIw9EYdxuahE3K0yx5mR9PGFoAmk2Ils+7Eho2XXMvnaVj6JAIptEbQA56cg=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:Subject:From: References:Cc:To:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=fhemPGF7qJLSHf9CL6xDUCzO0PgBOO584c32nkmxX3U=; b=V2hEKJ6EhS4WeJM5r0Qkeg1rO+ 4+tPGBcFUQrA0KOaBNpRoZNMq2TCEy1Wezsn2wx4gH4bhb/CJJ/NpIlt2zGgzwmE0vYPHM1e+ZazZ VR8MI5t9qfqMWBz9ZjhpyHOsvKxaXE5mTMy42mUvASv+6YHo5ZI8OlcqYu71AZQfQpng=; Received: from mout.web.de ([217.72.192.78]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1kwl57-00G0oU-EI for linux-f2fs-devel@lists.sourceforge.net; Tue, 05 Jan 2021 12:05:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1609848278; bh=fhemPGF7qJLSHf9CL6xDUCzO0PgBOO584c32nkmxX3U=; h=X-UI-Sender-Class:To:Cc:References:From:Subject:Date:In-Reply-To; b=nyDkzO/MeDZVaA/Z1wC0XS73yKw917jG7KI5IfIpsZ3EQm+rJlXusqhojGdAIDXQ8 JddX3yrEjHoeR4i7MdhajkwaCcTjuoHfxOqnLPNjg8C6NV4/XuEyOVwaRnoyhcDXcq 1D8AtCIilRp4vAJQNWdCM2Gwekd+4ItltGp6XA6I= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.2] ([93.131.88.233]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MgiXO-1kKNv02DAC-00gzgx; Tue, 05 Jan 2021 13:04:38 +0100 To: Daeho Jeong , linux-f2fs-devel@lists.sourceforge.net, kernel-janitors@vger.kernel.org References: <20210105041630.1393157-1-daeho43@gmail.com> From: Markus Elfring Message-ID: Date: Tue, 5 Jan 2021 13:04:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210105041630.1393157-1-daeho43@gmail.com> Content-Language: en-GB X-Provags-ID: V03:K1:x4pF7iywt+BKKZhJAPhZyAEAScdbkNldZs5m08C7RqYDjC9IntX tGIg28OZcS72GU4fwKeihfIr3dhFVJDw9BTmYoDprdJBmrprWev4Elc+3N4eyKk75REPB4h sPcxrfC9HlC/hH02aDML3bixW6n5u7raNdopdZNWaQPIF75doTZqIiz9NC8ucutYrmdY6V5 P4MgZM/QMGBT6eqcLjEvQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:q6MEQjG6Kzg=:xC3cRA30Llb3CVgvCfJAbu IclC4jVN1E6+ff84mL265ZhShiq5G9Aog7MjkuXYwRYAJirL1YdwA2XKMEBxBrjboTq/bEv0C kUK/8BKSem/uAoO6Wfju0YzWyElYt383z0b4R7qPlOhHyyXbz56S5UhaTJgDbCus5gg1uSjXS PU7KoG3ExJ3u1FB2AVKW+CG0I+hGN1k4L4MdHOCbzWHuzvP9x57D5gqHuYJ7v5O5+alZJxYXX pOLDB96J905kBSsi+OkYOp1M6slH4qEaLoqoTN+dCwJOiO/+tF4wa7foQZCMRA94wastXoSIp 8Q1/mNdY5APZHTdaOIlFK5RFQ+cQMzbClO3mdXhz9qUm11pdhKYUPfEmoyD1tbmrwsh/hDDA/ ZeMqDlAs461yYkFa955C081OnV4dtDumVqbhYD3UzIQO6KeacDyol8hmJoRnk1eHSgvwMXLuy XOCYsLoMj1zIAV7Pe5Nd6qMInebT0nwTNsgda2mdVo2daOvOzDfguLyvmxr72xvDXhw+n4xHC 1Mb2xYFXdLkeX9BgjfDGfTD485dtUd0dakUw/UrWbwqpKPAIiNJwBjE7eXGgPyeMXLowrNVsb 09wij1lJI7bCS49tptxeDZYT+cRdLys/DtUn6jTEDXHreSdHrsjF4Q6zznHdjhjWqqAHdxjb+ IEJ2ue+VM+nwQ997LN6Zxt3PyZw6cvZHG1SNOMMhbs1Ij1SCPOqNy7UihJnRfKFrkNfhRWRyC cxcxmhRPcOw4Garke9bD8DljwUsjOv1BVbmilT4seTv1B3u4evB5LeofhwsQNTSTdj1P0iWaV hg01YTItl7lKuNPVwq8gfzRmEU9m05Fadi2C1RBnp8a37JNlGIh4XpP8wKjfuNPiX0Jz6comV dbQtRxm1motIuN78EwHA== X-Headers-End: 1kwl57-00G0oU-EI Subject: Re: [f2fs-dev] [PATCH v2] f2fs: fix null page reference in redirty_blocks X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Colin Ian King , kernel-team@android.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net > Fixed null page reference when find_lock_page() fails in > redirty_blocks(). I suggest to choose an other imperative wording for this change description. See also: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=36bbbd0e234d817938bdc52121a0f5473b3e58f5#n89 > v2: changed error value and break the loop when error occurs I propose to use a return statement instead of a break in the second if branch for this function implementation. See also: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=36bbbd0e234d817938bdc52121a0f5473b3e58f5#n481 Regards, Markus _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel