From: Hannes Reinecke <hare@suse.de>
To: Douglas Gilbert <dgilbert@interlog.com>, linux-scsi@vger.kernel.org
Cc: martin.petersen@oracle.com, jejb@linux.vnet.ibm.com
Subject: Re: [PATCH v5 13/23] sg: ioctl handling
Date: Fri, 18 Oct 2019 12:12:09 +0200 [thread overview]
Message-ID: <dbb1089b-dc56-7e6d-e969-6b0f8c9fd167@suse.de> (raw)
In-Reply-To: <20191008075022.30055-14-dgilbert@interlog.com>
On 10/8/19 9:50 AM, Douglas Gilbert wrote:
> Shorten sg_ioctl() by adding some helper functions. sg_ioctl()
> is the main entry point for ioctls used on this driver's
> devices.
>
> Signed-off-by: Douglas Gilbert <dgilbert@interlog.com>
> ---
> drivers/scsi/sg.c | 325 ++++++++++++++++++++++++++++------------------
> 1 file changed, 200 insertions(+), 125 deletions(-)
>
> diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c
> index 2796fef42837..90753f7759c7 100644
> --- a/drivers/scsi/sg.c
> +++ b/drivers/scsi/sg.c
> @@ -72,6 +72,9 @@ static char *sg_version_date = "20190606";
> */
> #define SG_MAX_CDB_SIZE 252
>
> +#define uptr64(val) ((void __user *)(uintptr_t)(val))
> +#define cuptr64(val) ((const void __user *)(uintptr_t)(val))
> +
> #define SG_DEFAULT_TIMEOUT mult_frac(SG_DEFAULT_TIMEOUT_USER, HZ, USER_HZ)
>
> /* Bit positions (flags) for sg_device::fdev_bm bitmask follow */
These defines are used only once; I'd rather drop them and do the
conversion in-place.
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 247165 (AG München), GF: Felix Imendörffer
next prev parent reply other threads:[~2019-10-18 10:12 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 7:49 [PATCH v5 00/23] sg: add v4 interface Douglas Gilbert
2019-10-08 7:50 ` [PATCH v5 01/23] sg: move functions around Douglas Gilbert
2019-10-08 7:50 ` [PATCH v5 02/23] sg: remove typedefs, type+formatting cleanup Douglas Gilbert
2019-10-08 7:50 ` [PATCH v5 03/23] sg: sg_log and is_enabled Douglas Gilbert
2019-10-08 7:50 ` [PATCH v5 04/23] sg: rework sg_poll(), minor changes Douglas Gilbert
2019-10-08 7:50 ` [PATCH v5 05/23] sg: bitops in sg_device Douglas Gilbert
2019-10-18 10:05 ` Hannes Reinecke
2019-10-21 13:22 ` Douglas Gilbert
2019-10-21 13:38 ` Hannes Reinecke
2019-10-08 7:50 ` [PATCH v5 06/23] sg: make open count an atomic Douglas Gilbert
2019-10-08 7:50 ` [PATCH v5 07/23] sg: move header to uapi section Douglas Gilbert
2019-10-08 7:50 ` [PATCH v5 08/23] sg: speed sg_poll and sg_get_num_waiting Douglas Gilbert
2019-10-08 7:50 ` [PATCH v5 09/23] sg: sg_allow_if_err_recovery and renames Douglas Gilbert
2019-10-08 7:50 ` [PATCH v5 10/23] sg: remove access_ok functions Douglas Gilbert
2019-10-08 7:50 ` [PATCH v5 11/23] sg: improve naming Douglas Gilbert
2019-10-18 10:06 ` Hannes Reinecke
2019-10-08 7:50 ` [PATCH v5 12/23] sg: change rwlock to spinlock Douglas Gilbert
2019-10-18 10:09 ` Hannes Reinecke
2019-10-08 7:50 ` [PATCH v5 13/23] sg: ioctl handling Douglas Gilbert
2019-10-18 10:12 ` Hannes Reinecke [this message]
2019-10-24 2:47 ` Douglas Gilbert
2019-10-08 7:50 ` [PATCH v5 14/23] sg: split sg_read Douglas Gilbert
2019-10-18 10:15 ` Hannes Reinecke
2019-10-08 7:50 ` [PATCH v5 15/23] sg: sg_common_write add structure for arguments Douglas Gilbert
2019-10-18 10:16 ` Hannes Reinecke
2019-10-08 7:50 ` [PATCH v5 16/23] sg: rework sg_vma_fault Douglas Gilbert
2019-10-18 10:17 ` Hannes Reinecke
2019-10-24 3:07 ` Douglas Gilbert
2019-10-08 7:50 ` [PATCH v5 17/23] sg: rework sg_mmap Douglas Gilbert
2019-10-18 10:18 ` Hannes Reinecke
2019-10-08 7:50 ` [PATCH v5 18/23] sg: replace sg_allow_access Douglas Gilbert
2019-10-18 10:20 ` Hannes Reinecke
2019-10-08 7:50 ` [PATCH v5 19/23] sg: rework scatter gather handling Douglas Gilbert
2019-10-18 10:22 ` Hannes Reinecke
2019-10-08 7:50 ` [PATCH v5 20/23] sg: introduce request state machine Douglas Gilbert
2019-10-18 10:25 ` Hannes Reinecke
2019-10-24 4:24 ` Douglas Gilbert
2019-10-24 5:51 ` Hannes Reinecke
2019-10-08 7:50 ` [PATCH v5 21/23] sg: sg_find_srp_by_id Douglas Gilbert
2019-10-18 10:27 ` Hannes Reinecke
2019-10-08 7:50 ` [PATCH v5 22/23] sg: sg_fill_request_element Douglas Gilbert
2019-10-18 10:29 ` Hannes Reinecke
2019-10-08 7:50 ` [PATCH v5 23/23] sg: printk change %p to %pK Douglas Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbb1089b-dc56-7e6d-e969-6b0f8c9fd167@suse.de \
--to=hare@suse.de \
--cc=dgilbert@interlog.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.